blob: e16f44135a0ad5821be175b84a0aac790c4ce01c [file] [log] [blame]
Jakub Czapigadadcae62021-04-08 16:29:03 +02001/* SPDX-License-Identifier: GPL-2.0-only */
2
Elyes Haouas5a047462022-12-28 11:43:49 +01003#include <device/dram/ddr2.h>
Jakub Czapigadadcae62021-04-08 16:29:03 +02004#include <dimm_info_util.h>
5#include <spd.h>
6#include <tests/test.h>
7
Subrata Banik6de8b422021-10-26 20:46:21 +05308#define MAX_ALLOWED_MODULE_TYPE 3
9
Subrata Banik3306f372021-10-26 13:19:20 +053010static void test_smbios_bus_width_to_spd_width_parametrized(smbios_memory_type ddr_type)
Jakub Czapigadadcae62021-04-08 16:29:03 +020011{
12 /* Non-ECC variants */
Subrata Banik3306f372021-10-26 13:19:20 +053013 assert_int_equal(MEMORY_BUS_WIDTH_64, smbios_bus_width_to_spd_width(ddr_type, 64, 64));
14 assert_int_equal(MEMORY_BUS_WIDTH_32, smbios_bus_width_to_spd_width(ddr_type, 32, 32));
15 assert_int_equal(MEMORY_BUS_WIDTH_16, smbios_bus_width_to_spd_width(ddr_type, 16, 16));
16 assert_int_equal(MEMORY_BUS_WIDTH_8, smbios_bus_width_to_spd_width(ddr_type, 8, 8));
Jakub Czapigadadcae62021-04-08 16:29:03 +020017 /* Incorrect data width. Fallback to 8-bit */
Subrata Banik3306f372021-10-26 13:19:20 +053018 assert_int_equal(MEMORY_BUS_WIDTH_8, smbios_bus_width_to_spd_width(ddr_type, 15, 15));
Jakub Czapigadadcae62021-04-08 16:29:03 +020019
20 /* ECC variants */
Subrata Banik3306f372021-10-26 13:19:20 +053021 uint8_t extension_8bits = SPD_ECC_8BIT;
22 if (ddr_type == MEMORY_TYPE_DDR5 || ddr_type == MEMORY_TYPE_LPDDR5)
23 extension_8bits = SPD_ECC_8BIT_LP5_DDR5;
24
25 assert_int_equal(MEMORY_BUS_WIDTH_64 | extension_8bits,
Jakub Czapigac08b6a72022-01-10 13:36:47 +000026 smbios_bus_width_to_spd_width(ddr_type, 64 + 8, 64));
Subrata Banik3306f372021-10-26 13:19:20 +053027 assert_int_equal(MEMORY_BUS_WIDTH_32 | extension_8bits,
Jakub Czapigac08b6a72022-01-10 13:36:47 +000028 smbios_bus_width_to_spd_width(ddr_type, 32 + 8, 32));
Subrata Banik3306f372021-10-26 13:19:20 +053029 assert_int_equal(MEMORY_BUS_WIDTH_16 | extension_8bits,
Jakub Czapigac08b6a72022-01-10 13:36:47 +000030 smbios_bus_width_to_spd_width(ddr_type, 16 + 8, 16));
Subrata Banik3306f372021-10-26 13:19:20 +053031 assert_int_equal(MEMORY_BUS_WIDTH_8 | extension_8bits,
Jakub Czapigac08b6a72022-01-10 13:36:47 +000032 smbios_bus_width_to_spd_width(ddr_type, 8 + 8, 8));
Jakub Czapigadadcae62021-04-08 16:29:03 +020033 /* Incorrect data width. Fallback to 8-bit */
Subrata Banik3306f372021-10-26 13:19:20 +053034 assert_int_equal(MEMORY_BUS_WIDTH_8 | extension_8bits,
Jakub Czapigac08b6a72022-01-10 13:36:47 +000035 smbios_bus_width_to_spd_width(ddr_type, 15 + 8, 15));
Subrata Banik3306f372021-10-26 13:19:20 +053036}
37
38static void test_smbios_bus_width_to_spd_width(void **state)
39{
40 smbios_memory_type memory_type[] = {
Jakub Czapigac08b6a72022-01-10 13:36:47 +000041 MEMORY_TYPE_DDR2, MEMORY_TYPE_DDR3, MEMORY_TYPE_DDR4, MEMORY_TYPE_DDR5,
42 MEMORY_TYPE_LPDDR3, MEMORY_TYPE_LPDDR4, MEMORY_TYPE_LPDDR5,
Subrata Banik3306f372021-10-26 13:19:20 +053043 };
44
45 for (int i = 0; i < ARRAY_SIZE(memory_type); i++) {
46 print_message("test_smbios_bus_width_to_spd_width_parametrized(%d)\n",
Jakub Czapigac08b6a72022-01-10 13:36:47 +000047 memory_type[i]);
Subrata Banik3306f372021-10-26 13:19:20 +053048 test_smbios_bus_width_to_spd_width_parametrized(memory_type[i]);
49 }
Jakub Czapigadadcae62021-04-08 16:29:03 +020050}
51
52static void test_smbios_memory_size_to_mib(void **state)
53{
54 uint32_t extended_size;
55 uint16_t memory_size;
56
57 /* Unknown memory size */
58 assert_int_equal(0, smbios_memory_size_to_mib(0xFFFF, 0));
59 assert_int_equal(0, smbios_memory_size_to_mib(0xFFFF, 0xFFFF));
60 assert_int_equal(0, smbios_memory_size_to_mib(0xFFFF, 87642));
61
62 /* 32GiB - 1MiB */
63 extended_size = 0;
64 assert_int_equal(extended_size, smbios_memory_size_to_mib(0x7FFF, extended_size));
65 extended_size = 0xFFFFFFFF;
66 assert_int_equal(extended_size, smbios_memory_size_to_mib(0x7FFF, extended_size));
67 extended_size = 0xDEDE6666;
68 assert_int_equal(extended_size, smbios_memory_size_to_mib(0x7FFF, extended_size));
69
70 /* Memory size in KiB when MSB is flipped */
71 memory_size = 0x0 & 0x8000; /* Zero bytes */
72 assert_int_equal(0, smbios_memory_size_to_mib(memory_size, 0));
73 assert_int_equal(0, smbios_memory_size_to_mib(memory_size, 0xFFFFFFFF));
74 assert_int_equal(0, smbios_memory_size_to_mib(memory_size, 2345568));
75 memory_size = (31 * KiB) | 0x8000;
76 assert_int_equal(31, smbios_memory_size_to_mib(memory_size, 0));
77 assert_int_equal(31, smbios_memory_size_to_mib(memory_size, 0xFFFFFFFF));
78 assert_int_equal(31, smbios_memory_size_to_mib(memory_size, 72594344));
79
80 /* Value in MiB Only when memory size is not 0xFFFF and 0x7FFF and MSB is not set */
81 memory_size = 32766; /* value in MiB */
82 assert_int_equal(memory_size, smbios_memory_size_to_mib(memory_size, 0));
83 assert_int_equal(memory_size, smbios_memory_size_to_mib(memory_size, 0xFFFFFFFF));
84 assert_int_equal(memory_size, smbios_memory_size_to_mib(memory_size, 694735));
85}
86
Subrata Banik6de8b422021-10-26 20:46:21 +053087static void test_smbios_form_factor_to_spd_mod_type_ddr(smbios_memory_type memory_type)
Jakub Czapigadadcae62021-04-08 16:29:03 +020088{
Jakub Czapigadadcae62021-04-08 16:29:03 +020089 const smbios_memory_form_factor undefined_factors[] = {
Jakub Czapigac08b6a72022-01-10 13:36:47 +000090 MEMORY_FORMFACTOR_OTHER, MEMORY_FORMFACTOR_UNKNOWN,
91 MEMORY_FORMFACTOR_SIMM, MEMORY_FORMFACTOR_SIP,
92 MEMORY_FORMFACTOR_CHIP, MEMORY_FORMFACTOR_DIP,
93 MEMORY_FORMFACTOR_ZIP, MEMORY_FORMFACTOR_PROPRIETARY_CARD,
94 MEMORY_FORMFACTOR_TSOP, MEMORY_FORMFACTOR_ROC,
95 MEMORY_FORMFACTOR_SRIMM, MEMORY_FORMFACTOR_FBDIMM,
Jakub Czapigadadcae62021-04-08 16:29:03 +020096 MEMORY_FORMFACTOR_DIE,
97 };
98 for (int i = 0; i < ARRAY_SIZE(undefined_factors); ++i) {
Jakub Czapigac08b6a72022-01-10 13:36:47 +000099 assert_int_equal(SPD_UNDEFINED, smbios_form_factor_to_spd_mod_type(
100 memory_type, undefined_factors[i]));
Jakub Czapigadadcae62021-04-08 16:29:03 +0200101 }
102}
103
Subrata Banik6de8b422021-10-26 20:46:21 +0530104static void test_smbios_form_factor_to_spd_mod_type_ddrx_parametrized(
Jakub Czapigac08b6a72022-01-10 13:36:47 +0000105 smbios_memory_type memory_type, const LargestIntegralType udimm_allowed[],
106 const LargestIntegralType rdimm_allowed[], LargestIntegralType expected_module_type)
Subrata Banik6de8b422021-10-26 20:46:21 +0530107{
108 print_message("%s(%d)\n", __func__, memory_type);
109
110 assert_in_set(smbios_form_factor_to_spd_mod_type(memory_type, MEMORY_FORMFACTOR_DIMM),
Jakub Czapigac08b6a72022-01-10 13:36:47 +0000111 udimm_allowed, MAX_ALLOWED_MODULE_TYPE);
Subrata Banik6de8b422021-10-26 20:46:21 +0530112
113 assert_in_set(smbios_form_factor_to_spd_mod_type(memory_type, MEMORY_FORMFACTOR_RIMM),
Jakub Czapigac08b6a72022-01-10 13:36:47 +0000114 rdimm_allowed, MAX_ALLOWED_MODULE_TYPE);
Subrata Banik6de8b422021-10-26 20:46:21 +0530115
Jakub Czapigac08b6a72022-01-10 13:36:47 +0000116 assert_int_equal(expected_module_type, smbios_form_factor_to_spd_mod_type(
117 memory_type, MEMORY_FORMFACTOR_SODIMM));
Subrata Banik6de8b422021-10-26 20:46:21 +0530118
119 test_smbios_form_factor_to_spd_mod_type_ddr(memory_type);
120}
121
122static void test_smbios_form_factor_to_spd_mod_type_lpddrx(smbios_memory_type memory_type)
123{
124 print_message("%s(%d)\n", __func__, memory_type);
125 /* Form factors defined in coreboot */
Jakub Czapigac08b6a72022-01-10 13:36:47 +0000126 assert_int_equal(LPX_SPD_NONDIMM, smbios_form_factor_to_spd_mod_type(
127 memory_type, MEMORY_FORMFACTOR_ROC));
Subrata Banik6de8b422021-10-26 20:46:21 +0530128}
129
130static void test_smbios_form_factor_to_spd_mod_type(void **state)
131{
132 const struct smbios_form_factor_test_info_ddrx {
133 smbios_memory_type memory_type;
134 const LargestIntegralType udimm_allowed[MAX_ALLOWED_MODULE_TYPE];
135 const LargestIntegralType rdimm_allowed[MAX_ALLOWED_MODULE_TYPE];
136 LargestIntegralType expected_module_type;
137 } ddrx_info[] = {
138 {
139 .memory_type = MEMORY_TYPE_DDR2,
Elyes Haouas5a047462022-12-28 11:43:49 +0100140 .udimm_allowed = {SPD_DDR2_DIMM_TYPE_UDIMM,
141 SPD_DDR2_DIMM_TYPE_MICRO_DIMM,
142 SPD_DDR2_DIMM_TYPE_MINI_UDIMM},
143 .rdimm_allowed = {SPD_DDR2_DIMM_TYPE_RDIMM,
144 SPD_DDR2_DIMM_TYPE_MINI_RDIMM},
145 .expected_module_type = SPD_DDR2_DIMM_TYPE_SO_DIMM,
Subrata Banik6de8b422021-10-26 20:46:21 +0530146 },
147 {
148 .memory_type = MEMORY_TYPE_DDR3,
Jakub Czapigac08b6a72022-01-10 13:36:47 +0000149 .udimm_allowed = {DDR3_SPD_UDIMM, DDR3_SPD_MICRO_DIMM,
150 DDR3_SPD_MINI_UDIMM},
151 .rdimm_allowed = {DDR3_SPD_RDIMM, DDR3_SPD_MINI_RDIMM},
152 .expected_module_type = DDR3_SPD_SODIMM,
Subrata Banik6de8b422021-10-26 20:46:21 +0530153 },
154 {
155 .memory_type = MEMORY_TYPE_DDR4,
Jakub Czapigac08b6a72022-01-10 13:36:47 +0000156 .udimm_allowed = {DDR4_SPD_UDIMM, DDR4_SPD_MINI_UDIMM},
157 .rdimm_allowed = {DDR4_SPD_RDIMM, DDR4_SPD_MINI_RDIMM},
Subrata Banik6de8b422021-10-26 20:46:21 +0530158 .expected_module_type = DDR4_SPD_SODIMM,
159 },
Jakub Czapigac08b6a72022-01-10 13:36:47 +0000160 {.memory_type = MEMORY_TYPE_DDR5,
161 .udimm_allowed = {DDR5_SPD_UDIMM, DDR5_SPD_MINI_UDIMM},
162 .rdimm_allowed = {DDR5_SPD_RDIMM, DDR5_SPD_MINI_RDIMM},
163 .expected_module_type = DDR5_SPD_SODIMM},
Subrata Banik6de8b422021-10-26 20:46:21 +0530164 };
165
166 /* Test for DDRx DIMM Modules */
167 for (int i = 0; i < ARRAY_SIZE(ddrx_info); i++)
168 test_smbios_form_factor_to_spd_mod_type_ddrx_parametrized(
Jakub Czapigac08b6a72022-01-10 13:36:47 +0000169 ddrx_info[i].memory_type, ddrx_info[i].udimm_allowed,
170 ddrx_info[i].rdimm_allowed, ddrx_info[i].expected_module_type);
Subrata Banik6de8b422021-10-26 20:46:21 +0530171
172 smbios_memory_type lpddrx_memory_type[] = {
173 MEMORY_TYPE_LPDDR3,
174 MEMORY_TYPE_LPDDR4,
175 MEMORY_TYPE_LPDDR5,
176 };
177
178 /* Test for Lpddrx DIMM Modules */
179 for (int i = 0; i < ARRAY_SIZE(lpddrx_memory_type); i++)
180 test_smbios_form_factor_to_spd_mod_type_lpddrx(lpddrx_memory_type[i]);
181}
182
Jakub Czapigadadcae62021-04-08 16:29:03 +0200183int main(void)
184{
185 const struct CMUnitTest tests[] = {
186 cmocka_unit_test(test_smbios_bus_width_to_spd_width),
187 cmocka_unit_test(test_smbios_memory_size_to_mib),
188 cmocka_unit_test(test_smbios_form_factor_to_spd_mod_type),
189 };
190
Jakub Czapiga7c6081e2021-08-25 16:27:35 +0200191 return cb_run_group_tests(tests, NULL, NULL);
Jakub Czapigadadcae62021-04-08 16:29:03 +0200192}