Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 1 | /* |
| 2 | * This file is part of the coreboot project. |
| 3 | * |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 4 | * Copyright (C) 2011 secunet Security Networks AG |
| 5 | * Copyright 2015 Google Inc. |
Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 6 | * |
| 7 | * This program is free software; you can redistribute it and/or modify |
| 8 | * it under the terms of the GNU General Public License as published by |
| 9 | * the Free Software Foundation; version 2 of the License. |
| 10 | * |
| 11 | * This program is distributed in the hope that it will be useful, |
| 12 | * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 13 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| 14 | * GNU General Public License for more details. |
Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 15 | */ |
| 16 | |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 17 | #include <assert.h> |
Elyes HAOUAS | 351e3e5 | 2019-04-05 18:11:19 +0200 | [diff] [blame] | 18 | #include <console/console.h> |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 19 | #include <string.h> |
| 20 | #include <stdlib.h> |
| 21 | #include <boot_device.h> |
| 22 | #include <cbfs.h> |
Julius Werner | 98eeb96 | 2019-12-11 15:47:42 -0800 | [diff] [blame^] | 23 | #include <commonlib/bsd/compression.h> |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 24 | #include <endian.h> |
| 25 | #include <lib.h> |
| 26 | #include <symbols.h> |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 27 | #include <timestamp.h> |
Pratik Prajapati | 2a7708a | 2016-11-30 17:29:10 -0800 | [diff] [blame] | 28 | #include <fmap.h> |
Philipp Deppenwiese | 66f9a09 | 2018-11-08 10:59:40 +0100 | [diff] [blame] | 29 | #include <security/vboot/vboot_crtm.h> |
Julius Werner | 815611e | 2019-12-05 22:29:07 -0800 | [diff] [blame] | 30 | #include <security/vboot/vboot_common.h> |
Patrick Georgi | 58a150a | 2016-05-02 17:22:29 +0800 | [diff] [blame] | 31 | |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 32 | #define ERROR(x...) printk(BIOS_ERR, "CBFS: " x) |
| 33 | #define LOG(x...) printk(BIOS_INFO, "CBFS: " x) |
Julius Werner | cd49cce | 2019-03-05 16:53:33 -0800 | [diff] [blame] | 34 | #if CONFIG(DEBUG_CBFS) |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 35 | #define DEBUG(x...) printk(BIOS_SPEW, "CBFS: " x) |
| 36 | #else |
| 37 | #define DEBUG(x...) |
| 38 | #endif |
Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 39 | |
Aaron Durbin | 37a5d15 | 2015-09-17 16:09:30 -0500 | [diff] [blame] | 40 | int cbfs_boot_locate(struct cbfsf *fh, const char *name, uint32_t *type) |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 41 | { |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 42 | struct region_device rdev; |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 43 | |
Aaron Durbin | fe338e2 | 2019-11-18 12:35:21 -0700 | [diff] [blame] | 44 | if (cbfs_boot_region_device(&rdev)) |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 45 | return -1; |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 46 | |
Philipp Deppenwiese | 66f9a09 | 2018-11-08 10:59:40 +0100 | [diff] [blame] | 47 | int ret = cbfs_locate(fh, &rdev, name, type); |
Wim Vervoorn | 114e2e8 | 2019-11-05 14:09:16 +0100 | [diff] [blame] | 48 | |
| 49 | if (CONFIG(VBOOT_ENABLE_CBFS_FALLBACK) && ret) { |
| 50 | |
| 51 | /* |
| 52 | * When VBOOT_ENABLE_CBFS_FALLBACK is enabled and a file is not available in the |
| 53 | * active RW region, the RO (COREBOOT) region will be used to locate the file. |
| 54 | * |
| 55 | * This functionality makes it possible to avoid duplicate files in the RO |
| 56 | * and RW partitions while maintaining updateability. |
| 57 | * |
| 58 | * Files can be added to the RO_REGION_ONLY config option to use this feature. |
| 59 | */ |
| 60 | printk(BIOS_DEBUG, "Fall back to RO region for %s\n", name); |
| 61 | ret = cbfs_locate_file_in_region(fh, "COREBOOT", name, type); |
| 62 | } |
| 63 | |
Philipp Deppenwiese | 66f9a09 | 2018-11-08 10:59:40 +0100 | [diff] [blame] | 64 | if (!ret) |
| 65 | if (vboot_measure_cbfs_hook(fh, name)) |
| 66 | return -1; |
| 67 | |
| 68 | return ret; |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 69 | } |
| 70 | |
| 71 | void *cbfs_boot_map_with_leak(const char *name, uint32_t type, size_t *size) |
| 72 | { |
Aaron Durbin | 37a5d15 | 2015-09-17 16:09:30 -0500 | [diff] [blame] | 73 | struct cbfsf fh; |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 74 | size_t fsize; |
| 75 | |
| 76 | if (cbfs_boot_locate(&fh, name, &type)) |
| 77 | return NULL; |
| 78 | |
Aaron Durbin | 37a5d15 | 2015-09-17 16:09:30 -0500 | [diff] [blame] | 79 | fsize = region_device_sz(&fh.data); |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 80 | |
| 81 | if (size != NULL) |
| 82 | *size = fsize; |
| 83 | |
Aaron Durbin | 37a5d15 | 2015-09-17 16:09:30 -0500 | [diff] [blame] | 84 | return rdev_mmap(&fh.data, 0, fsize); |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 85 | } |
| 86 | |
Pratik Prajapati | 2a7708a | 2016-11-30 17:29:10 -0800 | [diff] [blame] | 87 | int cbfs_locate_file_in_region(struct cbfsf *fh, const char *region_name, |
Philipp Deppenwiese | 66f9a09 | 2018-11-08 10:59:40 +0100 | [diff] [blame] | 88 | const char *name, uint32_t *type) |
Pratik Prajapati | 2a7708a | 2016-11-30 17:29:10 -0800 | [diff] [blame] | 89 | { |
| 90 | struct region_device rdev; |
| 91 | |
| 92 | if (fmap_locate_area_as_rdev(region_name, &rdev)) { |
| 93 | LOG("%s region not found while looking for %s\n", |
Philipp Deppenwiese | 66f9a09 | 2018-11-08 10:59:40 +0100 | [diff] [blame] | 94 | region_name, name); |
Pratik Prajapati | 2a7708a | 2016-11-30 17:29:10 -0800 | [diff] [blame] | 95 | return -1; |
| 96 | } |
| 97 | |
| 98 | return cbfs_locate(fh, &rdev, name, type); |
| 99 | } |
| 100 | |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 101 | size_t cbfs_load_and_decompress(const struct region_device *rdev, size_t offset, |
| 102 | size_t in_size, void *buffer, size_t buffer_size, uint32_t compression) |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 103 | { |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 104 | size_t out_size; |
| 105 | |
| 106 | switch (compression) { |
| 107 | case CBFS_COMPRESS_NONE: |
Julius Werner | f975e55 | 2016-08-19 15:43:06 -0700 | [diff] [blame] | 108 | if (buffer_size < in_size) |
| 109 | return 0; |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 110 | if (rdev_readat(rdev, buffer, offset, in_size) != in_size) |
| 111 | return 0; |
| 112 | return in_size; |
| 113 | |
| 114 | case CBFS_COMPRESS_LZ4: |
| 115 | if ((ENV_BOOTBLOCK || ENV_VERSTAGE) && |
Julius Werner | cd49cce | 2019-03-05 16:53:33 -0800 | [diff] [blame] | 116 | !CONFIG(COMPRESS_PRERAM_STAGES)) |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 117 | return 0; |
| 118 | |
| 119 | /* Load the compressed image to the end of the available memory |
| 120 | * area for in-place decompression. It is the responsibility of |
| 121 | * the caller to ensure that buffer_size is large enough |
| 122 | * (see compression.h, guaranteed by cbfstool for stages). */ |
| 123 | void *compr_start = buffer + buffer_size - in_size; |
| 124 | if (rdev_readat(rdev, compr_start, offset, in_size) != in_size) |
| 125 | return 0; |
| 126 | |
| 127 | timestamp_add_now(TS_START_ULZ4F); |
| 128 | out_size = ulz4fn(compr_start, in_size, buffer, buffer_size); |
| 129 | timestamp_add_now(TS_END_ULZ4F); |
| 130 | return out_size; |
| 131 | |
| 132 | case CBFS_COMPRESS_LZMA: |
Kyösti Mälkki | b5211ef | 2018-06-01 07:11:25 +0300 | [diff] [blame] | 133 | /* We assume here romstage and postcar are never compressed. */ |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 134 | if (ENV_BOOTBLOCK || ENV_VERSTAGE) |
| 135 | return 0; |
Julius Werner | cd49cce | 2019-03-05 16:53:33 -0800 | [diff] [blame] | 136 | if (ENV_ROMSTAGE && CONFIG(POSTCAR_STAGE)) |
Kyösti Mälkki | b5211ef | 2018-06-01 07:11:25 +0300 | [diff] [blame] | 137 | return 0; |
Lee Leahy | d950f51 | 2016-07-25 09:53:35 -0700 | [diff] [blame] | 138 | if ((ENV_ROMSTAGE || ENV_POSTCAR) |
Julius Werner | cd49cce | 2019-03-05 16:53:33 -0800 | [diff] [blame] | 139 | && !CONFIG(COMPRESS_RAMSTAGE)) |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 140 | return 0; |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 141 | void *map = rdev_mmap(rdev, offset, in_size); |
| 142 | if (map == NULL) |
| 143 | return 0; |
| 144 | |
| 145 | /* Note: timestamp not useful for memory-mapped media (x86) */ |
| 146 | timestamp_add_now(TS_START_ULZMA); |
| 147 | out_size = ulzman(map, in_size, buffer, buffer_size); |
| 148 | timestamp_add_now(TS_END_ULZMA); |
| 149 | |
| 150 | rdev_munmap(rdev, map); |
| 151 | |
| 152 | return out_size; |
| 153 | |
| 154 | default: |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 155 | return 0; |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 156 | } |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 157 | } |
| 158 | |
Stefan Reinauer | 800379f | 2010-03-01 08:34:19 +0000 | [diff] [blame] | 159 | static inline int tohex4(unsigned int c) |
Patrick Georgi | b203c2f | 2009-08-20 14:48:03 +0000 | [diff] [blame] | 160 | { |
Hung-Te Lin | 6fe0cab | 2013-01-22 18:57:56 +0800 | [diff] [blame] | 161 | return (c <= 9) ? (c + '0') : (c - 10 + 'a'); |
Patrick Georgi | b203c2f | 2009-08-20 14:48:03 +0000 | [diff] [blame] | 162 | } |
| 163 | |
Lee Leahy | b2d834a | 2017-03-08 16:52:22 -0800 | [diff] [blame] | 164 | static void tohex16(unsigned int val, char *dest) |
Patrick Georgi | b203c2f | 2009-08-20 14:48:03 +0000 | [diff] [blame] | 165 | { |
Philipp Deppenwiese | 66f9a09 | 2018-11-08 10:59:40 +0100 | [diff] [blame] | 166 | dest[0] = tohex4(val >> 12); |
| 167 | dest[1] = tohex4((val >> 8) & 0xf); |
| 168 | dest[2] = tohex4((val >> 4) & 0xf); |
Hung-Te Lin | 6fe0cab | 2013-01-22 18:57:56 +0800 | [diff] [blame] | 169 | dest[3] = tohex4(val & 0xf); |
Patrick Georgi | b203c2f | 2009-08-20 14:48:03 +0000 | [diff] [blame] | 170 | } |
| 171 | |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 172 | void *cbfs_boot_map_optionrom(uint16_t vendor, uint16_t device) |
Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 173 | { |
Hung-Te Lin | 6fe0cab | 2013-01-22 18:57:56 +0800 | [diff] [blame] | 174 | char name[17] = "pciXXXX,XXXX.rom"; |
Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 175 | |
Philipp Deppenwiese | 66f9a09 | 2018-11-08 10:59:40 +0100 | [diff] [blame] | 176 | tohex16(vendor, name + 3); |
| 177 | tohex16(device, name + 8); |
Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 178 | |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 179 | return cbfs_boot_map_with_leak(name, CBFS_TYPE_OPTIONROM, NULL); |
Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 180 | } |
| 181 | |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 182 | void *cbfs_boot_load_stage_by_name(const char *name) |
Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 183 | { |
Aaron Durbin | 37a5d15 | 2015-09-17 16:09:30 -0500 | [diff] [blame] | 184 | struct cbfsf fh; |
Aaron Durbin | 7e7a4df | 2015-12-08 14:34:35 -0600 | [diff] [blame] | 185 | struct prog stage = PROG_INIT(PROG_UNKNOWN, name); |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 186 | uint32_t type = CBFS_TYPE_STAGE; |
Aaron Durbin | 3948e53 | 2015-03-20 13:00:20 -0500 | [diff] [blame] | 187 | |
Aaron Durbin | 37a5d15 | 2015-09-17 16:09:30 -0500 | [diff] [blame] | 188 | if (cbfs_boot_locate(&fh, name, &type)) |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 189 | return NULL; |
Aaron Durbin | 3948e53 | 2015-03-20 13:00:20 -0500 | [diff] [blame] | 190 | |
Aaron Durbin | 37a5d15 | 2015-09-17 16:09:30 -0500 | [diff] [blame] | 191 | /* Chain data portion in the prog. */ |
| 192 | cbfs_file_data(prog_rdev(&stage), &fh); |
| 193 | |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 194 | if (cbfs_prog_stage_load(&stage)) |
| 195 | return NULL; |
| 196 | |
| 197 | return prog_entry(&stage); |
Peter Stuge | 483b7bb | 2009-04-14 07:40:01 +0000 | [diff] [blame] | 198 | } |
| 199 | |
T Michael Turney | 809fa7b | 2018-04-12 13:36:40 -0700 | [diff] [blame] | 200 | size_t cbfs_boot_load_file(const char *name, void *buf, size_t buf_size, |
| 201 | uint32_t type) |
Julius Werner | f975e55 | 2016-08-19 15:43:06 -0700 | [diff] [blame] | 202 | { |
| 203 | struct cbfsf fh; |
| 204 | uint32_t compression_algo; |
| 205 | size_t decompressed_size; |
Julius Werner | f975e55 | 2016-08-19 15:43:06 -0700 | [diff] [blame] | 206 | |
| 207 | if (cbfs_boot_locate(&fh, name, &type) < 0) |
| 208 | return 0; |
| 209 | |
| 210 | if (cbfsf_decompression_info(&fh, &compression_algo, |
Philipp Deppenwiese | 66f9a09 | 2018-11-08 10:59:40 +0100 | [diff] [blame] | 211 | &decompressed_size) |
| 212 | < 0 |
| 213 | || decompressed_size > buf_size) |
Julius Werner | f975e55 | 2016-08-19 15:43:06 -0700 | [diff] [blame] | 214 | return 0; |
| 215 | |
| 216 | return cbfs_load_and_decompress(&fh.data, 0, region_device_sz(&fh.data), |
| 217 | buf, buf_size, compression_algo); |
| 218 | } |
| 219 | |
Kyösti Mälkki | 9d6f365 | 2016-06-28 07:38:46 +0300 | [diff] [blame] | 220 | size_t cbfs_prog_stage_section(struct prog *pstage, uintptr_t *base) |
| 221 | { |
| 222 | struct cbfs_stage stage; |
| 223 | const struct region_device *fh = prog_rdev(pstage); |
| 224 | |
| 225 | if (rdev_readat(fh, &stage, 0, sizeof(stage)) != sizeof(stage)) |
| 226 | return 0; |
| 227 | |
| 228 | *base = (uintptr_t)stage.load; |
| 229 | return stage.memlen; |
| 230 | } |
| 231 | |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 232 | int cbfs_prog_stage_load(struct prog *pstage) |
| 233 | { |
| 234 | struct cbfs_stage stage; |
| 235 | uint8_t *load; |
| 236 | void *entry; |
| 237 | size_t fsize; |
| 238 | size_t foffset; |
Aaron Durbin | 37a5d15 | 2015-09-17 16:09:30 -0500 | [diff] [blame] | 239 | const struct region_device *fh = prog_rdev(pstage); |
Hung-Te Lin | 6fe0cab | 2013-01-22 18:57:56 +0800 | [diff] [blame] | 240 | |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 241 | if (rdev_readat(fh, &stage, 0, sizeof(stage)) != sizeof(stage)) |
Julius Werner | b29bd27b | 2015-12-03 11:29:12 -0800 | [diff] [blame] | 242 | return -1; |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 243 | |
| 244 | fsize = region_device_sz(fh); |
| 245 | fsize -= sizeof(stage); |
| 246 | foffset = 0; |
| 247 | foffset += sizeof(stage); |
| 248 | |
| 249 | assert(fsize == stage.len); |
| 250 | |
| 251 | /* Note: cbfs_stage fields are currently in the endianness of the |
| 252 | * running processor. */ |
| 253 | load = (void *)(uintptr_t)stage.load; |
| 254 | entry = (void *)(uintptr_t)stage.entry; |
| 255 | |
Aaron Durbin | ed253c8 | 2015-10-07 17:22:42 -0500 | [diff] [blame] | 256 | /* Hacky way to not load programs over read only media. The stages |
| 257 | * that would hit this path initialize themselves. */ |
Arthur Heymans | 7c24de9 | 2019-10-25 16:53:29 +0200 | [diff] [blame] | 258 | if ((ENV_BOOTBLOCK || ENV_VERSTAGE) && !CONFIG(NO_XIP_EARLY_STAGES) && |
Julius Werner | cd49cce | 2019-03-05 16:53:33 -0800 | [diff] [blame] | 259 | CONFIG(BOOT_DEVICE_MEMORY_MAPPED)) { |
Aaron Durbin | ed253c8 | 2015-10-07 17:22:42 -0500 | [diff] [blame] | 260 | void *mapping = rdev_mmap(fh, foffset, fsize); |
| 261 | rdev_munmap(fh, mapping); |
| 262 | if (mapping == load) |
| 263 | goto out; |
| 264 | } |
| 265 | |
Julius Werner | 09f2921 | 2015-09-29 13:51:35 -0700 | [diff] [blame] | 266 | fsize = cbfs_load_and_decompress(fh, foffset, fsize, load, |
| 267 | stage.memlen, stage.compression); |
| 268 | if (!fsize) |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 269 | return -1; |
| 270 | |
| 271 | /* Clear area not covered by file. */ |
| 272 | memset(&load[fsize], 0, stage.memlen - fsize); |
| 273 | |
Aaron Durbin | 096f457 | 2016-03-31 13:49:00 -0500 | [diff] [blame] | 274 | prog_segment_loaded((uintptr_t)load, stage.memlen, SEG_FINAL); |
Aaron Durbin | ed253c8 | 2015-10-07 17:22:42 -0500 | [diff] [blame] | 275 | |
| 276 | out: |
Aaron Durbin | 899d13d | 2015-05-15 23:39:23 -0500 | [diff] [blame] | 277 | prog_set_area(pstage, load, stage.memlen); |
| 278 | prog_set_entry(pstage, entry, NULL); |
| 279 | |
| 280 | return 0; |
Hung-Te Lin | 6fe0cab | 2013-01-22 18:57:56 +0800 | [diff] [blame] | 281 | } |
Aaron Durbin | 6d720f3 | 2015-12-08 17:00:23 -0600 | [diff] [blame] | 282 | |
Aaron Durbin | fe338e2 | 2019-11-18 12:35:21 -0700 | [diff] [blame] | 283 | int cbfs_boot_region_device(struct region_device *rdev) |
Aaron Durbin | 6d720f3 | 2015-12-08 17:00:23 -0600 | [diff] [blame] | 284 | { |
Aaron Durbin | 6d720f3 | 2015-12-08 17:00:23 -0600 | [diff] [blame] | 285 | boot_device_init(); |
Julius Werner | 815611e | 2019-12-05 22:29:07 -0800 | [diff] [blame] | 286 | return vboot_locate_cbfs(rdev) && |
| 287 | fmap_locate_area_as_rdev("COREBOOT", rdev); |
Aaron Durbin | 6d720f3 | 2015-12-08 17:00:23 -0600 | [diff] [blame] | 288 | } |