blob: 9a3233f11c15c4fbf681cfdb18687b5ef794ee5f [file] [log] [blame]
Patrick Rudolph1ab8ad62021-04-21 10:02:55 +02001/* SPDX-License-Identifier: GPL-2.0-only */
2
3#include <stdint.h>
4#include <stdlib.h>
5#include <string.h>
6#include <console/console.h>
7
8#include <vendorcode/intel/edk2/UDK2017/MdePkg/Include/Uefi/UefiBaseType.h>
9#include <vendorcode/intel/edk2/UDK2017/MdePkg/Include/Uefi/UefiMultiPhase.h>
10#include <vendorcode/intel/edk2/UDK2017/MdePkg/Include/Pi/PiFirmwareVolume.h>
11#include <vendorcode/intel/edk2/UDK2017/MdeModulePkg/Include/Guid/VariableFormat.h>
12#include <lib.h>
13
14#include "efivars.h"
15
16#define PREFIX "EFIVARS: "
17
18static const EFI_GUID EfiVariableGuid = {
19 0xddcf3616, 0x3275, 0x4164, { 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d } };
20static const EFI_GUID EfiAuthenticatedVariableGuid = {
21 0xaaf32c78, 0x947b, 0x439a, { 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92 } };
22static const EFI_GUID EfiSystemNvDataFvGuid = {
23 0xfff12b8d, 0x7696, 0x4c8b, { 0xa9, 0x85, 0x27, 0x47, 0x07, 0x5b, 0x4f, 0x50 } };
24
25static void print_guid(int log_level, const EFI_GUID *g)
26{
27 printk(log_level, "GUID: %08x-%04x-%04x-%02x%02x%02x%02x%02x%02x%02x%02x",
28 g->Data1, g->Data2, g->Data3, g->Data4[0], g->Data4[1], g->Data4[2],
29 g->Data4[3], g->Data4[4], g->Data4[5], g->Data4[6], g->Data4[7]);
30
31}
32
33static bool compare_guid(const EFI_GUID *a, const EFI_GUID *b)
34{
35 return memcmp(a, b, sizeof(*a)) == 0;
36}
37
38/* Reads the CHAR16 string from rdev at offset and prints it */
39static enum cb_err rdev_print_wchar(int log_level, struct region_device *rdev, size_t offset)
40{
41 CHAR16 c;
42 int i = 0;
43
44 /* Convert ASCII to UTF-16 */
45 do {
46 if (rdev_readat(rdev, &c, offset + i * sizeof(c), sizeof(c)) != sizeof(c))
47 return CB_EFI_ACCESS_ERROR;
48 if (c < 0x80)
49 printk(log_level, "%c", (char)c);
50 else
51 printk(log_level, "\\u%04x", c);
52
53 i++;
54 } while (c);
55 return CB_SUCCESS;
56}
57
58/* Convert an ASCII string to UTF-16 and write it to the rdev starting at offset. */
59static enum cb_err rdev_write_wchar(struct region_device *rdev, size_t offset, const char *msg)
60{
61 size_t i;
62 CHAR16 c;
63
64 /* Convert ASCII to UTF-16 */
65 for (i = 0; i < strlen(msg) + 1; i++) {
66 c = msg[i];
67
68 if (rdev_writeat(rdev, &c, offset + i * sizeof(c), sizeof(c)) != sizeof(c))
69 return CB_EFI_ACCESS_ERROR;
70 }
71 return CB_SUCCESS;
72}
73
74/* Read an UTF-16 string from rdev at offset and compare it to ASCII string */
75static int rdev_strcmp_wchar_ascii(struct region_device *rdev, size_t offset, const char *msg)
76{
77 size_t i;
78 CHAR16 c;
79 int r;
80
81 i = 0;
82 /* Compare UTF-16 and ASCII */
83 while (1) {
84 if (rdev_readat(rdev, &c, offset + i * sizeof(c), sizeof(c)) != sizeof(c))
85 return CB_EFI_ACCESS_ERROR;
86 if ((r = (c - msg[i])) != 0 || !c)
87 break;
88
89 i++;
90 }
91 return r;
92}
93
94/* Compare an rdev region and a data buffer */
95static int rdev_memcmp(struct region_device *rdev, size_t offset, uint8_t *data, size_t size)
96{
97 uint8_t buf[16];
98 size_t i;
99 int r;
100
101 i = 0;
102 while (size >= sizeof(buf)) {
103 if (rdev_readat(rdev, buf, offset + i, sizeof(buf)) != sizeof(buf))
104 return CB_EFI_ACCESS_ERROR;
105 r = memcmp(buf, data + i, sizeof(buf));
106 if (r != 0)
107 return r;
108 i += sizeof(buf);
109 size -= sizeof(buf);
110 }
111 while (size > 0) {
112 if (rdev_readat(rdev, buf, offset + i, 1) != 1)
113 return CB_EFI_ACCESS_ERROR;
114 r = buf[0] - data[i];
115 if (r != 0)
116 return r;
117 i++;
118 size--;
119 }
120 return 0;
121}
122
123
124static enum cb_err validate_fv_header(const struct region_device *rdev,
125 EFI_FIRMWARE_VOLUME_HEADER *fw_vol_hdr)
126{
127 uint16_t checksum, data;
128 size_t i;
129
130 if (rdev_readat(rdev, fw_vol_hdr, 0, sizeof(*fw_vol_hdr)) != sizeof(*fw_vol_hdr))
131 return CB_EFI_ACCESS_ERROR;
132
133 /*
134 * Verify the header revision, header signature, length
135 * Length of FvBlock cannot be 2**64-1
136 * HeaderLength cannot be an odd number
137 */
138 if ((fw_vol_hdr->Revision != EFI_FVH_REVISION)
139 || (fw_vol_hdr->Signature != EFI_FVH_SIGNATURE)
140 || (fw_vol_hdr->FvLength > region_device_sz(rdev))
141 || (fw_vol_hdr->HeaderLength > region_device_sz(rdev))
142 || (fw_vol_hdr->HeaderLength & 1)) {
143 printk(BIOS_WARNING, PREFIX "No Firmware Volume header present\n");
144 return CB_EFI_FVH_INVALID;
145 }
146
147 /* Check the Firmware Volume Guid */
148 if (!compare_guid(&fw_vol_hdr->FileSystemGuid, &EfiSystemNvDataFvGuid)) {
149 printk(BIOS_WARNING, PREFIX "Firmware Volume Guid non-compatible\n");
150 return CB_EFI_FVH_INVALID;
151 }
152
153 /* Verify the header checksum */
154 checksum = 0;
155 for (i = 0; i < fw_vol_hdr->HeaderLength; i += 2) {
156 if (rdev_readat(rdev, &data, i, sizeof(data)) != sizeof(data))
157 return CB_EFI_ACCESS_ERROR;
158 checksum = (uint16_t)(checksum + data); /* intentionally overflows */
159 }
160 if (checksum != 0) {
161 printk(BIOS_WARNING, PREFIX "FV checksum is invalid: 0x%X\n", checksum);
162 return CB_EFI_CHECKSUM_INVALID;
163 }
164
165 printk(BIOS_SPEW, PREFIX "UEFI FV with size %lld found\n", fw_vol_hdr->FvLength);
166
167 return CB_SUCCESS;
168
169}
170
171static enum cb_err
172validate_variable_store_header(const EFI_FIRMWARE_VOLUME_HEADER *fv_hdr,
173 struct region_device *rdev,
174 bool *auth_format)
175{
176 VARIABLE_STORE_HEADER hdr;
177 size_t length;
178
179 if (rdev_readat(rdev, &hdr, fv_hdr->HeaderLength, sizeof(hdr)) != sizeof(hdr))
180 return CB_EFI_ACCESS_ERROR;
181
182 /* Check the Variable Store Guid */
183 if (!compare_guid(&hdr.Signature, &EfiVariableGuid) &&
184 !compare_guid(&hdr.Signature, &EfiAuthenticatedVariableGuid)) {
185 printk(BIOS_WARNING, PREFIX "Variable Store Guid non-compatible\n");
186 return CB_EFI_VS_CORRUPTED_INVALID;
187 }
188
189 *auth_format = compare_guid(&hdr.Signature, &EfiAuthenticatedVariableGuid);
190
191 length = region_device_sz(rdev) - fv_hdr->HeaderLength;
192 if (hdr.Size > length) {
193 printk(BIOS_WARNING, PREFIX "Variable Store Length does not match\n");
194 return CB_EFI_VS_CORRUPTED_INVALID;
195 }
196
197 if (hdr.Format != VARIABLE_STORE_FORMATTED)
198 return CB_EFI_VS_NOT_FORMATTED_INVALID;
199
200 if (hdr.State != VARIABLE_STORE_HEALTHY)
201 return CB_EFI_VS_CORRUPTED_INVALID;
202
203 if (rdev_chain(rdev, rdev, fv_hdr->HeaderLength + sizeof(hdr), hdr.Size)) {
204 printk(BIOS_WARNING, PREFIX "rdev_chain failed\n");
205 return CB_EFI_ACCESS_ERROR;
206 }
207
208 printk(BIOS_SPEW, PREFIX "UEFI variable store with size %zu found\n",
209 region_device_sz(rdev));
210
211 return CB_SUCCESS;
212}
213
214struct efi_find_args {
215 const EFI_GUID *guid;
216 const char *name;
217 uint32_t *size;
218 void *data;
219};
220
221static bool match(struct region_device *rdev, VARIABLE_HEADER *hdr, size_t hdr_size,
222 const char *name, const EFI_GUID *guid)
223{
224 /* Only search for valid or in transition to be deleted variables */
225 if ((hdr->State != VAR_ADDED) &&
226 (hdr->State != (VAR_IN_DELETED_TRANSITION & VAR_ADDED)))
227 return false;
228
229 if ((!compare_guid(&hdr->VendorGuid, guid)) ||
230 !hdr->NameSize ||
231 !hdr->DataSize)
232 return false;
233
234 if (rdev_strcmp_wchar_ascii(rdev, hdr_size, name) != 0)
235 return false;
236
237 return true;
238}
239
240static
241enum cb_err find_and_copy(struct region_device *rdev, VARIABLE_HEADER *hdr, size_t hdr_size,
242 void *arg, bool *stop)
243{
244 struct efi_find_args *fa = (struct efi_find_args *)arg;
245
246 if (!match(rdev, hdr, hdr_size, fa->name, fa->guid))
247 return CB_SUCCESS;
248
249 *stop = true;
250 if (*(fa->size) < hdr->DataSize)
251 return CB_EFI_BUFFER_TOO_SMALL;
252
253 if (rdev_readat(rdev, fa->data, hdr_size + hdr->NameSize, hdr->DataSize) !=
254 hdr->DataSize)
255 return CB_EFI_ACCESS_ERROR;
256
257 *(fa->size) = hdr->DataSize;
258 return CB_SUCCESS;
259}
260
261struct efi_find_compare_args {
262 const EFI_GUID *guid;
263 const char *name;
264 uint32_t size;
265 void *data;
266 bool match;
267};
268
269static
270enum cb_err find_and_compare(struct region_device *rdev, VARIABLE_HEADER *hdr, size_t hdr_size,
271 void *arg, bool *stop)
272{
273 struct efi_find_compare_args *fa = (struct efi_find_compare_args *)arg;
274
275 if (!match(rdev, hdr, hdr_size, fa->name, fa->guid))
276 return CB_SUCCESS;
277
278 *stop = true;
279 if (fa->size != hdr->DataSize) {
280 fa->match = false;
281 return CB_SUCCESS;
282 }
283
284 fa->match = rdev_memcmp(rdev, hdr_size + hdr->NameSize, fa->data, hdr->DataSize) == 0;
285
286 return CB_SUCCESS;
287}
288
289static enum cb_err noop(struct region_device *rdev, VARIABLE_HEADER *hdr, size_t hdr_size,
290 void *arg, bool *stop)
291{
292 /* Does nothing. */
293 return CB_SUCCESS;
294}
295
296static enum cb_err print_var(struct region_device *rdev, VARIABLE_HEADER *hdr, size_t hdr_size,
297 void *arg, bool *stop)
298{
299 uint8_t buf[16];
300 size_t len, i;
301
302 printk(BIOS_DEBUG, "%08zx: Var ", region_device_offset(rdev));
303 print_guid(BIOS_DEBUG, &hdr->VendorGuid);
304
305 printk(BIOS_DEBUG, "-");
306
307 rdev_print_wchar(BIOS_DEBUG, rdev, hdr_size);
308
309 printk(BIOS_DEBUG, ", State %02x, Size %02x\n", hdr->State, hdr->DataSize);
310
311 if (hdr->DataSize && hdr->NameSize) {
312 len = sizeof(buf) < hdr->DataSize ? sizeof(buf) : hdr->DataSize;
313 if (rdev_readat(rdev, buf, hdr_size + hdr->NameSize, len) != len)
314 return CB_EFI_ACCESS_ERROR;
315 printk(BIOS_DEBUG, " Data: ");
316
317 for (i = 0; i < len; i++)
318 printk(BIOS_DEBUG, "0x%02x ", buf[i]);
319
320 if (hdr->DataSize > len)
321 printk(BIOS_DEBUG, "...");
322
323 printk(BIOS_DEBUG, "\n");
324 }
325
326 return CB_SUCCESS;
327}
328
329static enum cb_err walk_variables(struct region_device *rdev,
330 bool auth_format,
331 enum cb_err (*walker)(struct region_device *rdev,
332 VARIABLE_HEADER *hdr,
333 size_t hdr_size,
334 void *arg,
335 bool *stop),
336 void *walker_arg)
337{
338 AUTHENTICATED_VARIABLE_HEADER auth_hdr;
339 size_t header_size, var_size;
340 VARIABLE_HEADER hdr;
341 bool stop;
342 enum cb_err ret;
343
344 if (auth_format)
345 header_size = sizeof(AUTHENTICATED_VARIABLE_HEADER);
346 else
347 header_size = sizeof(VARIABLE_HEADER);
348
349 do {
350 if (auth_format) {
351 if (rdev_readat(rdev, &auth_hdr, 0, sizeof(auth_hdr))
352 != sizeof(auth_hdr))
353 return CB_EFI_ACCESS_ERROR;
354 hdr.Reserved = auth_hdr.Reserved;
355 hdr.StartId = auth_hdr.StartId;
356 hdr.State = auth_hdr.State;
357 hdr.Attributes = auth_hdr.Attributes;
358 hdr.NameSize = auth_hdr.NameSize;
359 hdr.DataSize = auth_hdr.DataSize;
360 memcpy(&hdr.VendorGuid, &auth_hdr.VendorGuid, sizeof(hdr.VendorGuid));
361 } else if (rdev_readat(rdev, &hdr, 0, sizeof(hdr)) != sizeof(hdr)) {
362 return CB_EFI_ACCESS_ERROR;
363 }
364 if (hdr.StartId != VARIABLE_DATA)
365 break;
366
367 if (hdr.State == UINT8_MAX ||
368 hdr.DataSize == UINT32_MAX ||
369 hdr.NameSize == UINT32_MAX ||
370 hdr.Attributes == UINT32_MAX) {
371 hdr.NameSize = 0;
372 hdr.DataSize = 0;
373 }
374
375 printk(BIOS_SPEW, "Found variable with state %02x and ", hdr.State);
376 print_guid(BIOS_SPEW, &hdr.VendorGuid);
377 printk(BIOS_SPEW, "\n");
378
379 stop = false;
380
381 ret = walker(rdev, &hdr, header_size, walker_arg, &stop);
382
383 if (ret != CB_SUCCESS || stop)
384 return ret;
385
386 var_size = ALIGN_UP(header_size + hdr.NameSize + hdr.DataSize,
387 HEADER_ALIGNMENT);
388 } while (!rdev_chain(rdev, rdev, var_size, region_device_sz(rdev) - var_size));
389
390 return CB_EFI_OPTION_NOT_FOUND;
391}
392
393static enum cb_err efi_fv_init(struct region_device *rdev, bool *auth_format)
394{
395 EFI_FIRMWARE_VOLUME_HEADER fv_hdr;
396 enum cb_err ret;
397
398 ret = validate_fv_header(rdev, &fv_hdr);
399 if (ret != CB_SUCCESS) {
400 printk(BIOS_WARNING, PREFIX "Failed to validate firmware header\n");
401
402 return ret;
403 }
404 ret = validate_variable_store_header(&fv_hdr, rdev, auth_format);
405 if (ret != CB_SUCCESS)
406 printk(BIOS_WARNING, PREFIX "Failed to validate variable store header\n");
407
408 return ret;
409}
410
411enum cb_err efi_fv_print_options(struct region_device *rdev)
412{
413 enum cb_err ret;
414 bool auth_format;
415
416 ret = efi_fv_init(rdev, &auth_format);
417 if (ret != CB_SUCCESS)
418 return ret;
419
420 return walk_variables(rdev, auth_format, print_var, NULL);
421}
422
423/*
424 * efi_fv_get_option
425 * - writes up to *size bytes into a buffer pointed to by *dest
426 * - rdev is the spi flash region to operate on
427 * - the FVH and variable store header must have been initialized by a third party
428 */
429enum cb_err efi_fv_get_option(struct region_device *rdev,
430 const EFI_GUID *guid,
431 const char *name,
432 void *dest,
433 uint32_t *size)
434{
435 struct efi_find_args args;
436 bool auth_format;
437 enum cb_err ret;
438
439 ret = efi_fv_init(rdev, &auth_format);
440 if (ret != CB_SUCCESS)
441 return ret;
442
443 args.guid = guid;
444 args.name = name;
445 args.size = size;
446 args.data = dest;
447
448 return walk_variables(rdev, auth_format, find_and_copy, &args);
449}
450
451static enum cb_err write_auth_hdr(struct region_device *rdev, const EFI_GUID *guid,
452 const char *name, void *data, size_t size)
453{
454 AUTHENTICATED_VARIABLE_HEADER auth_hdr;
455 size_t name_size, var_size;
456 enum cb_err ret;
457
458 name_size = (strlen(name) + 1) * sizeof(CHAR16);
459 var_size = name_size + size + sizeof(auth_hdr);
460
461 if (var_size > region_device_sz(rdev))
462 return CB_EFI_STORE_FULL;
463
464 /* Sanity check. flash must be blank */
465 if (rdev_readat(rdev, &auth_hdr, 0, sizeof(auth_hdr)) != sizeof(auth_hdr))
466 return CB_EFI_ACCESS_ERROR;
467
468 if (auth_hdr.StartId != UINT16_MAX ||
469 auth_hdr.State != UINT8_MAX ||
470 auth_hdr.DataSize != UINT32_MAX ||
471 auth_hdr.NameSize != UINT32_MAX ||
472 auth_hdr.Attributes != UINT32_MAX) {
473 return CB_EFI_ACCESS_ERROR;
474 }
475
476 memset(&auth_hdr, 0xff, sizeof(auth_hdr));
477
478 auth_hdr.StartId = VARIABLE_DATA;
479 auth_hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|
480 EFI_VARIABLE_BOOTSERVICE_ACCESS|
481 EFI_VARIABLE_RUNTIME_ACCESS;
482 auth_hdr.NameSize = name_size;
483 auth_hdr.DataSize = size;
484 memcpy(&auth_hdr.VendorGuid, guid, sizeof(EFI_GUID));
485
486 /* Write header with no State */
487 if (rdev_writeat(rdev, &auth_hdr, 0, sizeof(auth_hdr)) != sizeof(auth_hdr))
488 return CB_EFI_ACCESS_ERROR;
489
490 /* Set header State to valid header */
491 auth_hdr.State = VAR_HEADER_VALID_ONLY;
492 if (rdev_writeat(rdev, &auth_hdr.State, offsetof(AUTHENTICATED_VARIABLE_HEADER, State),
493 sizeof(auth_hdr.State)) != sizeof(auth_hdr.State))
494 return CB_EFI_ACCESS_ERROR;
495
496 /* Write the name */
497 ret = rdev_write_wchar(rdev, sizeof(auth_hdr), name);
498 if (ret != CB_SUCCESS)
499 return ret;
500
501 /* Write the data */
502 if (rdev_writeat(rdev, data, sizeof(auth_hdr) + name_size, size) != size)
503 return CB_EFI_ACCESS_ERROR;
504
505 /* Set header State to valid data */
506 auth_hdr.State = VAR_ADDED;
507 if (rdev_writeat(rdev, &auth_hdr.State, offsetof(AUTHENTICATED_VARIABLE_HEADER, State),
508 sizeof(auth_hdr.State)) != sizeof(auth_hdr.State))
509 return CB_EFI_ACCESS_ERROR;
510
511 return CB_SUCCESS;
512}
513
514static enum cb_err write_hdr(struct region_device *rdev, const EFI_GUID *guid,
515 const char *name,
516 void *data,
517 size_t size)
518{
519 VARIABLE_HEADER hdr;
520 size_t name_size, var_size;
521 enum cb_err ret;
522
523 name_size = (strlen(name) + 1) * sizeof(CHAR16);
524 var_size = name_size + size + sizeof(hdr);
525 if (var_size > region_device_sz(rdev))
526 return CB_EFI_STORE_FULL;
527
528 /* Sanity check. flash must be blank */
529 if (rdev_readat(rdev, &hdr, 0, sizeof(hdr)) != sizeof(hdr))
530 return CB_EFI_ACCESS_ERROR;
531
532 if (hdr.StartId != UINT16_MAX ||
533 hdr.State != UINT8_MAX ||
534 hdr.DataSize != UINT32_MAX ||
535 hdr.NameSize != UINT32_MAX ||
536 hdr.Attributes != UINT32_MAX) {
537 return CB_EFI_ACCESS_ERROR;
538 }
539
540 memset(&hdr, 0xff, sizeof(hdr));
541
542 hdr.StartId = VARIABLE_DATA;
543 hdr.Attributes = EFI_VARIABLE_NON_VOLATILE|
544 EFI_VARIABLE_BOOTSERVICE_ACCESS|
545 EFI_VARIABLE_RUNTIME_ACCESS;
546 hdr.NameSize = name_size;
547 hdr.DataSize = size;
548 memcpy(&hdr.VendorGuid, guid, sizeof(EFI_GUID));
549
550 /* Write header with no State */
551 if (rdev_writeat(rdev, &hdr, 0, sizeof(hdr)) != sizeof(hdr))
552 return CB_EFI_ACCESS_ERROR;
553
554 /* Set header State to valid header */
555 hdr.State = VAR_HEADER_VALID_ONLY;
556 if (rdev_writeat(rdev, &hdr.State, offsetof(VARIABLE_HEADER, State),
557 sizeof(hdr.State)) != sizeof(hdr.State))
558 return CB_EFI_ACCESS_ERROR;
559
560 /* Write the name */
561 ret = rdev_write_wchar(rdev, sizeof(hdr), name);
562 if (ret != CB_SUCCESS)
563 return ret;
564
565 /* Write the data */
566 if (rdev_writeat(rdev, data, sizeof(hdr) + name_size, size) != size)
567 return CB_EFI_ACCESS_ERROR;
568
569 /* Set header State to valid data */
570 hdr.State = VAR_ADDED;
571 if (rdev_writeat(rdev, &hdr.State, offsetof(VARIABLE_HEADER, State),
572 sizeof(hdr.State)) != sizeof(hdr.State))
573 return CB_EFI_ACCESS_ERROR;
574
575 return CB_SUCCESS;
576}
577
578/*
579 * efi_fv_set_option
580 * - writes size bytes read from the buffer pointed to by *data
581 * - rdev is the spi flash region to operate on
582 * - the FVH and variable store header must have been initialized by a third party
583 */
584enum cb_err efi_fv_set_option(struct region_device *rdev,
585 const EFI_GUID *guid,
586 const char *name,
587 void *data,
588 uint32_t size)
589{
590 struct region_device rdev_old;
591 struct efi_find_compare_args args;
592 bool found_existing;
593 VARIABLE_HEADER hdr;
594 bool auth_format;
595 enum cb_err ret;
596
597 ret = efi_fv_init(rdev, &auth_format);
598 if (ret != CB_SUCCESS)
599 return ret;
600
601 /* Find existing variable */
602 args.guid = guid;
603 args.name = name;
604 args.size = size;
605 args.match = false;
606 args.data = data;
607
608 ret = walk_variables(rdev, auth_format, find_and_compare, &args);
609 found_existing = ret == CB_SUCCESS;
610
611 if (found_existing) {
612 printk(BIOS_ERR, "found existing variable %s, match =%d\n", name, args.match);
613
614 if (args.match)
615 return CB_SUCCESS;
616
617 rdev_old = *rdev;
618
619 /* Mark as to be deleted */
620 hdr.State = VAR_IN_DELETED_TRANSITION;
621 if (rdev_writeat(rdev, &hdr.State, offsetof(VARIABLE_HEADER, State),
622 sizeof(hdr.State)) != sizeof(hdr.State))
623 return CB_EFI_ACCESS_ERROR;
624 }
625
626 /* Walk to end of variable store */
627 ret = walk_variables(rdev, auth_format, noop, NULL);
628 if (ret != CB_EFI_OPTION_NOT_FOUND)
629 return ret;
630
631 /* Now append new variable:
632 * 1. Write the header without State field.
633 * 2. Write the State field and set it to HEADER_VALID.
634 * 3. Write data
635 * 4. Write the State field and set it to VAR_ADDED
636 */
637
638 if (auth_format)
639 ret = write_auth_hdr(rdev, guid, name, data, size);
640 else
641 ret = write_hdr(rdev, guid, name, data, size);
642 if (ret != CB_SUCCESS)
643 return ret;
644
645 if (found_existing) {
646 /* Mark old variable as deleted */
647 hdr.State = VAR_DELETED;
648 if (rdev_writeat(&rdev_old, &hdr.State, offsetof(VARIABLE_HEADER, State),
649 sizeof(hdr.State)) != sizeof(hdr.State))
650 return CB_EFI_ACCESS_ERROR;
651 }
652
653 return CB_SUCCESS;
654}