commit cea31ea5eb9b634019afb3d9531aeef38dd226ba
author Stefan Tauner <stefan.tauner@gmx.at> Sat Aug 11 18:45:28 2018 +0200
committer Patrick Georgi <pgeorgi@google.com> Tue Aug 14 16:05:17 2018 +0000
tree 0922f6194dadca2329e5307a7238d2589c753355
parent 75b1f768d8eef24769ae9b559f66b3561d24b010

sb/intel/i82801[ij]x: use (more) RCBA register names instead of magic numbers

Change-Id: I909d7dd4968aa2f76df00c03e603e8e82a4824c0
Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-on: https://review.coreboot.org/28052
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>

src/southbridge/intel/i82801ix/i82801ix.c

diff --git a/src/southbridge/intel/i82801ix/i82801ix.c b/src/southbridge/intel/i82801ix/i82801ix.c
index 7247132..7e91ba1 100644
--- a/src/southbridge/intel/i82801ix/i82801ix.c
+++ b/src/southbridge/intel/i82801ix/i82801ix.c
@@ -38,15 +38,16 @@
 static void i82801ix_early_settings(const config_t *const info)
 {
 	/* Program FERR# as processor break event indicator. */
-	RCBA32(0x3410) |= (1 << 6);
-	/* BIOS must program... */
-	RCBA32(0x3430) = (RCBA32(0x3430) & ~(0x3 <<  0)) | (0x2 <<  0);
-	RCBA32(0x3418) |= (1 << 0);
-	RCBA32(0x350c) = (RCBA32(0x350c) & ~(0x3 << 26)) | (0x2 << 26);
-	RCBA32(0x2034) = (RCBA32(0x2034) & ~(0xf << 16)) | (0x5 << 16);
-	RCBA32(0x0f20) = (RCBA32(0x0f20) & ~(0xf << 16)) | (0x5 << 16);
-	RCBA32(0x1d40) |= (1 << 0);
-	RCBA32(0x352c) |= (3 << 16);
+	RCBA32(GCS) |= (1 << 6);
+	/* BIOS must program...
+	 * NB: other CIRs are handled in i82801ix_dmi_setup(). */
+	RCBA32(RCBA_CIR8) = (RCBA32(RCBA_CIR8) & ~(0x3 <<  0)) | (0x2 <<  0);
+	RCBA32(RCBA_FD) |= (1 << 0);
+	RCBA32(RCBA_CIR9) = (RCBA32(RCBA_CIR9) & ~(0x3 << 26)) | (0x2 << 26);
+	RCBA32(RCBA_CIR7) = (RCBA32(RCBA_CIR7) & ~(0xf << 16)) | (0x5 << 16);
+	RCBA32(RCBA_CIR13) = (RCBA32(RCBA_CIR13) & ~(0xf << 16)) | (0x5 << 16);
+	RCBA32(RCBA_CIR5) |= (1 << 0);
+	RCBA32(RCBA_CIR10) |= (3 << 16);
 }
 
 static void i82801ix_pcie_init(const config_t *const info)