mb/google/volteer: Use device aliases
Use the device aliases provided by tigerlake chipset.cb instead of
the raw pci device+function. Take advantage of the default states
in chipset.cb and only list the devices that are enabled for all
volteer variants.
Change-Id: I5620004afd7fa4d50389f32dd79148960a2b2662
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44039
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
index e16012d..5f0f290 100644
--- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
@@ -19,11 +19,12 @@
[PchSerialIoIndexI2C5] = PchSerialIoPci,
}"
device domain 0 on
- device pci 07.0 off end # TBT_PCIe0 0x9A23
- device pci 07.1 off end # TBT_PCIe1 0x9A25
- device pci 07.2 off end # TBT_PCIe2 0x9A27
- device pci 07.3 off end # TBT_PCIe3 0x9A29
- device pci 15.0 on
+ # Baseboard has these on, so they must be disabled here.
+ device ref tbt_pcie_rp0 off end
+ device ref tbt_pcie_rp1 off end
+ device ref tbt_dma0 off end
+
+ device ref i2c0 on
chip drivers/i2c/generic
register "hid" = ""10EC5682""
register "name" = ""RT58""
@@ -36,8 +37,8 @@
register "property_list[0].integer" = "1"
device i2c 1a on end
end
- end # I2C0
- device pci 15.1 on
+ end
+ device ref i2c1 on
chip drivers/i2c/hid
register "generic.hid" = ""GDIX0000""
register "generic.desc" = ""Goodix Touchscreen""
@@ -59,9 +60,8 @@
register "hid_desc_reg_offset" = "0x01"
device i2c 14 on end
end
- end # I2C1
- device pci 15.2 off end # I2C2 0xA0EA
- device pci 19.1 on
+ end
+ device ref i2c5 on
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
register "desc" = ""ELAN Touchpad""
@@ -70,6 +70,6 @@
register "probed" = "1"
device i2c 15 on end
end
- end # I2C5 0xA0C6
+ end
end
end