| commit | 8461cec76c7323103cb1f61bae077d9a2b1d252e | [log] [tgz] |
|---|---|---|
| author | Arthur Heymans <arthur@aheymans.xyz> | Thu Nov 19 14:22:24 2020 +0100 |
| committer | Patrick Georgi <pgeorgi@google.com> | Sun Nov 22 22:25:23 2020 +0000 |
| tree | 8d0da4fe8dc1a4ef2fef9de2b62f0f437dce3563 | |
| parent | f2baae3735b86ff14a13728a845bd484aa4caf70 [diff] [blame] |
soc/intel/block/pmclib.c: Properly guard apm_control() This function is only properly implemented with SMM support. Change-Id: I9e0fc7433a9226825f5ae4903c0ff2e0162d86ac Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47757 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c index 02ca6de..09af749 100644 --- a/src/soc/intel/common/block/pmc/pmclib.c +++ b/src/soc/intel/common/block/pmc/pmclib.c
@@ -713,7 +713,7 @@ void pmc_set_acpi_mode(void) { - if (!acpi_is_wakeup_s3()) { + if (!CONFIG(NO_SMM) && !acpi_is_wakeup_s3()) { apm_control(APM_CNT_ACPI_DISABLE); } }