Gitiles
Code Review Sign In
review.coreboot.org / flashrom / 6a5472cee9805990a269cfe1c9d52bd52edf1006
commit6a5472cee9805990a269cfe1c9d52bd52edf1006[log] [tgz]
authorEdward O'Callaghan <quasisec@google.com>Wed May 06 16:16:47 2020 +1000
committerEdward O'Callaghan <quasisec@chromium.org>Wed May 06 12:21:33 2020 +0000
tree36c5d6333a8a6ee478cc6893bfd1565bb7d7c424
parent76c582d9727c9fe5c61aef74548b812fb299f9b5 [diff]
realtek_mst_i2c_spi.c: Fix _spi_write256() as documented

Turns out broken erasures highlighted some of the issues
in the write256 implementation. After a fair amount of
time deciphering scarce documentation details a correct
implementation was finally derived.

V.2: Rename 'start_program() -> execute_write()' to
  clarify the intention and not to overload the term
  'program' since the MST actually runs a 'program'
  itself.

BUG=b:152558985,b:148745673
BRANCH=none
TEST=flashrom -p realtek_mst_i2c_spi:bus=8 -E &&
  flashrom -p realtek_mst_i2c_spi:bus=8 -w foo &&
  flashrom -p realtek_mst_i2c_spi:bus=8 -r foo &&
  hexdump -C foo

Change-Id: If61ff95697f886d3301a907b76283322c39ef5c7
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/41080
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sam McNally <sammc@google.com>
1 file changed
tree: 36c5d6333a8a6ee478cc6893bfd1565bb7d7c424
  1. .gitattributes
  2. .gitignore
  3. 82802ab.c
  4. COPYING
  5. Documentation/
  6. Doxyfile
  7. Makefile
  8. README
  9. amd_imc.c
  10. archtest.c
  11. at45db.c
  12. atahpt.c
  13. atapromise.c
  14. atavia.c
  15. bitbang_spi.c
  16. board_enable.c
  17. buspirate_spi.c
  18. cbtable.c
  19. ch341a_spi.c
  20. chipdrivers.h
  21. chipset_enable.c
  22. cli_classic.c
  23. cli_common.c
  24. cli_output.c
  25. coreboot_tables.h
  26. custom_baud.c
  27. custom_baud.h
  28. dediprog.c
  29. developerbox_spi.c
  30. digilent_spi.c
  31. dmi.c
  32. drkaiser.c
  33. dummyflasher.c
  34. edi.c
  35. edi.h
  36. en29lv640b.c
  37. endiantest.c
  38. ene.h
  39. flash.h
  40. flashchips.c
  41. flashchips.h
  42. flashrom.8.tmpl
  43. flashrom.c
  44. fmap.c
  45. fmap.h
  46. ft2232_spi.c
  47. gfxnvidia.c
  48. helpers.c
  49. hwaccess.c
  50. hwaccess.h
  51. i2c_helper.h
  52. i2c_helper_linux.c
  53. ich_descriptors.c
  54. ich_descriptors.h
  55. ichspi.c
  56. internal.c
  57. it8212.c
  58. it85spi.c
  59. it87spi.c
  60. jedec.c
  61. jlink_spi.c
  62. layout.c
  63. layout.h
  64. libflashrom.c
  65. libflashrom.h
  66. libflashrom.map
  67. linux_mtd.c
  68. linux_spi.c
  69. lspcon_i2c_spi.c
  70. mcp6x_spi.c
  71. meson.build
  72. meson_options.txt
  73. mstarddc_spi.c
  74. ni845x_spi.c
  75. nic3com.c
  76. nicintel.c
  77. nicintel_eeprom.c
  78. nicintel_spi.c
  79. nicnatsemi.c
  80. nicrealtek.c
  81. ogp_spi.c
  82. opaque.c
  83. os.h
  84. pcidev.c
  85. physmap.c
  86. pickit2_spi.c
  87. platform.h
  88. pony_spi.c
  89. print.c
  90. print_wiki.c
  91. processor_enable.c
  92. programmer.c
  93. programmer.h
  94. raiden_debug_spi.c
  95. rayer_spi.c
  96. realtek_mst_i2c_spi.c
  97. satamv.c
  98. satasii.c
  99. sb600spi.c
  100. serial.c
  101. serprog.c
  102. serprog.h
  103. sfdp.c
  104. spi.c
  105. spi.h
  106. spi25.c
  107. spi25_statusreg.c
  108. spi95.c
  109. sst28sf040.c
  110. sst49lfxxxc.c
  111. sst_fwhub.c
  112. stlinkv3_spi.c
  113. stm50.c
  114. udelay.c
  115. usb_device.c
  116. usb_device.h
  117. usbblaster_spi.c
  118. usbdev.c
  119. util/
  120. w29ee011.c
  121. w39.c
  122. wbsio_spi.c