Move register decodes into enable_flash_ich_handle_gcs()

GCS was decoded partly inside, partly outside this function. The
decoding of `top_swap` was off, since passing a `uint8_t` as `bool`
doesn't magically check bit0 only.

While we are at it, rename this void function to enable_flash_ich_
report_gcs() as it's not doing anything. Beside debug output it
doesn't have any side effects.

Change-Id: I40addec98cb6840763adad30f9d0e27dadce6d1e
Signed-off-by: Nico Huber <>
Tested-by: build bot (Jenkins)
Reviewed-by: Philippe Mathieu-Daudé <>
Reviewed-by: Arthur Heymans <>
Reviewed-by: Youness Alaoui <>
1 file changed