soc/medaitek/mt8186: fix wrong condition of RTC drivers
We need to report error while rtc_xosc_write() returns false.
TEST=error logs for RTC disappear
BUG=b:202871018
Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Change-Id: I5fdf4de0383ef373dd45e8d8741aa861c9c4bdc6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59653
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
diff --git a/src/soc/mediatek/mt8186/rtc.c b/src/soc/mediatek/mt8186/rtc.c
index 346fca6..7e38742 100644
--- a/src/soc/mediatek/mt8186/rtc.c
+++ b/src/soc/mediatek/mt8186/rtc.c
@@ -88,8 +88,8 @@
}
rtc_read(RTC_OSC32CON, &osc32con);
- if (rtc_xosc_write((osc32con & ~RTC_XOSCCALI_MASK) |
- (val & RTC_XOSCCALI_MASK))) {
+ if (!rtc_xosc_write((osc32con & ~RTC_XOSCCALI_MASK) |
+ (val & RTC_XOSCCALI_MASK))) {
rtc_info("rtc_xosc_write() failed\n");
return false;
}