commit ff072e6ebfb4f3cf5736e317688930e588a62ec2
author Sridhar Siricilla <sridhar.siricilla@intel.com> Wed Nov 27 14:55:16 2019 +0530
committer Patrick Georgi <pgeorgi@google.com> Sun Feb 09 19:20:00 2020 +0000
tree e8407b4b4a18673002079a1a2e9a381c1ec3f2e0
parent 8e4654527ef5fec658ca5aacad0612653d3dcf30

soc/intel/common: Rename functions for consistent naming

Below changes are done:
1. Rename below functions to have consistent naming:
	set_host_ready() -> cse_set_host_ready()
        wait_cse_sec_override_mode() -> cse_wait_sec_override_mode()
	send_hmrfpo_enable_msg()     -> cse_hmrfpo_enable()
	send_hmrfpo_get_status_msg() -> cse_hmrfpo_get_status()

2. Additional debug messages are added in cse_wait_sec_override_mode().

TEST=Build and Boot hatch board.

Change-Id: Icfcf1631cc37faacdea9ad84be55f5710104bad5
Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com>
Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37282
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>

src/soc/intel/common/block/cse/cse.c

diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index 440b59b..8fbaba5 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -271,7 +271,7 @@
 }
 
 /* Makes the host ready to communicate with CSE */
-void set_host_ready(void)
+void cse_set_host_ready(void)
 {
 	uint32_t csr;
 	csr = read_host_csr();
@@ -280,17 +280,20 @@
 	write_host_csr(csr);
 }
 
-/* Polls for ME state 'HECI_OP_MODE_SEC_OVERRIDE' for 15 seconds */
-uint8_t wait_cse_sec_override_mode(void)
+/* Polls for ME mode ME_HFS1_COM_SECOVER_MEI_MSG for 15 seconds */
+uint8_t cse_wait_sec_override_mode(void)
 {
 	struct stopwatch sw;
 	stopwatch_init_msecs_expire(&sw, HECI_DELAY_READY);
 	while (!cse_is_hfs1_com_secover_mei_msg()) {
 		udelay(HECI_DELAY);
-		if (stopwatch_expired(&sw))
+		if (stopwatch_expired(&sw)) {
+			printk(BIOS_ERR, "HECI: Timed out waiting for SEC_OVERRIDE mode!\n");
 			return 0;
+		}
 	}
-
+	printk(BIOS_DEBUG, "HECI: CSE took %lu ms to enter security override mode\n",
+			stopwatch_duration_msecs(&sw));
 	return 1;
 }
 
@@ -544,7 +547,7 @@
 
 	if (wait_heci_ready()) {
 		/* Device is back on its imaginary feet, clear reset */
-		set_host_ready();
+		cse_set_host_ready();
 		return 1;
 	}
 
@@ -622,7 +625,7 @@
 }
 
 /* Sends HMRFPO Enable command to CSE */
-int send_hmrfpo_enable_msg(void)
+int cse_hmrfpo_enable(void)
 {
 	struct hmrfpo_enable_msg {
 		struct mkhi_hdr hdr;
@@ -682,7 +685,7 @@
  * Sends HMRFPO Get Status command to CSE to get the HMRFPO status.
  * The status can be DISABLES/LOCKED/ENABLED
  */
-int send_hmrfpo_get_status_msg(void)
+int cse_hmrfpo_get_status(void)
 {
 	struct hmrfpo_get_status_msg {
 		struct mkhi_hdr hdr;