commit f55b711c07f6454c38a2de31c3eef5d489e639dd
author Nico Huber <nico.h@gmx.de> Thu Jan 11 18:50:50 2024 +0100
committer Felix Held <felix-coreboot@felixheld.de> Wed Jan 17 15:53:19 2024 +0000
tree 7f120c81a7d43659a8a24aadbecd952eb3c0335c
parent d5ed888367d7a59268327eba21642b25734df664

tree: More use accessor functions for struct region fields

Always use the high-level API region_offset() and region_sz()
functions. This excludes the internal `region.c` code as well
as unit tests. FIT payload support was also skipped, as it
seems it never tried to use the API and would need a bigger
overhaul.

Change-Id: I18f1e37a06783aecde9024c15876b67bfeed70ee
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79955
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-by: Julius Werner <jwerner@chromium.org>

src/soc/qualcomm/common/qclib.c

diff --git a/src/soc/qualcomm/common/qclib.c b/src/soc/qualcomm/common/qclib.c
index cfe3e2a..56fd3bf 100644
--- a/src/soc/qualcomm/common/qclib.c
+++ b/src/soc/qualcomm/common/qclib.c
@@ -106,8 +106,8 @@
 	ddr_region->size = ddr_size * MiB;
 
 	/* Use DDR info to configure MMU */
-	qc_mmu_dram_config_post_dram_init((void *)ddr_region->offset,
-		(size_t)ddr_region->size);
+	qc_mmu_dram_config_post_dram_init(
+		(void *)(uintptr_t)region_offset(ddr_region), region_sz(ddr_region));
 }
 
 static void write_qclib_log_to_cbmemc(struct qclib_cb_if_table_entry *te)

src/soc/qualcomm/sc7180/soc.c

diff --git a/src/soc/qualcomm/sc7180/soc.c b/src/soc/qualcomm/sc7180/soc.c
index d8df98a..cef7e8f 100644
--- a/src/soc/qualcomm/sc7180/soc.c
+++ b/src/soc/qualcomm/sc7180/soc.c
@@ -12,7 +12,7 @@
 	void *start = NULL;
 	void *end = NULL;
 
-	ram_range(dev, 0, (uintptr_t)ddr_region->offset, ddr_region->size);
+	ram_range(dev, 0, (uintptr_t)region_offset(ddr_region), region_sz(ddr_region));
 	reserved_ram_range(dev, 1, (uintptr_t)_dram_aop, REGION_SIZE(dram_aop));
 	reserved_ram_range(dev, 2, (uintptr_t)_dram_soc, REGION_SIZE(dram_soc));
 	if (soc_modem_carve_out(&start, &end))

src/soc/qualcomm/sc7280/soc.c

diff --git a/src/soc/qualcomm/sc7280/soc.c b/src/soc/qualcomm/sc7280/soc.c
index e6dbf21..783c557 100644
--- a/src/soc/qualcomm/sc7280/soc.c
+++ b/src/soc/qualcomm/sc7280/soc.c
@@ -19,7 +19,7 @@
 	void *start = NULL;
 	void *end = NULL;
 
-	ram_range(dev, 0, (uintptr_t)ddr_region->offset, ddr_region->size);
+	ram_range(dev, 0, (uintptr_t)region_offset(ddr_region), region_sz(ddr_region));
 	reserved_ram_range(dev, 1, (uintptr_t)_dram_soc, REGION_SIZE(dram_soc));
 	reserved_ram_range(dev, 2, (uintptr_t)_dram_wlan, REGION_SIZE(dram_wlan));
 	reserved_ram_range(dev, 3, (uintptr_t)_dram_wpss, REGION_SIZE(dram_wpss));