commit f463dc0947dd0fbb25e0ffd4a6200b9ed8a3d654
author Subrata Banik <subrata.banik@intel.com> Mon Sep 14 19:04:03 2020 +0530
committer Subrata Banik <subrata.banik@intel.com> Sat Sep 19 06:37:37 2020 +0000
tree d44aa6ecd64f612a68bbfe5e97ebe88a474ba46c
parent e9b937352eec6e5e5b4a7e120f77f15a2732ac03

soc/intel/common/block/cse: Refactor cse_request_global_reset() function

List of changes:
1. Check if CSE is enabled from devicetree.cb
2. Create helper function cse_request_reset()
3. Modify caller function argument cse_request_global_reset()

Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Change-Id: I3668b473bec8d51f847908d11e2e25c485ec7a97
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45341
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/soc/intel/common/block/cse/cse.c

diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index 4b598e2..ef6db3d 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -616,9 +616,10 @@
 }
 
 /*
- * Sends GLOBAL_RESET_REQ cmd to CSE.The reset type can be GLOBAL_RESET/CSE_RESET_ONLY.
+ * Sends GLOBAL_RESET_REQ cmd to CSE with reset type GLOBAL_RESET.
+ * Returns 0 on failure and 1 on success.
  */
-int cse_request_global_reset(enum rst_req_type rst_type)
+static int cse_request_reset(enum rst_req_type rst_type)
 {
 	int status;
 	struct mkhi_hdr reply;
@@ -644,7 +645,7 @@
 		return 0;
 	}
 
-	if (!cse_is_global_reset_allowed()) {
+	if (!cse_is_global_reset_allowed() || !is_cse_enabled()) {
 		printk(BIOS_ERR, "HECI: CSE does not meet required prerequisites\n");
 		return 0;
 	}
@@ -663,6 +664,11 @@
 	return status;
 }
 
+int cse_request_global_reset(void)
+{
+	return cse_request_reset(GLOBAL_RESET);
+}
+
 static bool cse_is_hmrfpo_enable_allowed(void)
 {
 	/*