ec/lenovo/h8/acpi: Replace Store(a,b) with ASL 2.0 syntax
Replace `Store (a, b)` with `b = a`.
Change-Id: I1c68816f47aa3ed0ab3bf55d4cfde71d5838d051
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70637
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
diff --git a/src/ec/lenovo/h8/acpi/ac.asl b/src/ec/lenovo/h8/acpi/ac.asl
index ec7b7fc..436fdcf 100644
--- a/src/ec/lenovo/h8/acpi/ac.asl
+++ b/src/ec/lenovo/h8/acpi/ac.asl
@@ -15,8 +15,8 @@
Method(_PSR, 0, NotSerialized)
{
- Store(HPAC, Local0)
- Store(Local0, \PWRS)
+ Local0 = HPAC
+ \PWRS = Local0
\PNOT()
return (Local0)
}
diff --git a/src/ec/lenovo/h8/acpi/beep.asl b/src/ec/lenovo/h8/acpi/beep.asl
index 214c8a9..3e51938 100644
--- a/src/ec/lenovo/h8/acpi/beep.asl
+++ b/src/ec/lenovo/h8/acpi/beep.asl
@@ -9,5 +9,5 @@
Method(BEEP, 1, NotSerialized)
{
- Store (Arg0, SNDS)
+ SNDS = Arg0
}
diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl
index 31ddc55..314ab04 100644
--- a/src/ec/lenovo/h8/acpi/ec.asl
+++ b/src/ec/lenovo/h8/acpi/ec.asl
@@ -67,9 +67,9 @@
if (Arg1 == 1) {
/* Fill HKEY defaults on first boot */
if (^HKEY.INIT == 0) {
- Store (BTEB, ^HKEY.WBDC)
- Store (WWEB, ^HKEY.WWAN)
- Store (One, ^HKEY.INIT)
+ ^HKEY.WBDC = BTEB
+ ^HKEY.WWAN = WWEB
+ ^HKEY.INIT = One
}
}
}
@@ -86,7 +86,7 @@
Method (TLED, 1, NotSerialized)
{
- Store(Arg0, LEDS)
+ LEDS = Arg0
}
/* Not used for coreboot. Provided for compatibility with thinkpad-acpi. */
@@ -101,24 +101,24 @@
Method (MUTE, 1, NotSerialized)
{
- Store(Arg0, AMUT)
+ AMUT = Arg0
}
Method (RADI, 1, NotSerialized)
{
- Store(Arg0, WLEB)
- Store(Arg0, WWEB)
- Store(Arg0, BTEB)
+ WLEB = Arg0
+ WWEB = Arg0
+ BTEB = Arg0
}
Method (USBP, 1, NotSerialized)
{
- Store(Arg0, USPW)
+ USPW = Arg0
}
Method (LGHT, 1, NotSerialized)
{
- Store(Arg0, KBLT)
+ KBLT = Arg0
}
@@ -157,7 +157,7 @@
Method(_Q27, 0, NotSerialized)
{
Notify (AC, 0x80)
- Store(0x50, EVNT)
+ EVNT = 0x50
\PNOT()
}
@@ -318,11 +318,11 @@
Method (FANE, 1, Serialized)
{
If (Arg0) {
- Store (One, FAND)
- Store (Zero, FANA)
+ FAND = One
+ FANA = Zero
} Else {
- Store (Zero, FAND)
- Store (One, FANA)
+ FAND = Zero
+ FANA = One
}
}
diff --git a/src/ec/lenovo/h8/acpi/lid.asl b/src/ec/lenovo/h8/acpi/lid.asl
index 8b74ecd..7695e4e 100644
--- a/src/ec/lenovo/h8/acpi/lid.asl
+++ b/src/ec/lenovo/h8/acpi/lid.asl
@@ -27,9 +27,9 @@
Method(_PSW, 1, NotSerialized)
{
if (Arg0) {
- Store(1, WKLD)
+ WKLD = 1
} else {
- Store(0, WKLD)
+ WKLD = 0
}
}
}
diff --git a/src/ec/lenovo/h8/acpi/sleepbutton.asl b/src/ec/lenovo/h8/acpi/sleepbutton.asl
index d3d6c9c..441dc65 100644
--- a/src/ec/lenovo/h8/acpi/sleepbutton.asl
+++ b/src/ec/lenovo/h8/acpi/sleepbutton.asl
@@ -20,11 +20,11 @@
Method(_PSW, 1, NotSerialized)
{
if (Arg0) {
- Store(6, FNKY) /* Fn key acts as wake button */
- Store(1, WKFN)
+ FNKY = 6 /* Fn key acts as wake button */
+ WKFN = 1
} else {
- Store(0, FNKY) /* Fn key normal operation */
- Store(0, WKFN)
+ FNKY = 0 /* Fn key normal operation */
+ WKFN = 0
}
}
}
diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl
index 3d4b718..03abd75 100644
--- a/src/ec/lenovo/h8/acpi/thermal.asl
+++ b/src/ec/lenovo/h8/acpi/thermal.asl
@@ -46,7 +46,7 @@
/* Get critical temperature in degree celsius */
Method (GCRT, 0, NotSerialized) {
- Store (\TCRT, Local0)
+ Local0 = \TCRT
if (Local0 > 0) {
Return (Local0)
}
@@ -55,7 +55,7 @@
/* Get passive temperature in degree celsius */
Method (GPSV, 0, NotSerialized) {
- Store (\TPSV, Local0)
+ Local0 = \TPSV
if (Local0 > 0) {
Return (Local0)
}
@@ -76,13 +76,13 @@
If (!MEB1 && \_SB.PCI0.LPCB.EC.TMP0 == 128) {
Return (C2K(40))
}
- Store (1, MEB1)
+ MEB1 = 1
#endif
Return (C2K(\_SB.PCI0.LPCB.EC.TMP0))
}
Method (_AC0) {
- Store (GPSV (), Local0)
+ Local0 = GPSV ()
/* Active fan 10 degree below passive threshold */
Local0 -= 10
@@ -113,13 +113,13 @@
*/
Method (_ON) {
\_SB.PCI0.LPCB.EC.FANE(One)
- Store (One, \FLVL)
+ \FLVL = One
Notify (\_TZ.THM0, NOTIFY_TZ_TRIPPTCHG)
}
Method (_OFF) {
\_SB.PCI0.LPCB.EC.FANE(Zero)
- Store (Zero, \FLVL)
+ \FLVL = Zero
Notify (\_TZ.THM0, NOTIFY_TZ_TRIPPTCHG)
}
}
@@ -163,7 +163,7 @@
If (!MEB2 && \_SB.PCI0.LPCB.EC.TMP1 == 128) {
Return (C2K(40))
}
- Store (1, MEB2)
+ MEB2 = 1
#endif
Return (C2K(\_SB.PCI0.LPCB.EC.TMP1))
}
diff --git a/src/ec/lenovo/h8/acpi/thinkpad.asl b/src/ec/lenovo/h8/acpi/thinkpad.asl
index 622521a..bb2b94a 100644
--- a/src/ec/lenovo/h8/acpi/thinkpad.asl
+++ b/src/ec/lenovo/h8/acpi/thinkpad.asl
@@ -34,15 +34,15 @@
/* Retrieve event. */
Method (MHKP, 0, NotSerialized)
{
- Store (BTN, Local0)
+ Local0 = BTN
If (Local0 != 0) {
- Store (Zero, BTN)
+ BTN = Zero
Local0 += 0x1000
Return (Local0)
}
- Store (BTAB, Local0)
+ Local0 = BTAB
If (Local0 != 0) {
- Store (Zero, BTAB)
+ BTAB = Zero
Local0 += 0x5000
Return (Local0)
}
@@ -53,7 +53,7 @@
Method (RHK, 1, NotSerialized) {
ShiftLeft (One, Arg0 - 1, Local0)
If (EMSK & Local0) {
- Store (Arg0, BTN)
+ BTN = Arg0
Notify (HKEY, 0x80)
}
}
@@ -62,7 +62,7 @@
Method (RTAB, 1, NotSerialized) {
ShiftLeft (One, Arg0 - 1, Local0)
If (ETAB & Local0) {
- Store (Arg0, BTAB)
+ BTAB = Arg0
Notify (HKEY, 0x80)
}
}
@@ -70,15 +70,15 @@
/* Enable/disable all events. */
Method (MHKC, 1, NotSerialized) {
If (Arg0) {
- Store (DHKN, EMSK)
- Store (Ones, ETAB)
+ EMSK = DHKN
+ ETAB = Ones
}
Else
{
- Store (Zero, EMSK)
- Store (Zero, ETAB)
+ EMSK = Zero
+ ETAB = Zero
}
- Store (Arg0, EN)
+ EN = Arg0
}
/* Enable/disable event. */
@@ -95,7 +95,7 @@
}
If (EN)
{
- Store (DHKN, EMSK)
+ EMSK = DHKN
}
}
}
@@ -115,7 +115,7 @@
/* Mute audio */
Method (SSMS, 1, NotSerialized)
{
- Store(Arg0, ALMT)
+ ALMT = Arg0
}
/* Control mute microphone LED */
@@ -159,10 +159,10 @@
*/
Method (GBDC, 0)
{
- Store (One, HAST)
+ HAST = One
If (HBDC) {
- Store(One, Local0)
+ Local0 = One
If(\_SB.PCI0.LPCB.EC.BTEB)
{
Or(Local0, 2, Local0)
@@ -181,13 +181,13 @@
*/
Method (SBDC, 1)
{
- Store (One, HAST)
+ HAST = One
If (HBDC) {
ShiftRight (Arg0 & 2, 1, Local0)
- Store (Local0, \_SB.PCI0.LPCB.EC.BTEB)
+ \_SB.PCI0.LPCB.EC.BTEB = Local0
ShiftRight (Arg0 & 4, 2, Local0)
- Store (Local0, WBDC)
+ WBDC = Local0
}
}
@@ -201,10 +201,10 @@
*/
Method (GWAN, 0)
{
- Store (One, HAST)
+ HAST = One
If (HWAN) {
- Store(One, Local0)
+ Local0 = One
If(\_SB.PCI0.LPCB.EC.WWEB)
{
Or(Local0, 2, Local0)
@@ -223,11 +223,11 @@
*/
Method (SWAN, 1)
{
- Store (One, HAST)
+ HAST = One
If (HWAN) {
ShiftRight (Arg0 & 2, 1, Local0)
- Store (Local0, \_SB.PCI0.LPCB.EC.WWEB)
+ \_SB.PCI0.LPCB.EC.WWEB = Local0
ShiftRight (Arg0 & 4, 2, WWAN)
}
}
@@ -241,7 +241,7 @@
Method (MLCG, 1)
{
If (HKBL) {
- Store (0x200, Local0)
+ Local0 = 0x200
/* FIXME: Support 2bit brightness control */
Or (Local0, \_SB.PCI0.LPCB.EC.KBLT, Local0)
Return (Local0)
@@ -258,7 +258,7 @@
{
If (HKBL) {
/* FIXME: Support 2bit brightness control */
- Store (Arg0 & 1, \_SB.PCI0.LPCB.EC.WWEB)
+ \_SB.PCI0.LPCB.EC.WWEB = Arg0 & 1
}
}
@@ -270,7 +270,7 @@
Method (GUWB, 0)
{
If (HUWB) {
- Store (One, Local0)
+ Local0 = One
If(\_SB.PCI0.LPCB.EC.UWBE)
{
Or(Local0, 2, Local0)
@@ -289,7 +289,7 @@
{
If (HUWB) {
ShiftRight (Arg0 & 2, 1, Local0)
- Store (Local0, \_SB.PCI0.LPCB.EC.UWBE)
+ \_SB.PCI0.LPCB.EC.UWBE = Local0
}
}
@@ -299,8 +299,8 @@
Method (WAKE, 1)
{
If (HAST) {
- Store (WBDC, \_SB.PCI0.LPCB.EC.BTEB)
- Store (WWAN, \_SB.PCI0.LPCB.EC.WWEB)
+ \_SB.PCI0.LPCB.EC.BTEB = WBDC
+ \_SB.PCI0.LPCB.EC.WWEB = WWAN
}
}