commit ecff5215177eee0b01b608f5db6532d3b90222b6
author Angel Pons <th3fanbus@gmail.com> Mon May 16 15:56:36 2022 +0200
committer Felix Held <felix-coreboot@felixheld.de> Wed May 18 20:39:18 2022 +0000
tree 709b146cc6e5a03cb07a2010cfbeee567e567e6c
parent ee449451878ad41caa8724d6435f32c1af474d7b

soc/intel/ehl/tsn_gbe.c: Reduce `void *` casts

Remove two redundant `void *` casts in `clrsetbits32()` calls. In
addition, preemptively retype the `io_mem_base` variable in order
to avoid having to add casts in future commits.

Change-Id: Iae9c8189a6f8cd29181c52c2241789c6d392d77b
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64398
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>

src/soc/intel/elkhartlake/tsn_gbe.c

diff --git a/src/soc/intel/elkhartlake/tsn_gbe.c b/src/soc/intel/elkhartlake/tsn_gbe.c
index 4a340b2..4d8944a 100644
--- a/src/soc/intel/elkhartlake/tsn_gbe.c
+++ b/src/soc/intel/elkhartlake/tsn_gbe.c
@@ -20,9 +20,9 @@
 	printk(BIOS_DEBUG, "TSN GbE: Programming MAC Address...\n");
 
 	/* Write the upper 16 bits of the first 6-byte MAC address */
-	clrsetbits32((void *)(base + TSN_MAC_ADD0_HIGH), 0xffff, ((mac[5] << 8) | mac[4]));
+	clrsetbits32(base + TSN_MAC_ADD0_HIGH, 0xffff, ((mac[5] << 8) | mac[4]));
 	/* Write the lower 32 bits of the first 6-byte MAC address */
-	clrsetbits32((void *)(base + TSN_MAC_ADD0_LOW), 0xffffffff,
+	clrsetbits32(base + TSN_MAC_ADD0_LOW, 0xffffffff,
 			(mac[3] << 24) | (mac[2] << 16) | (mac[1] << 8) | mac[0]);
 }
 
@@ -30,10 +30,10 @@
 {
 	/* Get the base address of the I/O registers in memory space */
 	struct resource *gbe_tsn_res = find_resource(dev, PCI_BASE_ADDRESS_0);
-	uintptr_t io_mem_base = gbe_tsn_res->base;
+	void *io_mem_base = (void *)(uintptr_t)gbe_tsn_res->base;
 
 	/* Program MAC address */
-	program_mac_address(dev, (void *)io_mem_base);
+	program_mac_address(dev, io_mem_base);
 }
 
 static struct device_operations gbe_tsn_ops  = {