treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
diff --git a/src/soc/qualcomm/common/clock.c b/src/soc/qualcomm/common/clock.c
index 09cd95c..e06a954 100644
--- a/src/soc/qualcomm/common/clock.c
+++ b/src/soc/qualcomm/common/clock.c
@@ -27,7 +27,7 @@
return CB_SUCCESS;
udelay(1);
}
- printk(BIOS_ERR, "ERROR: Failed to enable clock, register val: 0x%x\n",
+ printk(BIOS_ERR, "Failed to enable clock, register val: 0x%x\n",
read32(cbcr_addr));
return CB_ERR;
}
@@ -45,7 +45,7 @@
return CB_SUCCESS;
udelay(1);
}
- printk(BIOS_ERR, "ERROR: Failed to enable clock, register val: 0x%x\n",
+ printk(BIOS_ERR, "Failed to enable clock, register val: 0x%x\n",
read32(cbcr_addr));
return CB_ERR;
}
@@ -207,7 +207,7 @@
/* Wait for Lock Detection */
if (!wait_us(100, read32(cfg->reg_mode) & PLL_LOCK_DET_BMSK)) {
- printk(BIOS_ERR, "ERROR: PLL did not lock!\n");
+ printk(BIOS_ERR, "PLL did not lock!\n");
return CB_ERR;
}
}
@@ -227,7 +227,7 @@
setbits32(cfg->reg_mode, BIT(PLL_RESET_SHFT));
if (!wait_us(100, read32(cfg->reg_mode) & PLL_LOCK_DET_BMSK)) {
- printk(BIOS_ERR, "ERROR: CPU PLL did not lock!\n");
+ printk(BIOS_ERR, "CPU PLL did not lock!\n");
return CB_ERR;
}
@@ -249,7 +249,7 @@
setbits32(cfg->reg_opmode, PLL_RUN_MODE);
if (!wait_us(100, read32(cfg->reg_mode) & PLL_LOCK_DET_BMSK)) {
- printk(BIOS_ERR, "ERROR: CPU PLL did not lock!\n");
+ printk(BIOS_ERR, "CPU PLL did not lock!\n");
return CB_ERR;
}