treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
diff --git a/src/soc/amd/common/psp_verstage/vboot_crypto.c b/src/soc/amd/common/psp_verstage/vboot_crypto.c
index 581d924..d872678 100644
--- a/src/soc/amd/common/psp_verstage/vboot_crypto.c
+++ b/src/soc/amd/common/psp_verstage/vboot_crypto.c
@@ -50,7 +50,7 @@
sha_op.Data = (uint8_t *) buf;
if (!sha_op_size_remaining) {
- printk(BIOS_ERR, "ERROR: got more data than expected.\n");
+ printk(BIOS_ERR, "got more data than expected.\n");
return VB2_ERROR_UNKNOWN;
}
@@ -65,7 +65,7 @@
retval = svc_crypto_sha(&sha_op, SHA_GENERIC);
if (retval) {
- printk(BIOS_ERR, "ERROR: HW crypto failed - errorcode: %#x\n",
+ printk(BIOS_ERR, "HW crypto failed - errorcode: %#x\n",
retval);
return VB2_ERROR_UNKNOWN;
}
@@ -84,12 +84,12 @@
vb2_error_t vb2ex_hwcrypto_digest_finalize(uint8_t *digest, uint32_t digest_size)
{
if (sha_op.Eom == 0) {
- printk(BIOS_ERR, "ERROR: Got less data than expected.\n");
+ printk(BIOS_ERR, "Got less data than expected.\n");
return VB2_ERROR_UNKNOWN;
}
if (digest_size != sha_op.DigestLen) {
- printk(BIOS_ERR, "ERROR: Digest size does not match expected length.\n");
+ printk(BIOS_ERR, "Digest size does not match expected length.\n");
return VB2_ERROR_UNKNOWN;
}
@@ -134,7 +134,7 @@
retval = svc_modexp(&mod_exp_param);
if (retval) {
- printk(BIOS_ERR, "ERROR: HW crypto failed - errorcode: %#x\n",
+ printk(BIOS_ERR, "HW crypto failed - errorcode: %#x\n",
retval);
return VB2_ERROR_EX_HWCRYPTO_UNSUPPORTED;
}