treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
diff --git a/src/soc/amd/common/psp_verstage/psp_verstage.c b/src/soc/amd/common/psp_verstage/psp_verstage.c
index 9f34700..30dc115 100644
--- a/src/soc/amd/common/psp_verstage/psp_verstage.c
+++ b/src/soc/amd/common/psp_verstage/psp_verstage.c
@@ -100,12 +100,12 @@
amdfw_location = cbfs_map(fname, NULL);
if (!amdfw_location) {
- printk(BIOS_ERR, "Error: AMD Firmware table not found.\n");
+ printk(BIOS_ERR, "AMD Firmware table not found.\n");
return POSTCODE_AMD_FW_MISSING;
}
ef_table = (struct embedded_firmware *)amdfw_location;
if (ef_table->signature != EMBEDDED_FW_SIGNATURE) {
- printk(BIOS_ERR, "Error: ROMSIG address is not correct.\n");
+ printk(BIOS_ERR, "ROMSIG address is not correct.\n");
return POSTCODE_ROMSIG_MISMATCH_ERROR;
}
@@ -116,11 +116,11 @@
bios_dir_in_spi = (uint32_t *)((bios_dir_addr & SPI_ADDR_MASK) +
(uint32_t)boot_dev_base);
if (*psp_dir_in_spi != PSP_COOKIE) {
- printk(BIOS_ERR, "Error: PSP Directory address is not correct.\n");
+ printk(BIOS_ERR, "PSP Directory address is not correct.\n");
return POSTCODE_PSP_COOKIE_MISMATCH_ERROR;
}
if (*bios_dir_in_spi != BDT1_COOKIE) {
- printk(BIOS_ERR, "Error: BIOS Directory address is not correct.\n");
+ printk(BIOS_ERR, "BIOS Directory address is not correct.\n");
return POSTCODE_BDT1_COOKIE_MISMATCH_ERROR;
}
@@ -131,7 +131,7 @@
}
if (update_psp_bios_dir(&psp_dir_addr, &bios_dir_addr)) {
- printk(BIOS_ERR, "Error: Updated BIOS Directory could not be set.\n");
+ printk(BIOS_ERR, "Updated BIOS Directory could not be set.\n");
return POSTCODE_UPDATE_PSP_BIOS_DIR_ERROR;
}
@@ -183,7 +183,7 @@
}
if (buffer_size > max_buffer_size) {
- printk(BIOS_ERR, "Error: Buffer is larger than max buffer size.\n");
+ printk(BIOS_ERR, "Buffer is larger than max buffer size.\n");
post_code(POSTCODE_WORKBUF_BUFFER_SIZE_ERROR);
return POSTCODE_WORKBUF_BUFFER_SIZE_ERROR;
}
@@ -198,7 +198,7 @@
retval = save_uapp_data((void *)_transfer_buffer, buffer_size);
if (retval) {
- printk(BIOS_ERR, "Error: Could not save workbuf. Error code 0x%08x\n", retval);
+ printk(BIOS_ERR, "Could not save workbuf. Error code 0x%08x\n", retval);
return POSTCODE_WORKBUF_SAVE_ERROR;
}