treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels,
it is no longer necessary to explicitly add "ERROR: " in front of every
BIOS_ERR message to help it stand out more (and allow automated tooling
to grep for it). Removing all these extra .rodata characters should save
us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same
thing for BIOS_WARN with
's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner <jwerner@chromium.org>
Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Lance Zhao
Reviewed-by: Jason Glenesk <jason.glenesk@gmail.com>
diff --git a/src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c b/src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c
index a0fcf11..806e9b2 100644
--- a/src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c
+++ b/src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c
@@ -194,13 +194,13 @@
return CB_ERR;
if (!wait_ms(100, !i2c_readb(bus, chip, SN_AUX_CMD_REG, &buf) &&
!(buf & AUX_CMD_SEND))) {
- printk(BIOS_ERR, "ERROR: AUX_CMD_SEND not acknowledged\n");
+ printk(BIOS_ERR, "AUX_CMD_SEND not acknowledged\n");
return CB_ERR;
}
if (i2c_readb(bus, chip, SN_AUX_CMD_STATUS_REG, &buf))
return CB_ERR;
if (buf & (NAT_I2C_FAIL | AUX_SHORT | AUX_DFER | AUX_RPLY_TOUT)) {
- printk(BIOS_ERR, "ERROR: AUX command failed, status = %#x\n", buf);
+ printk(BIOS_ERR, "AUX command failed, status = %#x\n", buf);
return CB_ERR;
}
@@ -230,7 +230,7 @@
err = sn65dsi86_bridge_aux_request(bus, chip, EDID_I2C_ADDR, EDID_LENGTH,
I2C_RAW_READ_AND_STOP, edid);
if (err) {
- printk(BIOS_ERR, "ERROR: Failed to read EDID.\n");
+ printk(BIOS_ERR, "Failed to read EDID.\n");
return err;
}
@@ -249,7 +249,7 @@
}
if (decode_edid(edid, edid_size, out) != EDID_CONFORMANT) {
- printk(BIOS_ERR, "ERROR: Failed to decode EDID.\n");
+ printk(BIOS_ERR, "Failed to decode EDID.\n");
return CB_ERR;
}
@@ -364,7 +364,7 @@
if (dp_rate_idx < ARRAY_SIZE(sn65dsi86_bridge_dp_rate_lut))
i2c_write_field(bus, chip, SN_DATARATE_CONFIG_REG, dp_rate_idx, 8, 5);
else
- printk(BIOS_ERR, "ERROR: valid dp rate not found");
+ printk(BIOS_ERR, "valid dp rate not found");
}
static void sn65dsi86_bridge_set_bridge_active_timing(uint8_t bus,
@@ -407,7 +407,7 @@
if (!wait_ms(500,
!(i2c_readb(bus, chip, SN_DPPLL_SRC_REG, &buf)) &&
(buf & BIT(7)))) {
- printk(BIOS_ERR, "ERROR: PLL lock failure\n");
+ printk(BIOS_ERR, "PLL lock failure\n");
}
/*
@@ -426,14 +426,14 @@
if (!wait_ms(500, !(i2c_readb(bus, chip, SN_ML_TX_MODE_REG, &buf)) &&
(buf == NORMAL_MODE || buf == MAIN_LINK_OFF))) {
- printk(BIOS_ERR, "ERROR: unexpected link training state: %#x\n", buf);
+ printk(BIOS_ERR, "unexpected link training state: %#x\n", buf);
return;
}
if (buf == NORMAL_MODE)
return;
}
- printk(BIOS_ERR, "ERROR: Link training failed 10 times\n");
+ printk(BIOS_ERR, "Link training failed 10 times\n");
}
void sn65dsi86_backlight_enable(uint8_t bus, uint8_t chip)