mb/google/brya: Rework BOARD_GOOGLE_BASEBOARD_* Kconfig
Current mainboard code supports different baseboard binding
example: brya uses BOARD_GOOGLE_BASEBOARD_BRYA and brask uses
BOARD_GOOGLE_BASEBOARD_BRASK Kconfig.
This patch makes the `BOARD_GOOGLE_BRYA_COMMON` Kconfig default
`n` and specific baseboard binding Kconfig can select this Kconfig.
It would also avoid adding if clause for specific baseboard binding
Kconfig everytime with introduction of newer mainboard in future.
TEST=Verified CONFIG_BOARD_GOOGLE_BRYA_COMMON=y while building brya
and brya coreboot.rom remains the same.
Signed-off-by: Subrata Banik <subratabanik@google.com>
Change-Id: I754159447e68b8ac2ea21009cc801fc5ba5df56e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60379
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig
index 0e7651f..34e005d 100644
--- a/src/mainboard/google/brya/Kconfig
+++ b/src/mainboard/google/brya/Kconfig
@@ -1,23 +1,5 @@
-config BOARD_GOOGLE_BASEBOARD_BRYA
- def_bool n
- select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS
- select HAVE_SPD_IN_CBFS
- select SOC_INTEL_ALDERLAKE_PCH_P
- select SYSTEM_TYPE_LAPTOP
-
-config BOARD_GOOGLE_BASEBOARD_BRASK
- def_bool n
- select SPD_CACHE_IN_FMAP
- select ENABLE_TCSS_DISPLAY_DETECTION if RUN_FSP_GOP
- select RT8168_GET_MAC_FROM_VPD
- select RT8168_SET_LED_MODE
- select RT8168_GEN_ACPI_POWER_RESOURCE
- select SOC_INTEL_ALDERLAKE_PCH_P
-
-if BOARD_GOOGLE_BASEBOARD_BRYA || BOARD_GOOGLE_BASEBOARD_BRASK
-
config BOARD_GOOGLE_BRYA_COMMON
- def_bool y
+ def_bool n
select BOARD_ROMSIZE_KB_32768
select DRIVERS_GENERIC_ALC1015
select DRIVERS_GENERIC_GPIO_KEYS
@@ -53,6 +35,26 @@
select SOC_INTEL_COMMON_BLOCK_PCIE_RTD3
select SOC_INTEL_CSE_LITE_SKU
+config BOARD_GOOGLE_BASEBOARD_BRYA
+ def_bool n
+ select BOARD_GOOGLE_BRYA_COMMON
+ select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS
+ select HAVE_SPD_IN_CBFS
+ select SOC_INTEL_ALDERLAKE_PCH_P
+ select SYSTEM_TYPE_LAPTOP
+
+config BOARD_GOOGLE_BASEBOARD_BRASK
+ def_bool n
+ select BOARD_GOOGLE_BRYA_COMMON
+ select SPD_CACHE_IN_FMAP
+ select ENABLE_TCSS_DISPLAY_DETECTION if RUN_FSP_GOP
+ select RT8168_GET_MAC_FROM_VPD
+ select RT8168_SET_LED_MODE
+ select RT8168_GEN_ACPI_POWER_RESOURCE
+ select SOC_INTEL_ALDERLAKE_PCH_P
+
+if BOARD_GOOGLE_BRYA_COMMON
+
config BASEBOARD_DIR
string
default "brya" if BOARD_GOOGLE_BASEBOARD_BRYA
@@ -187,4 +189,4 @@
endchoice
-endif # BOARD_GOOGLE_BASEBOARD_BRYA || BOARD_GOOGLE_BASEBOARD_BRASK
+endif # BOARD_GOOGLE_BRYA_COMMON