commit e1aa9833c1eb80c193d1b7d7effe27140e1df154
author Kyösti Mälkki <kyosti.malkki@gmail.com> Sat Mar 23 10:00:31 2019 +0200
committer Patrick Georgi <pgeorgi@google.com> Mon Jan 18 07:26:32 2021 +0000
tree 745343e5edc93b07e64e70b01b98beb1d2bab5eb
parent 4c4f9161728f42f959b4394ba42aefb64e35afe2

lib/ramtest: Fix ram_check() declarations

For a long time, second parameter 'stop' has been
ignored. The tested range is within 1 MiB above 'start'.

Change-Id: Icbf94cd6a651fbf0cd9aab97eb11f9b03f0c3c31
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48561
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/include/lib.h

diff --git a/src/include/lib.h b/src/include/lib.h
index 5c6eef2..359626c 100644
--- a/src/include/lib.h
+++ b/src/include/lib.h
@@ -12,9 +12,9 @@
 
 /* Defined in src/lib/ramtest.c */
 /* Assumption is 32-bit addressable UC memory. */
-void ram_check(unsigned long start, unsigned long stop);
-int ram_check_nodie(unsigned long start, unsigned long stop);
-int ram_check_noprint_nodie(unsigned long start, unsigned long stop);
+void ram_check(uintptr_t start);
+int ram_check_nodie(uintptr_t start);
+int ram_check_noprint_nodie(uintptr_t start);
 void quick_ram_check_or_die(uintptr_t dst);
 
 /* Defined in primitive_memtest.c */

src/lib/ramtest.c

diff --git a/src/lib/ramtest.c b/src/lib/ramtest.c
index c6cd7a4..224393f 100644
--- a/src/lib/ramtest.c
+++ b/src/lib/ramtest.c
@@ -67,7 +67,7 @@
  *
  * @param start   System memory offset, aligned to 128bytes
  */
-static int ram_bitset_nodie(unsigned long start)
+static int ram_bitset_nodie(uintptr_t start)
 {
 	unsigned long addr, value, value2;
 	unsigned short int idx;
@@ -117,7 +117,7 @@
 }
 
 
-void ram_check(unsigned long start, unsigned long stop)
+void ram_check(uintptr_t start)
 {
 	/*
 	 * This is much more of a "Is my DRAM properly configured?"
@@ -131,7 +131,7 @@
 }
 
 
-int ram_check_nodie(unsigned long start, unsigned long stop)
+int ram_check_nodie(uintptr_t start)
 {
 	int ret;
 	/*
@@ -146,7 +146,7 @@
 	return ret;
 }
 
-int ram_check_noprint_nodie(unsigned long start, unsigned long stop)
+int ram_check_noprint_nodie(uintptr_t start)
 {
 	unsigned long addr, value, value2;
 	unsigned short int idx;

src/northbridge/intel/ironlake/raminit.c

diff --git a/src/northbridge/intel/ironlake/raminit.c b/src/northbridge/intel/ironlake/raminit.c
index beb2244..a49bd08 100644
--- a/src/northbridge/intel/ironlake/raminit.c
+++ b/src/northbridge/intel/ironlake/raminit.c
@@ -4708,7 +4708,7 @@
 	if (s3resume && cbmem_wasnot_inited) {
 		u32 reg32;
 		printk(BIOS_ERR, "Failed S3 resume.\n");
-		ram_check(0x100000, 0x200000);
+		ram_check_nodie(1 * MiB);
 
 		/* Clear SLP_TYPE.  */
 		reg32 = inl(DEFAULT_PMBASE + 0x04);