commit dfad0708311758d6a9377b0390df0707f5fb4291
author Kyösti Mälkki <kyosti.malkki@gmail.com> Thu Jul 10 06:32:36 2014 +0300
committer Kyösti Mälkki <kyosti.malkki@gmail.com> Mon Jul 14 19:51:16 2014 +0200
tree 91ebfb629a9014d38b08f2d539aed4b88de77efb
parent 37ab729ec3a2af63c15739859e02255c02939f78

AGESA Hudson: Fix typecasts in Fch_Oem_config()

Like many other (but not all) BiosCallouts, StdHeader is also passed
as ConfigPtr argument. Use that instead to make no assumptions of the
real type of FchData as it changes depending of the StdHeader.

Change-Id: Ibdf01d08e63b9e1b8e99ac16abb7f807d37a056e
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/6240
Tested-by: build bot (Jenkins)
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>

src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c

diff --git a/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c b/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c
index 645f334..736811e 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c
+++ b/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c
@@ -187,14 +187,14 @@
  */
 AGESA_STATUS Fch_Oem_config(UINT32 Func, UINT32 FchData, VOID *ConfigPtr)
 {
-	FCH_RESET_DATA_BLOCK *FchParams = (FCH_RESET_DATA_BLOCK *)FchData;
+	AMD_CONFIG_PARAMS *StdHeader = ConfigPtr;
 
-	if (FchParams->StdHeader->Func == AMD_INIT_RESET) {
+	if (StdHeader->Func == AMD_INIT_RESET) {
 		FCH_RESET_DATA_BLOCK *FchParams_reset =  (FCH_RESET_DATA_BLOCK *) FchData;
 		printk(BIOS_DEBUG, "Fch OEM config in INIT RESET ");
 		//FchParams_reset->EcChannel0 = TRUE; /* logical devicd 3 */
 		FchParams_reset->LegacyFree = IS_ENABLED(CONFIG_HUDSON_LEGACY_FREE);
-	} else if (FchParams->StdHeader->Func == AMD_INIT_ENV) {
+	} else if (StdHeader->Func == AMD_INIT_ENV) {
 		FCH_DATA_BLOCK *FchParams_env = (FCH_DATA_BLOCK *)FchData;
 		printk(BIOS_DEBUG, "Fch OEM config in INIT ENV ");