commit ddcb7f1cc410577726f1c34842cf3065ac985ec0
author Felix Held <felix-coreboot@felixheld.de> Sat Jan 28 04:20:01 2023 +0100
committer Felix Held <felix-coreboot@felixheld.de> Tue Jan 31 17:36:31 2023 +0000
tree 37bb3949ed78294a989c99b14251e01981a82307
parent f678ecf369b956d3fb156c745814cab31f2d7a4a

soc/amd/glinda/acpi: use acpigen_write_processor_device

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Iec9cf7c195fa5cb5c8d992aeab400d05cbe801c2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/72494
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>

src/soc/amd/glinda/acpi.c

diff --git a/src/soc/amd/glinda/acpi.c b/src/soc/amd/glinda/acpi.c
index 0c95494..8d6c008 100644
--- a/src/soc/amd/glinda/acpi.c
+++ b/src/soc/amd/glinda/acpi.c
@@ -232,10 +232,10 @@
 void generate_cpu_entries(const struct device *device)
 {
 	int logical_cores;
-	size_t pstate_count, cpu, proc_blk_len;
+	size_t pstate_count, cpu;
 	struct acpi_sw_pstate pstate_values[MAX_PSTATES] = { {0} };
 	struct acpi_xpss_sw_pstate pstate_xpss_values[MAX_PSTATES] = { {0} };
-	uint32_t threads_per_core, proc_blk_addr;
+	uint32_t threads_per_core;
 	uint32_t cstate_base_address =
 		rdmsr(MSR_CSTATE_ADDRESS).lo & MSR_CSTATE_ADDRESS_MASK;
 
@@ -296,18 +296,7 @@
 	logical_cores = get_cpu_count();
 
 	for (cpu = 0; cpu < logical_cores; cpu++) {
-
-		if (cpu == 0) {
-			/* BSP values for \_SB.Pxxx */
-			proc_blk_len = 6;
-			proc_blk_addr = ACPI_GPE0_BLK;
-		} else {
-			/* AP values for \_SB.Pxxx */
-			proc_blk_addr = 0;
-			proc_blk_len = 0;
-		}
-
-		acpigen_write_processor(cpu, proc_blk_addr, proc_blk_len);
+		acpigen_write_processor_device(cpu);
 
 		acpigen_write_pct_package(&perf_ctrl, &perf_sts);
 
@@ -330,7 +319,7 @@
 
 		generate_cppc_entries(cpu);
 
-		acpigen_pop_len();
+		acpigen_write_processor_device_end();
 	}
 
 	acpigen_write_processor_package("PPKG", 0, logical_cores);