commit d835da91552bc74892dce7b9d2aafb74ce86b1f2
author Fabio Aiuto <fabioaiuto83@gmail.com> Fri Sep 30 11:25:28 2022 +0200
committer Martin Roth <martin.roth@amd.corp-partner.google.com> Thu Oct 06 18:32:21 2022 +0000
tree 9930a94e31587b8f64dad63aab25971b15a3328f
parent 4fce79f69c04094fcdd6f2ee89e06a1a776a7deb

treewide: use predicates to check for enabled pci devices

use functions to check for pci devices instead of open-coded
solution.

TEST: compiled and qemu run successfully

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Change-Id: Idb992904112db611119b2d33c8b1dd912b2c8539
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68102
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/soc/intel/broadwell/pch/lpc.c

diff --git a/src/soc/intel/broadwell/pch/lpc.c b/src/soc/intel/broadwell/pch/lpc.c
index 5c4103d..5a1623f 100644
--- a/src/soc/intel/broadwell/pch/lpc.c
+++ b/src/soc/intel/broadwell/pch/lpc.c
@@ -86,7 +86,7 @@
 	for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) {
 		u8 int_pin = 0, int_line = 0;
 
-		if (!irq_dev->enabled || irq_dev->path.type != DEVICE_PATH_PCI)
+		if (!is_enabled_pci(irq_dev))
 			continue;
 
 		int_pin = pci_read_config8(irq_dev, PCI_INTERRUPT_PIN);

src/soc/intel/common/block/lpc/lpc_lib.c

diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c
index 99e3749..d499918 100644
--- a/src/soc/intel/common/block/lpc/lpc_lib.c
+++ b/src/soc/intel/common/block/lpc/lpc_lib.c
@@ -436,7 +436,7 @@
 	for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) {
 		uint8_t int_pin = 0, int_line = 0;
 
-		if (!irq_dev->enabled || irq_dev->path.type != DEVICE_PATH_PCI)
+		if (!is_enabled_pci(irq_dev))
 			continue;
 
 		int_pin = pci_read_config8(PCI_BDF(irq_dev), PCI_INTERRUPT_PIN);

src/soc/intel/denverton_ns/lpc.c

diff --git a/src/soc/intel/denverton_ns/lpc.c b/src/soc/intel/denverton_ns/lpc.c
index 1fc1ea3..5d1eda5 100644
--- a/src/soc/intel/denverton_ns/lpc.c
+++ b/src/soc/intel/denverton_ns/lpc.c
@@ -254,7 +254,7 @@
 	int8_t original_int_pin = 0, new_int_pin = 0, swiz_int_pin = 0;
 	uint8_t int_line = 0xff;
 
-	if (irq_dev->path.type != DEVICE_PATH_PCI || !irq_dev->enabled) {
+	if (!is_enabled_pci(irq_dev)) {
 		printk(BIOS_ERR, "%s for non pci device?\n", __func__);
 		goto dnv_get_int_line_done;
 	}
@@ -380,7 +380,7 @@
 		int devfn = irq_dev->path.pci.devfn;
 		u8 int_pin = 0, int_line = 0;
 
-		if (!irq_dev->enabled || irq_dev->path.type != DEVICE_PATH_PCI)
+		if (!is_enabled_pci(irq_dev))
 			continue;
 
 		int_pin = pci_read_config8(irq_dev, PCI_INTERRUPT_PIN);