Define some variables that were not defined. There are a couple left.
Do kbuildall then grep not.defined kbuildall.results/*
The interesting ones were GENERATE_* I had to put them in twice to make it work
correctly: once outside the menu setting the defaults, and once inside the menu.
Now they show up when they should, and are always defined
Define HAVE_INIT_TIMER to only exclude the three boards that define it to be 0
in newconfig.
Define MEM_TRAIN_SEQ to be an integer and set it correctly.
Remove CAR_FAM10 and just depend on NORTHBRIDGE_AMD_AMDFAM10
MOVNTI is a performance enhancement, and should default to 0 so it doesn't break
boards that forget to define it.
Signed-off-by: Myles Watson <mylesgw@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4856 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
diff --git a/src/Kconfig b/src/Kconfig
index 1625a00..b53a2da 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -74,10 +74,6 @@
int
default 36
-config AGP_APERTURE_SIZE
- hex
- default 0x0
-
config XIP_ROM_BASE
hex
default 0xfffe0000
@@ -181,7 +177,7 @@
config HAVE_INIT_TIMER
bool
- default n
+ default y
config HAVE_MAINBOARD_RESOURCES
bool
@@ -189,7 +185,7 @@
config HAVE_MOVNTI
bool
- default y
+ default n
config HAVE_OPTION_TABLE
bool
@@ -216,6 +212,7 @@
default n
config VIDEO_MB
+ default 0
int
config USE_WATCHDOG_ON_BOOT
@@ -230,6 +227,7 @@
config GFXUMA
bool
+ default n
help
Enable Unified Memory Architecture for graphics.
@@ -238,6 +236,27 @@
#
# endmenu
+#TODO Remove this option or make it useful.
+config HAVE_LOW_TABLES
+ bool
+ default y
+ help
+ This Option is unused in the code. Since two boards try to set it to
+ 'n', they may be broken. We either need to make the option useful or
+ get rid of it. The broken boards are:
+ asus/m2v-mx_se
+ supermicro/h8dme
+
+config HAVE_HIGH_TABLES
+ bool
+ default n
+ help
+ This variable specifies whether a given northbridge has high table
+ support.
+ It is set in northbridge/*/Kconfig.
+ Whether or not the high tables are actually written by coreboot is
+ configurable by the user via WRITE_HIGH_TABLES.
+
config HAVE_ACPI_TABLES
bool
help
@@ -262,15 +281,27 @@
Whether or not the PIRQ table is actually generated by coreboot
is configurable by the user via GENERATE_PIRQ_TABLE.
-config HAVE_HIGH_TABLES
+#These Options are here to avoid "undefined" warnings.
+#The actual selection and help texts are in the following menu.
+
+config GENERATE_ACPI_TABLES
bool
+ default HAVE_ACPI_TABLES
+
+config GENERATE_MP_TABLE
+ bool
+ default HAVE_MP_TABLE
+
+config GENERATE_PIRQ_TABLE
+ bool
+ default HAVE_PIRQ_TABLE
+
+config WRITE_HIGH_TABLES
+ bool
+ default HAVE_HIGH_TABLES
menu "System tables"
-config HAVE_LOW_TABLES
- bool
- default y
-
config WRITE_HIGH_TABLES
bool "Write 'high' tables to avoid being overwritten in F segment"
depends on HAVE_HIGH_TABLES
@@ -409,3 +440,16 @@
config LIFT_BSP_APIC_ID
bool
default n
+
+# These probably belong somewhere else, but they are needed somewhere.
+config AP_CODE_IN_CAR
+ bool
+ default n
+
+config USE_INIT
+ bool
+ default n
+
+config ENABLE_APIC_EXT_ID
+ bool
+ default n