intel/gma: Use bitwise or instead addition for valid bit
Page table entries bit 0 is used as "valid". Its value should be set
by a bitwise OR and not by an addition.
Signed-off-by: Petr Cvek <petrcvekcz@gmail.com>
Change-Id: I14467081c8279af4611007a25aefab606c61a058
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65172
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c
index 7f5aa094..d99a733 100644
--- a/src/northbridge/intel/i945/gma.c
+++ b/src/northbridge/intel/i945/gma.c
@@ -343,7 +343,7 @@
for (i = 0; i < (uma_size - 256) / 4; i++) {
outl((i << 2) | 1, piobase);
- outl(pphysbase + (i << 12) + 1, piobase + 4);
+ outl((pphysbase + (i << 12)) | 1, piobase + 4);
}
temp = read32(mmiobase + PGETBL_CTL);
@@ -521,7 +521,7 @@
for (i = 0; i < (uma_size - 256) / 4; i++) {
outl((i << 2) | 1, piobase);
- outl(pphysbase + (i << 12) + 1, piobase + 4);
+ outl((pphysbase + (i << 12)) | 1, piobase + 4);
}
/* Clear interrupts. */