ACPI: Move redundant FADT reserved entry
Change-Id: I35f66cdad6b8bedf4337aa8e5af7b0f1b53fe674
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42033
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c
index fefa7bf..a69cdb6 100644
--- a/src/acpi/acpi.c
+++ b/src/acpi/acpi.c
@@ -1242,13 +1242,16 @@
header->asl_compiler_revision = asl_revision;
fadt->firmware_ctrl = (unsigned long) facs;
- fadt->dsdt = (unsigned long) dsdt;
-
fadt->x_firmware_ctl_l = (unsigned long)facs;
fadt->x_firmware_ctl_h = 0;
+
+ fadt->dsdt = (unsigned long) dsdt;
fadt->x_dsdt_l = (unsigned long)dsdt;
fadt->x_dsdt_h = 0;
+ /* should be 0 ACPI 3.0 */
+ fadt->reserved = 0;
+
if (CONFIG(SYSTEM_TYPE_CONVERTIBLE) ||
CONFIG(SYSTEM_TYPE_LAPTOP))
fadt->preferred_pm_profile = PM_MOBILE;
diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c
index 691db62..bdaca57 100644
--- a/src/southbridge/intel/bd82x6x/lpc.c
+++ b/src/southbridge/intel/bd82x6x/lpc.c
@@ -694,7 +694,6 @@
u16 pmbase = pci_read_config16(dev, 0x40) & 0xfffe;
int c2_latency;
- fadt->reserved = 0;
fadt->sci_int = 0x9;
diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c
index 0bfe8eb..58f93bd 100644
--- a/src/southbridge/intel/i82801gx/lpc.c
+++ b/src/southbridge/intel/i82801gx/lpc.c
@@ -519,7 +519,6 @@
fadt->mon_alrm = 0x00;
fadt->century = 0x32;
- fadt->reserved = 0;
fadt->sci_int = 0x9;
if (permanent_smi_handler()) {
diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c
index f2c9afa..3be492d 100644
--- a/src/southbridge/intel/i82801jx/lpc.c
+++ b/src/southbridge/intel/i82801jx/lpc.c
@@ -530,7 +530,6 @@
fadt->mon_alrm = 0x00;
fadt->century = 0x32;
- fadt->reserved = 0;
fadt->sci_int = 0x9;
if (permanent_smi_handler()) {
diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c
index f8926dc..e741fcf 100644
--- a/src/southbridge/intel/ibexpeak/lpc.c
+++ b/src/southbridge/intel/ibexpeak/lpc.c
@@ -588,7 +588,6 @@
u16 pmbase = pci_read_config16(dev, 0x40) & 0xfffe;
int c2_latency;
- fadt->reserved = 0;
fadt->sci_int = 0x9;