commit d16ef4d21ea7efcad97b49bc2633caa4342ecbea
author Subrata Banik <subrata.banik@intel.com> Wed Aug 26 15:53:00 2020 +0530
committer Patrick Georgi <pgeorgi@google.com> Wed Sep 02 07:17:39 2020 +0000
tree eb835ba99e157772ddd315c575c5f75fb3b031f7
parent bd2da5a4b560b96501e343b04fb1e0e189da55cc

util/ifdtool: Fix SPI frequency as per Gen11 SPI flash guide

BUG=b:153888802
TEST=Able to list correct SPI frequency as per TGL SPI flash guide

Without this CL :
Found Component Section
FLCOMP     0x093030f6
  Dual Output Fast Read Support:       not supported
  Read ID/Read Status Clock Frequency: 33MHz
  Write/Erase Clock Frequency:         33MHz
  Fast Read Clock Frequency:           33MHz
  Fast Read Support:                   supported
  Read Clock Frequency:                20MHz

With this CL :
Found Component Section
FLCOMP     0x093030f6
  Dual Output Fast Read Support:       not supported
  Read ID/Read Status Clock Frequency: 50MHz
  Write/Erase Clock Frequency:         50MHz
  Fast Read Clock Frequency:           50MHz
  Fast Read Support:                   supported
  Read Clock Frequency:                20MHz

Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Change-Id: Id0a0a0cbd948ef8334cf522c09e881b464e87f0e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44819
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

util/ifdtool/ifdtool.c

diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index 56e05fe..9f507bb 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -448,7 +448,7 @@
 	printf("Wrote layout to %s\n", layout_fname);
 }
 
-static void decode_spi_frequency(unsigned int freq)
+static void _decode_spi_frequency(unsigned int freq)
 {
 	switch (freq) {
 	case SPI_FREQUENCY_20MHZ:
@@ -478,6 +478,37 @@
 	}
 }
 
+static void _decode_spi_frequency_500_series(unsigned int freq)
+{
+	switch (freq) {
+	case SPI_FREQUENCY_100MHZ:
+		printf("100MHz");
+		break;
+	case SPI_FREQUENCY_50MHZ:
+		printf("50MHz");
+		break;
+	case SPI_FREQUENCY_500SERIES_33MHZ:
+		printf("33MHz");
+		break;
+	case SPI_FREQUENCY_25MHZ:
+		printf("25MHz");
+		break;
+	case SPI_FREQUENCY_14MHZ:
+		printf("14MHz");
+		break;
+	default:
+		printf("unknown<%x>MHz", freq);
+	}
+}
+
+static void decode_spi_frequency(unsigned int freq)
+{
+	if (chipset == CHIPSET_500_SERIES_TIGER_POINT)
+		_decode_spi_frequency_500_series(freq);
+	else
+		_decode_spi_frequency(freq);
+}
+
 static void decode_component_density(unsigned int density)
 {
 	switch (density) {