commit cd91db953ca254e0a03640fdc597dae6b616e155
author Pandya, Varshit B <varshit.b.pandya@intel.com> Thu Sep 03 20:38:46 2020 +0530
committer Patrick Georgi <pgeorgi@google.com> Wed Sep 16 07:16:09 2020 +0000
tree 997da257d6887c11774dcc25494dbe99180750a4
parent c410542007381ff968ad8af8dca7c369a3c9b938

drivers/intel/mipi_camera: Add compatible field for NVM

Add compatible field for NVM
Make PRP0001 as default HID if device type is INTEL_ACPI_CAMERA_NVM

Signed-off-by: Pandya, Varshit B <varshit.b.pandya@intel.com>
Change-Id: Iad7afa7b3170982eb5d6215e766f3e98f7a89213
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45091
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Rizwan Qureshi <rizwan.qureshi@intel.com>

src/drivers/intel/mipi_camera/camera.c

diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c
index 6f237a9..fed0ff6 100644
--- a/src/drivers/intel/mipi_camera/camera.c
+++ b/src/drivers/intel/mipi_camera/camera.c
@@ -454,6 +454,9 @@
 	struct drivers_intel_mipi_camera_config *config = dev->chip_info;
 	struct acpi_dp *dsd = acpi_dp_new_table("_DSD");
 
+	if (!config->nvm_compat)
+		return;
+
 	/* It might be possible to default size or width based on type. */
 	if (!config->disable_nvm_defaults && !config->nvm_pagesize)
 		config->nvm_pagesize = 1;
@@ -473,6 +476,7 @@
 	if (config->nvm_width)
 		acpi_dp_add_integer(dsd, "address-width", config->nvm_width);
 
+	acpi_dp_add_string(dsd, "compatible", config->nvm_compat);
 	acpi_dp_write(dsd);
 }
 
@@ -822,10 +826,9 @@
 
 	if (config->acpi_hid)
 		acpigen_write_name_string("_HID", config->acpi_hid);
-	else if (config->device_type == INTEL_ACPI_CAMERA_VCM)
+	else if (config->device_type == INTEL_ACPI_CAMERA_VCM ||
+		 config->device_type == INTEL_ACPI_CAMERA_NVM)
 		acpigen_write_name_string("_HID", ACPI_DT_NAMESPACE_HID);
-	else if (config->device_type == INTEL_ACPI_CAMERA_NVM)
-		acpigen_write_name_string("_HID", "INT3499");
 
 	acpigen_write_name_integer("_UID", config->acpi_uid);
 	acpigen_write_name_string("_DDN", config->chip_name);