ec/starlabs/merlin: Unconditionally enable the Keyboard Backlight
KBL_STATE was originally intended to provide more granular control
of the keyboard backlight. However, KBL_BRIGHTNESS has a valid value
of "off" which achieves the same thing.
Therefore, unconditionally set the KBL_STATE to enabled, and rely on
KBL_BRIGHTNESS.
Change-Id: Ic7ee6b96b1dcaa6633b111e92097bce87908885e
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77201
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/ec/starlabs/merlin/ite.c b/src/ec/starlabs/merlin/ite.c
index 9916bf0..d7ae168 100644
--- a/src/ec/starlabs/merlin/ite.c
+++ b/src/ec/starlabs/merlin/ite.c
@@ -295,17 +295,11 @@
* Values: Off, On
* Default: On
*
+ * Note: Always enable, as the brightness level of `off` disables it.
+ *
*/
- const uint8_t kbl_state[] = {
- KBL_DISABLED,
- KBL_ENABLED
- };
- ec_write(ECRAM_KBL_STATE,
- get_ec_value_from_option("kbl_state",
- 1,
- kbl_state,
- ARRAY_SIZE(kbl_state)));
+ ec_write(ECRAM_KBL_STATE, KBL_ENABLED);
}
static struct device_operations ops = {