commit c9cb8ff8fbc107c45a7583241032a401baa217f5
author Kapil Porwal <kapilporwal@google.com> Wed Nov 23 16:40:41 2022 +0530
committer Subrata Banik <subratabanik@google.com> Thu Nov 24 17:45:49 2022 +0000
tree bba7793f57a8ab7b27f693e804a348ec926b2ec2
parent 71e40782b87ff6964600fa642058ff24f9b05676

drivers/wwan/fm: Use correct GUID for DmaProperty in ACPI _DSD

Use correct GUID for DmaProperty in ACPI _DSD.

Reference:
https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports

Before:
Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
{
    ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
    Package (0x01)
    {
        Package (0x02)
        {
            "DmaProperty",
            One
        }
    }
})

After:
Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
{
    ToUUID ("70d24161-6dd5-4c9e-8070-705531292865"),
    Package (0x01)
    {
        Package (0x02)
        {
            "DmaProperty",
            One
        }
    }
})

BUG=b:259716145
TEST=Verified the new GUID is reflected in ACPI SSDT at runtime.

Signed-off-by: Kapil Porwal <kapilporwal@google.com>
Change-Id: I05b8c3bf23cc43863527bc514d9a96096d45003c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69932
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Tarun Tuli <taruntuli@google.com>

src/drivers/wwan/fm/acpi_fm350gl.c

diff --git a/src/drivers/wwan/fm/acpi_fm350gl.c b/src/drivers/wwan/fm/acpi_fm350gl.c
index dbc4f24..7ff8b2b 100644
--- a/src/drivers/wwan/fm/acpi_fm350gl.c
+++ b/src/drivers/wwan/fm/acpi_fm350gl.c
@@ -5,6 +5,9 @@
 #include "chip.h"
 #include "soc/intel/common/block/pcie/rtd3/chip.h"
 
+/* ID for the DmaProperty in _DSD */
+#define ACPI_DSD_DMA_PROPERTY_UUID "70D24161-6DD5-4C9E-8070-705531292865"
+
 /* FCPO# to RESET# delay time during WWAN ON */
 #define FM350GL_TN2B 20
 /* RESET# to PERST# delay time during WWAN ON */
@@ -243,9 +246,11 @@
 			wwan_fm350gl_acpi_method_dpts(parent, config);
 
 			if (config->add_acpi_dma_property) {
-				struct acpi_dp *dsd;
+				struct acpi_dp *dsd, *pkg;
 				dsd = acpi_dp_new_table("_DSD");
-				acpi_dp_add_integer(dsd, "DmaProperty", 1);
+				pkg = acpi_dp_new_table(ACPI_DSD_DMA_PROPERTY_UUID);
+				acpi_dp_add_integer(pkg, "DmaProperty", 1);
+				acpi_dp_add_package(dsd, pkg);
 				acpi_dp_write(dsd);
 			}