commit c8d24dd150a1922657d6ff396da8f11da24569f7
author Elyes HAOUAS <ehaouas@noos.fr> Wed Jun 15 21:13:07 2016 +0200
committer Martin Roth <martinroth@google.com> Fri Jun 24 18:09:18 2016 +0200
tree 9048279f90ed2bee50d10a87652f991974534da7
parent 46bfce335337a11a9b48c496672bd6020e8dbaeb

SPD: fix and add DDR2 SDRAM memory module types

Correct the definitions and add 72b-SO-CDIMM and 72b-SO-RDIMM

Change-Id: I33532e30f45f6c8c0eb6d47b0bea87689d2d9a1a
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/15204
Tested-by: build bot (Jenkins)
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>

src/include/spd.h

diff --git a/src/include/spd.h b/src/include/spd.h
index 7c4a2e3..69a45ff 100644
--- a/src/include/spd.h
+++ b/src/include/spd.h
@@ -26,7 +26,8 @@
  * Datasheet (alternative):
  *   - Name: SERIAL PRESENCE DETECT STANDARD, General Standard
  *           JEDEC Standard No. 21-C
- *   - PDF: http://www.jedec.org/download/search/4_01_02_00R9.PDF
+ *     Annex J: Serial Presence Detects for DDR2 SDRAM (Revision 1.3):
+ *   - PDF: http://www.jedec.org/download/search/4_01_02_10R17.pdf
  */
 
 #ifndef _SPD_H_
@@ -235,12 +236,15 @@
 #define RC62 62
 #define RC63 63
 
-#define SPD_UNDEFINED 0
-#define SPD_RDIMM 1
-#define SPD_UDIMM 2
-#define SPD_SODIMM 3
-#define SPD_MICRO_DIMM 4
-#define SPD_MINI_RDIMM 5
-#define SPD_MINI_UDIMM 6
+/* Byte 20: DIMM type information */
+#define SPD_UNDEFINED 0x00
+#define SPD_RDIMM 0x01
+#define SPD_UDIMM 0x02
+#define SPD_SODIMM 0x04
+#define SPD_72B_SO_CDIMM 0x06
+#define SPD_72B_SO_RDIMM 0x07
+#define SPD_MICRO_DIMM 0x08
+#define SPD_MINI_RDIMM 0x10
+#define SPD_MINI_UDIMM 0x20
 
 #endif