acpi: Be more ACPI compliant when generating _UID
* Add function to generate unique _UID using CRC32
* Add function to write the _UID based on a device's ACPI path
ACPI devices that have the same _HID must use different _UID.
Linux doesn't care about _UID if it's not used.
Windows 10 verifies the ACPI code on boot and BSODs if two devices
with the same _HID share the same _UID.
Fixes BSOD seen on Windows 10.
Change-Id: I47cd5396060d325f9ce338afced6af021e7ff2b4
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37695
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
diff --git a/src/drivers/crb/tis.c b/src/drivers/crb/tis.c
index f2aba48..b1fbad0 100644
--- a/src/drivers/crb/tis.c
+++ b/src/drivers/crb/tis.c
@@ -117,7 +117,7 @@
acpigen_write_name_string("_HID", "MSFT0101");
acpigen_write_name_string("_CID", "MSFT0101");
- acpigen_write_name_integer("_UID", 1);
+ acpi_device_write_uid(dev);
acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
diff --git a/src/drivers/net/r8168.c b/src/drivers/net/r8168.c
index bc0132f..1bca879 100644
--- a/src/drivers/net/r8168.c
+++ b/src/drivers/net/r8168.c
@@ -312,7 +312,8 @@
acpigen_write_scope(path);
acpigen_write_device(acpi_device_name(dev));
acpigen_write_name_string("_HID", R8168_ACPI_HID);
- acpigen_write_name_integer("_UID", 0);
+ acpi_device_write_uid(dev);
+
if (dev->chip_ops)
acpigen_write_name_string("_DDN", dev->chip_ops->name);
diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c
index e9f1485..a35ef83 100644
--- a/src/drivers/pc80/tpm/tis.c
+++ b/src/drivers/pc80/tpm/tis.c
@@ -902,7 +902,7 @@
acpigen_write_name("_CID");
acpigen_emit_eisaid("PNP0C31");
- acpigen_write_name_integer("_UID", 1);
+ acpi_device_write_uid(dev);
u32 did_vid = tpm_read_did_vid(0);
if (did_vid > 0 && did_vid < 0xffffffff)
diff --git a/src/drivers/wifi/generic.c b/src/drivers/wifi/generic.c
index 9f9f4fa..fe2e39d 100644
--- a/src/drivers/wifi/generic.c
+++ b/src/drivers/wifi/generic.c
@@ -187,7 +187,8 @@
/* Device */
acpigen_write_scope(path);
acpigen_write_device(acpi_device_name(dev));
- acpigen_write_name_integer("_UID", 0);
+ acpi_device_write_uid(dev);
+
if (dev->chip_ops)
acpigen_write_name_string("_DDN", dev->chip_ops->name);