commit c65113cec7c628ab55f71114db5b13b2f2967db4
author Uwe Hermann <uwe@hermann-uwe.de> Tue Nov 07 11:16:21 2006 +0000
committer Uwe Hermann <uwe@hermann-uwe.de> Tue Nov 07 11:16:21 2006 +0000
tree b562a7027d17ee2039a86260b4c2d9574694247a
parent 10fd79ae81fc97bded227ec587acfcdc895539db

Fix some code comments of the Intel PIIX4/PIIX4E/PIIX4M code.
Add detailed instructions on how and where to get the datasheet,
its name, and order number (Closes #34).

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> 
Acked-by: Stefan Reinauer <stepan@coresystems.de>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2493 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

util/flashrom/flash_enable.c

diff --git a/util/flashrom/flash_enable.c b/util/flashrom/flash_enable.c
index dd53f0e..901144c 100644
--- a/util/flashrom/flash_enable.c
+++ b/util/flashrom/flash_enable.c
@@ -77,7 +77,12 @@
 	return 0;
 }
 
-/* Datasheet: http://www.intel.com/design/intarch/datashts/290562.htm */
+/* Datasheet:
+ *   - Name: 82371AB PCI-TO-ISA / IDE XCELERATOR (PIIX4)
+ *   - URL: http://www.intel.com/design/intarch/datashts/290562.htm
+ *   - PDF: http://www.intel.com/design/intarch/datashts/29056201.pdf
+ *   - Order Number: 290562-001
+ */
 static int enable_flash_piix4(struct pci_dev *dev, char *name)
 {
 	uint16_t old, new;
@@ -90,10 +95,11 @@
            Set bit 7: Extended BIOS Enable (PCI master accesses to
                       FFF80000-FFFDFFFF are forwarded to ISA).
            Set bit 6: Lower BIOS Enable (PCI master, or ISA master accesses to
-                      the lower 64-Kbyte BIOS block (E00000­EFFFF) at the top
+                      the lower 64-Kbyte BIOS block (E0000-EFFFF) at the top
                       of 1 Mbyte, or the aliases at the top of 4 Gbyte
-                      (FFFE0000-FFFEFFF) result in the generation of BIOSCS#.
-           Set bit 2: BIOSCS# Write Protect Enable (1=enable, 0=disable). */
+                      (FFFE0000-FFFEFFFF) result in the generation of BIOSCS#.
+           Note: Accesses to FFFF0000-FFFFFFFF are always forwarded to ISA.
+           Set bit 2: BIOSCS# Write Enable (1=enable, 0=disable). */
 	new = old | 0x2c4;
 
 	if (new == old)