commit | c37e1e6d071cc9c64e99cffa4250e912f70e6ef0 | [log] [tgz] |
---|---|---|
author | Karthikeyan Ramasubramanian <kramasub@google.com> | Tue Nov 10 14:54:40 2020 -0700 |
committer | Tim Wawrzynczak <twawrzynczak@chromium.org> | Fri Nov 13 01:28:33 2020 +0000 |
tree | ad6353da82383086941f2a62b69b07c2b2f8cea0 | |
parent | b2f2bd1c82fb0b393d44c1672041e621cfeaf435 [diff] [blame] |
mb/google/poppy: Configure IRQs as level triggered for HID over I2C As per HID over I2C Protocol Specification[1] Version 1.00 Section 7.4, the interrupt line used by the device is required to be level triggered. Hence, this change updates the configuration of the HID over I2C devices to be level triggered. References: [1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d96d5b/hid-over-i2c-protocol-spec-v1-0.docx BUG=b:172846122 TEST=./util/abuild/abuild Change-Id: Ida1b1d05b39e67a9eba3bfaecca37f38821a438b Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47423 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 3797fb0..668e72d 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
@@ -292,7 +292,7 @@ chip drivers/i2c/hid register "generic.hid" = ""ACPI0C50"" register "generic.desc" = ""ELAN Touchpad"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A19_IRQ)" register "generic.wake" = "GPE0_DW0_23" # GPP_A23 register "hid_desc_reg_offset" = "0x01" device i2c 0x15 on end