commit c2f1202151208a35dea7c5fec1de2192752ff900
author Elyes HAOUAS <ehaouas@noos.fr> Fri Jan 07 19:05:11 2022 +0100
committer Felix Singer <felixsinger@posteo.net> Sun Jul 17 18:54:31 2022 +0000
tree ceb2baf7c9c59fbec66c9b5c683b16be7435db86
parent 55be012ffdc79a259c6c180e58a6e24c744119f7

security/intel/txt/common.c: Remove unuseful "else" after "return"

"else" is unuseful after a "break" or "return".

Change-Id: I7273b9af46a2310c9981ffd20afe2c8c7e061479
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60910
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>

src/security/intel/txt/common.c

diff --git a/src/security/intel/txt/common.c b/src/security/intel/txt/common.c
index ea348d2..b88062d 100644
--- a/src/security/intel/txt/common.c
+++ b/src/security/intel/txt/common.c
@@ -489,15 +489,14 @@
 		failure = true;
 	}
 
-	if (!getsec_parameter(NULL, NULL, NULL, NULL, NULL, &txt_feature_flags)) {
+	if (!getsec_parameter(NULL, NULL, NULL, NULL, NULL, &txt_feature_flags))
 		return true;
-	} else {
-		printk(BIOS_DEBUG, "TEE-TXT: Machine Check Register: ");
-		if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK)
-			printk(BIOS_DEBUG, "preserved\n");
-		else
-			printk(BIOS_DEBUG, "must be clear\n");
-	}
+
+	printk(BIOS_DEBUG, "TEE-TXT: Machine Check Register: ");
+	if (txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK)
+		printk(BIOS_DEBUG, "preserved\n");
+	else
+		printk(BIOS_DEBUG, "must be clear\n");
 
 	if (!(txt_feature_flags & GETSEC_PARAMS_TXT_EXT_MACHINE_CHECK)) {
 		/*