include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
diff --git a/src/superio/smsc/fdc37n972/superio.c b/src/superio/smsc/fdc37n972/superio.c
index a62bba8..ba197d8 100644
--- a/src/superio/smsc/fdc37n972/superio.c
+++ b/src/superio/smsc/fdc37n972/superio.c
@@ -46,6 +46,6 @@
}
struct chip_operations superio_smsc_fdc37n972_ops = {
- CHIP_NAME("SMSC FDC37N972 Super I/O")
+ .name = "SMSC FDC37N972 Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/smsc/kbc1100/superio.c b/src/superio/smsc/kbc1100/superio.c
index 862a77b..74f2326 100644
--- a/src/superio/smsc/kbc1100/superio.c
+++ b/src/superio/smsc/kbc1100/superio.c
@@ -14,7 +14,7 @@
static void kbc1100_init(struct device *dev);
struct chip_operations superio_smsc_kbc1100_ops = {
- CHIP_NAME("SMSC KBC1100 Super I/O")
+ .name = "SMSC KBC1100 Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/smsc/lpc47m10x/superio.c b/src/superio/smsc/lpc47m10x/superio.c
index cb297a5..157275e 100644
--- a/src/superio/smsc/lpc47m10x/superio.c
+++ b/src/superio/smsc/lpc47m10x/superio.c
@@ -58,6 +58,6 @@
}
struct chip_operations superio_smsc_lpc47m10x_ops = {
- CHIP_NAME("SMSC LPC47M10x Super I/O")
+ .name = "SMSC LPC47M10x Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/smsc/lpc47m15x/superio.c b/src/superio/smsc/lpc47m15x/superio.c
index e1e4883..6f57133 100644
--- a/src/superio/smsc/lpc47m15x/superio.c
+++ b/src/superio/smsc/lpc47m15x/superio.c
@@ -14,7 +14,7 @@
static void lpc47m15x_init(struct device *dev);
struct chip_operations superio_smsc_lpc47m15x_ops = {
- CHIP_NAME("SMSC LPC47M15x/192/997 Super I/O")
+ .name = "SMSC LPC47M15x/192/997 Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/smsc/lpc47n217/superio.c b/src/superio/smsc/lpc47n217/superio.c
index dcaf6e7..c59ce2d 100644
--- a/src/superio/smsc/lpc47n217/superio.c
+++ b/src/superio/smsc/lpc47n217/superio.c
@@ -25,7 +25,7 @@
static void pnp_exit_conf_state(struct device *dev);
struct chip_operations superio_smsc_lpc47n217_ops = {
- CHIP_NAME("SMSC LPC47N217 Super I/O")
+ .name = "SMSC LPC47N217 Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/smsc/lpc47n227/superio.c b/src/superio/smsc/lpc47n227/superio.c
index 3712350..edcc271 100644
--- a/src/superio/smsc/lpc47n227/superio.c
+++ b/src/superio/smsc/lpc47n227/superio.c
@@ -24,7 +24,7 @@
void lpc47n227_pnp_set_enable(struct device *dev, int enable);
struct chip_operations superio_smsc_lpc47n227_ops = {
- CHIP_NAME("SMSC LPC47N227 Super I/O")
+ .name = "SMSC LPC47N227 Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/smsc/mec1308/superio.c b/src/superio/smsc/mec1308/superio.c
index 6c8597c..39e100e 100644
--- a/src/superio/smsc/mec1308/superio.c
+++ b/src/superio/smsc/mec1308/superio.c
@@ -47,6 +47,6 @@
}
struct chip_operations superio_smsc_mec1308_ops = {
- CHIP_NAME("SMSC MEC1308 EC SuperIO Interface")
+ .name = "SMSC MEC1308 EC SuperIO Interface",
.enable_dev = enable_dev
};
diff --git a/src/superio/smsc/sch5545/superio.c b/src/superio/smsc/sch5545/superio.c
index 1ce1fd6..7b8e5a0 100644
--- a/src/superio/smsc/sch5545/superio.c
+++ b/src/superio/smsc/sch5545/superio.c
@@ -303,6 +303,6 @@
}
struct chip_operations superio_smsc_sch5545_ops = {
- CHIP_NAME("SMSC SCH5545 Super I/O")
+ .name = "SMSC SCH5545 Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/smsc/sch555x/ramstage.c b/src/superio/smsc/sch555x/ramstage.c
index 2245001..1cdd869 100644
--- a/src/superio/smsc/sch555x/ramstage.c
+++ b/src/superio/smsc/sch555x/ramstage.c
@@ -136,6 +136,6 @@
}
struct chip_operations superio_smsc_sch555x_ops = {
- CHIP_NAME("SMSC SCH555x Super I/O")
+ .name = "SMSC SCH555x Super I/O",
.enable_dev = sch555x_enable_dev,
};
diff --git a/src/superio/smsc/sio1036/superio.c b/src/superio/smsc/sio1036/superio.c
index 3dcaae8..8b1704f 100644
--- a/src/superio/smsc/sio1036/superio.c
+++ b/src/superio/smsc/sio1036/superio.c
@@ -33,6 +33,6 @@
}
struct chip_operations superio_smsc_sio1036_ops = {
- CHIP_NAME("SMSC SIO1036 Super I/O")
+ .name = "SMSC SIO1036 Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/smsc/sio10n268/superio.c b/src/superio/smsc/sio10n268/superio.c
index ca5a0c6..fa79a57 100644
--- a/src/superio/smsc/sio10n268/superio.c
+++ b/src/superio/smsc/sio10n268/superio.c
@@ -43,6 +43,6 @@
}
struct chip_operations superio_smsc_sio10n268_ops = {
- CHIP_NAME("SMSC SIO10N268 Super I/O")
+ .name = "SMSC SIO10N268 Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/smsc/smscsuperio/superio.c b/src/superio/smsc/smscsuperio/superio.c
index a182d90..3ba8216 100644
--- a/src/superio/smsc/smscsuperio/superio.c
+++ b/src/superio/smsc/smscsuperio/superio.c
@@ -281,6 +281,6 @@
}
struct chip_operations superio_smsc_smscsuperio_ops = {
- CHIP_NAME("Various SMSC Super I/Os")
+ .name = "Various SMSC Super I/Os",
.enable_dev = enable_dev
};