include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
diff --git a/src/superio/nuvoton/nct5104d/superio.c b/src/superio/nuvoton/nct5104d/superio.c
index cfa2228..3353369 100644
--- a/src/superio/nuvoton/nct5104d/superio.c
+++ b/src/superio/nuvoton/nct5104d/superio.c
@@ -232,6 +232,6 @@
}
struct chip_operations superio_nuvoton_nct5104d_ops = {
- CHIP_NAME("Nuvoton NCT5104D Super I/O")
+ .name = "Nuvoton NCT5104D Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/nuvoton/nct5539d/superio.c b/src/superio/nuvoton/nct5539d/superio.c
index ff37f5c..cef40a5 100644
--- a/src/superio/nuvoton/nct5539d/superio.c
+++ b/src/superio/nuvoton/nct5539d/superio.c
@@ -95,6 +95,6 @@
}
struct chip_operations superio_nuvoton_nct5539d_ops = {
- CHIP_NAME("NUVOTON NCT5539D Super I/O")
+ .name = "NUVOTON NCT5539D Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/nuvoton/nct5572d/superio.c b/src/superio/nuvoton/nct5572d/superio.c
index 7e893ee..34fa016 100644
--- a/src/superio/nuvoton/nct5572d/superio.c
+++ b/src/superio/nuvoton/nct5572d/superio.c
@@ -104,6 +104,6 @@
}
struct chip_operations superio_nuvoton_nct5572d_ops = {
- CHIP_NAME("NUVOTON NCT5572D Super I/O")
+ .name = "NUVOTON NCT5572D Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/nuvoton/nct6687d/superio.c b/src/superio/nuvoton/nct6687d/superio.c
index a2eea8c..c280927 100644
--- a/src/superio/nuvoton/nct6687d/superio.c
+++ b/src/superio/nuvoton/nct6687d/superio.c
@@ -87,6 +87,6 @@
}
struct chip_operations superio_nuvoton_nct6687d_ops = {
- CHIP_NAME("NUVOTON NCT6687D Super I/O")
+ .name = "NUVOTON NCT6687D Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/nuvoton/nct6776/superio.c b/src/superio/nuvoton/nct6776/superio.c
index 4197d54..d98e303 100644
--- a/src/superio/nuvoton/nct6776/superio.c
+++ b/src/superio/nuvoton/nct6776/superio.c
@@ -67,6 +67,6 @@
}
struct chip_operations superio_nuvoton_nct6776_ops = {
- CHIP_NAME("NUVOTON NCT6776 Super I/O")
+ .name = "NUVOTON NCT6776 Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/nuvoton/nct6779d/superio.c b/src/superio/nuvoton/nct6779d/superio.c
index 77058b0..1360476 100644
--- a/src/superio/nuvoton/nct6779d/superio.c
+++ b/src/superio/nuvoton/nct6779d/superio.c
@@ -62,6 +62,6 @@
}
struct chip_operations superio_nuvoton_nct6779d_ops = {
- CHIP_NAME("NUVOTON NCT6779D Super I/O")
+ .name = "NUVOTON NCT6779D Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/nuvoton/nct6791d/superio.c b/src/superio/nuvoton/nct6791d/superio.c
index 3244e05..91a3908 100644
--- a/src/superio/nuvoton/nct6791d/superio.c
+++ b/src/superio/nuvoton/nct6791d/superio.c
@@ -102,6 +102,6 @@
}
struct chip_operations superio_nuvoton_nct6791d_ops = {
- CHIP_NAME("NUVOTON NCT6791D Super I/O")
+ .name = "NUVOTON NCT6791D Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/nuvoton/npcd378/superio.c b/src/superio/nuvoton/npcd378/superio.c
index 615bae5..a4759fb 100644
--- a/src/superio/nuvoton/npcd378/superio.c
+++ b/src/superio/nuvoton/npcd378/superio.c
@@ -460,6 +460,6 @@
}
struct chip_operations superio_nuvoton_npcd378_ops = {
- CHIP_NAME("NUVOTON NPCD378 Super I/O")
+ .name = "NUVOTON NPCD378 Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/nuvoton/wpcm450/superio.c b/src/superio/nuvoton/wpcm450/superio.c
index 45c2e93..863ad2b 100644
--- a/src/superio/nuvoton/wpcm450/superio.c
+++ b/src/superio/nuvoton/wpcm450/superio.c
@@ -40,6 +40,6 @@
}
struct chip_operations superio_nuvoton_wpcm450_ops = {
- CHIP_NAME("Nuvoton WPCM450 Super I/O")
+ .name = "Nuvoton WPCM450 Super I/O",
.enable_dev = enable_dev,
};