include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
diff --git a/src/superio/ite/it8528e/superio.c b/src/superio/ite/it8528e/superio.c
index d135c0b..97d8850 100644
--- a/src/superio/ite/it8528e/superio.c
+++ b/src/superio/ite/it8528e/superio.c
@@ -49,6 +49,6 @@
}
struct chip_operations superio_ite_it8528e_ops = {
- CHIP_NAME("ITE IT8528E Super I/O")
+ .name = "ITE IT8528E Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8613e/superio.c b/src/superio/ite/it8613e/superio.c
index c18c3ec..78241b2 100644
--- a/src/superio/ite/it8613e/superio.c
+++ b/src/superio/ite/it8613e/superio.c
@@ -63,6 +63,6 @@
}
struct chip_operations superio_ite_it8613e_ops = {
- CHIP_NAME("ITE IT8613E Super I/O")
+ .name = "ITE IT8613E Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8623e/superio.c b/src/superio/ite/it8623e/superio.c
index 15e0071..7800a34 100644
--- a/src/superio/ite/it8623e/superio.c
+++ b/src/superio/ite/it8623e/superio.c
@@ -60,6 +60,6 @@
}
struct chip_operations superio_ite_it8623e_ops = {
- CHIP_NAME("ITE IT8623E Super I/O")
+ .name = "ITE IT8623E Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8712f/superio.c b/src/superio/ite/it8712f/superio.c
index 17a1976..03127b5 100644
--- a/src/superio/ite/it8712f/superio.c
+++ b/src/superio/ite/it8712f/superio.c
@@ -65,6 +65,6 @@
}
struct chip_operations superio_ite_it8712f_ops = {
- CHIP_NAME("ITE IT8712F Super I/O")
+ .name = "ITE IT8712F Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8718f/superio.c b/src/superio/ite/it8718f/superio.c
index 1243e75..fafe30d 100644
--- a/src/superio/ite/it8718f/superio.c
+++ b/src/superio/ite/it8718f/superio.c
@@ -71,6 +71,6 @@
}
struct chip_operations superio_ite_it8718f_ops = {
- CHIP_NAME("ITE IT8718F Super I/O")
+ .name = "ITE IT8718F Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8720f/superio.c b/src/superio/ite/it8720f/superio.c
index 75d0be9..4491c10 100644
--- a/src/superio/ite/it8720f/superio.c
+++ b/src/superio/ite/it8720f/superio.c
@@ -112,6 +112,6 @@
}
struct chip_operations superio_ite_it8720f_ops = {
- CHIP_NAME("ITE IT8720F Super I/O")
+ .name = "ITE IT8720F Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8721f/superio.c b/src/superio/ite/it8721f/superio.c
index f69e1b0..801e27b 100644
--- a/src/superio/ite/it8721f/superio.c
+++ b/src/superio/ite/it8721f/superio.c
@@ -63,6 +63,6 @@
}
struct chip_operations superio_ite_it8721f_ops = {
- CHIP_NAME("ITE IT8721F Super I/O")
+ .name = "ITE IT8721F Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8728f/superio.c b/src/superio/ite/it8728f/superio.c
index 67ef218..5e4c2fd 100644
--- a/src/superio/ite/it8728f/superio.c
+++ b/src/superio/ite/it8728f/superio.c
@@ -60,6 +60,6 @@
}
struct chip_operations superio_ite_it8728f_ops = {
- CHIP_NAME("ITE IT8728F Super I/O")
+ .name = "ITE IT8728F Super I/O",
.enable_dev = enable_dev
};
diff --git a/src/superio/ite/it8772f/superio.c b/src/superio/ite/it8772f/superio.c
index 82f30fa..1771368 100644
--- a/src/superio/ite/it8772f/superio.c
+++ b/src/superio/ite/it8772f/superio.c
@@ -268,6 +268,6 @@
}
struct chip_operations superio_ite_it8772f_ops = {
- CHIP_NAME("ITE IT8772F Super I/O")
+ .name = "ITE IT8772F Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8783ef/superio.c b/src/superio/ite/it8783ef/superio.c
index d90ae5f..618ea3f 100644
--- a/src/superio/ite/it8783ef/superio.c
+++ b/src/superio/ite/it8783ef/superio.c
@@ -88,6 +88,6 @@
}
struct chip_operations superio_ite_it8783ef_ops = {
- CHIP_NAME("ITE IT8783E/F Super I/O")
+ .name = "ITE IT8783E/F Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8784e/superio.c b/src/superio/ite/it8784e/superio.c
index 85fc42e..1caa837 100644
--- a/src/superio/ite/it8784e/superio.c
+++ b/src/superio/ite/it8784e/superio.c
@@ -82,6 +82,6 @@
}
struct chip_operations superio_ite_it8784e_ops = {
- CHIP_NAME("ITE IT8784E Super I/O")
+ .name = "ITE IT8784E Super I/O",
.enable_dev = enable_dev,
};
diff --git a/src/superio/ite/it8786e/superio.c b/src/superio/ite/it8786e/superio.c
index 8d9ec14..f610fdf 100644
--- a/src/superio/ite/it8786e/superio.c
+++ b/src/superio/ite/it8786e/superio.c
@@ -98,6 +98,6 @@
}
struct chip_operations superio_ite_it8786e_ops = {
- CHIP_NAME("ITE IT8786E Super I/O")
+ .name = "ITE IT8786E Super I/O",
.enable_dev = enable_dev,
};