commit bfb11bec3b3fec638adf864a9b9b2cff6671fed8
author Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Tue Jan 30 09:53:46 2024 +0900
committer Felix Singer <service+coreboot-gerrit@felixsinger.de> Wed Jan 31 09:51:58 2024 +0000
tree 0247c385cfbd79aa8496b1ddc3c3afcce1465616
parent f4c496d3e3e779b3d870d13e1e359a3b5f7087cb

include/device/device.h: Remove CHIP_NAME() macro

Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:

CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,

This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.

It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.

Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>

src/ec/google/chromeec/audio_codec/audio_codec.c

diff --git a/src/ec/google/chromeec/audio_codec/audio_codec.c b/src/ec/google/chromeec/audio_codec/audio_codec.c
index 53037eb..a8def98 100644
--- a/src/ec/google/chromeec/audio_codec/audio_codec.c
+++ b/src/ec/google/chromeec/audio_codec/audio_codec.c
@@ -59,6 +59,6 @@
 }
 
 struct chip_operations ec_google_chromeec_audio_codec_ops = {
-	CHIP_NAME("CrosEC Audio Codec Device")
+	.name = "CrosEC Audio Codec Device",
 	.enable_dev = crosec_audio_codec_enable
 };

src/ec/google/chromeec/ec_lpc.c

diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c
index 080b95d..2a9eabb 100644
--- a/src/ec/google/chromeec/ec_lpc.c
+++ b/src/ec/google/chromeec/ec_lpc.c
@@ -451,7 +451,7 @@
 }
 
 struct chip_operations ec_google_chromeec_ops = {
-	CHIP_NAME("Google Chrome EC")
+	.name = "Google Chrome EC",
 	.enable_dev = enable_dev,
 };
 

src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c

diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c
index e61ecfd8..64812d4 100644
--- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c
+++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c
@@ -65,6 +65,6 @@
 }
 
 struct chip_operations ec_google_chromeec_i2c_tunnel_ops = {
-	CHIP_NAME("CrosEC I2C Tunnel Device")
+	.name = "CrosEC I2C Tunnel Device",
 	.enable_dev = crosec_i2c_tunnel_enable
 };

src/ec/google/chromeec/mux/conn/conn.c

diff --git a/src/ec/google/chromeec/mux/conn/conn.c b/src/ec/google/chromeec/mux/conn/conn.c
index e179c33..bb3129b 100644
--- a/src/ec/google/chromeec/mux/conn/conn.c
+++ b/src/ec/google/chromeec/mux/conn/conn.c
@@ -52,6 +52,6 @@
 }
 
 struct chip_operations ec_google_chromeec_mux_conn_ops = {
-	CHIP_NAME("CrosEC Type C Mux device")
+	.name = "CrosEC Type C Mux device",
 	.enable_dev	= conn_enable,
 };

src/ec/google/chromeec/mux/mux.c

diff --git a/src/ec/google/chromeec/mux/mux.c b/src/ec/google/chromeec/mux/mux.c
index 9324d2e..62be238 100644
--- a/src/ec/google/chromeec/mux/mux.c
+++ b/src/ec/google/chromeec/mux/mux.c
@@ -36,6 +36,6 @@
 }
 
 struct chip_operations ec_google_chromeec_mux_ops = {
-	CHIP_NAME("CrosEC Type C Mux device")
+	.name = "CrosEC Type C Mux device",
 	.enable_dev = mux_enable
 };