include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c
index 71a4ec3..bceb0de 100644
--- a/src/drivers/intel/dptf/dptf.c
+++ b/src/drivers/intel/dptf/dptf.c
@@ -636,6 +636,6 @@
}
struct chip_operations drivers_intel_dptf_ops = {
- CHIP_NAME("Intel DPTF")
+ .name = "Intel DPTF",
.enable_dev = dptf_enable_dev,
};
diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c
index 9711632..6dba46a 100644
--- a/src/drivers/intel/ish/ish.c
+++ b/src/drivers/intel/ish/ish.c
@@ -97,6 +97,6 @@
};
struct chip_operations drivers_intel_ish_ops = {
- CHIP_NAME("Intel ISH Chip")
+ .name = "Intel ISH Chip",
.enable_dev = intel_ish_enable,
};
diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c
index 00c85a7..77c86ea 100644
--- a/src/drivers/intel/mipi_camera/camera.c
+++ b/src/drivers/intel/mipi_camera/camera.c
@@ -1033,6 +1033,6 @@
}
struct chip_operations drivers_intel_mipi_camera_ops = {
- CHIP_NAME("Intel MIPI Camera Device")
+ .name = "Intel MIPI Camera Device",
.enable_dev = camera_enable
};
diff --git a/src/drivers/intel/pmc_mux/conn/conn.c b/src/drivers/intel/pmc_mux/conn/conn.c
index de8f2be..c2c7199 100644
--- a/src/drivers/intel/pmc_mux/conn/conn.c
+++ b/src/drivers/intel/pmc_mux/conn/conn.c
@@ -153,7 +153,7 @@
}
struct chip_operations drivers_intel_pmc_mux_conn_ops = {
- CHIP_NAME("Intel PMC MUX CONN Driver")
+ .name = "Intel PMC MUX CONN Driver",
.enable_dev = conn_enable,
};
diff --git a/src/drivers/intel/pmc_mux/mux.c b/src/drivers/intel/pmc_mux/mux.c
index e209915..64669f6 100644
--- a/src/drivers/intel/pmc_mux/mux.c
+++ b/src/drivers/intel/pmc_mux/mux.c
@@ -43,6 +43,6 @@
}
struct chip_operations drivers_intel_pmc_mux_ops = {
- CHIP_NAME("Intel PMC MUX Driver")
+ .name = "Intel PMC MUX Driver",
.enable_dev = mux_enable,
};
diff --git a/src/drivers/intel/soundwire/soundwire.c b/src/drivers/intel/soundwire/soundwire.c
index c7e84a5..f9421fc 100644
--- a/src/drivers/intel/soundwire/soundwire.c
+++ b/src/drivers/intel/soundwire/soundwire.c
@@ -94,6 +94,6 @@
}
struct chip_operations drivers_intel_soundwire_ops = {
- CHIP_NAME("Intel SoundWire Controller")
+ .name = "Intel SoundWire Controller",
.enable_dev = intel_soundwire_enable
};
diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c
index 7fb600d..9704139 100644
--- a/src/drivers/intel/usb4/retimer/retimer.c
+++ b/src/drivers/intel/usb4/retimer/retimer.c
@@ -460,7 +460,7 @@
}
struct chip_operations drivers_intel_usb4_retimer_ops = {
- CHIP_NAME("Intel USB4 Retimer")
+ .name = "Intel USB4 Retimer",
.enable_dev = usb4_retimer_enable
};