include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
diff --git a/src/drivers/generic/adau7002/adau7002.c b/src/drivers/generic/adau7002/adau7002.c
index 63510cd..5917f69 100644
--- a/src/drivers/generic/adau7002/adau7002.c
+++ b/src/drivers/generic/adau7002/adau7002.c
@@ -67,6 +67,6 @@
}
struct chip_operations drivers_generic_adau7002_ops = {
- CHIP_NAME("Analog Digital DMIC")
+ .name = "Analog Digital DMIC",
.enable_dev = adau7002_enable
};
diff --git a/src/drivers/generic/alc1015/alc1015.c b/src/drivers/generic/alc1015/alc1015.c
index ca685d6..7245f0c 100644
--- a/src/drivers/generic/alc1015/alc1015.c
+++ b/src/drivers/generic/alc1015/alc1015.c
@@ -70,6 +70,6 @@
}
struct chip_operations drivers_generic_alc1015_ops = {
- CHIP_NAME("ASoC RT1015P Amplifier driver")
+ .name = "ASoC RT1015P Amplifier driver",
.enable_dev = alc1015_enable
};
diff --git a/src/drivers/generic/bayhub/bh720.c b/src/drivers/generic/bayhub/bh720.c
index 02abc22..5104c35 100644
--- a/src/drivers/generic/bayhub/bh720.c
+++ b/src/drivers/generic/bayhub/bh720.c
@@ -166,5 +166,5 @@
};
struct chip_operations drivers_generic_bayhub_ops = {
- CHIP_NAME("BayHub Technology BH720 PCI to eMMC 5.0 HS200 bridge")
+ .name = "BayHub Technology BH720 PCI to eMMC 5.0 HS200 bridge",
};
diff --git a/src/drivers/generic/bayhub_lv2/lv2.c b/src/drivers/generic/bayhub_lv2/lv2.c
index b8d4113..b2b85e1 100644
--- a/src/drivers/generic/bayhub_lv2/lv2.c
+++ b/src/drivers/generic/bayhub_lv2/lv2.c
@@ -81,5 +81,5 @@
};
struct chip_operations drivers_generic_bayhub_lv2_ops = {
- CHIP_NAME("BayHub Technology LV2 PCIe to SD bridge")
+ .name = "BayHub Technology LV2 PCIe to SD bridge",
};
diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c
index c0fd8de..28e5be5 100644
--- a/src/drivers/generic/gpio_keys/gpio_keys.c
+++ b/src/drivers/generic/gpio_keys/gpio_keys.c
@@ -120,6 +120,6 @@
}
struct chip_operations drivers_generic_gpio_keys_ops = {
- CHIP_NAME("GPIO Keys")
+ .name = "GPIO Keys",
.enable_dev = gpio_keys_enable
};
diff --git a/src/drivers/generic/max98357a/max98357a.c b/src/drivers/generic/max98357a/max98357a.c
index 7a18b98..8ce80f1 100644
--- a/src/drivers/generic/max98357a/max98357a.c
+++ b/src/drivers/generic/max98357a/max98357a.c
@@ -93,6 +93,6 @@
}
struct chip_operations drivers_generic_max98357a_ops = {
- CHIP_NAME("Maxim Integrated 98357A Amplifier")
+ .name = "Maxim Integrated 98357A Amplifier",
.enable_dev = max98357a_enable
};
diff --git a/src/drivers/generic/nau8315/nau8315.c b/src/drivers/generic/nau8315/nau8315.c
index ac2bfd1..8fe4e1f 100644
--- a/src/drivers/generic/nau8315/nau8315.c
+++ b/src/drivers/generic/nau8315/nau8315.c
@@ -71,6 +71,6 @@
}
struct chip_operations drivers_generic_nau8315_ops = {
- CHIP_NAME("Nuvoton NAU8315 Amplifier")
+ .name = "Nuvoton NAU8315 Amplifier",
.enable_dev = nau8315_enable
};