include/device/device.h: Remove CHIP_NAME() macro
Macros can be confusing on their own; hiding commas make things worse.
This can sometimes be downright misleading. A "good" example would be
the code in soc/intel/xeon_sp/spr/chip.c:
CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev,
This appears as CHIP_NAME() being some struct when in fact these are
defining 2 separate members of the same struct.
It was decided to remove this macro altogether, as it does not do
anything special and incurs a maintenance burden.
Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239
Reviewed-by: Yidi Lin <yidilin@google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Reviewed-by: Jakub Czapiga <czapiga@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
diff --git a/src/cpu/amd/pi/00730F01/chip_name.c b/src/cpu/amd/pi/00730F01/chip_name.c
index d5955cc..592fcc0 100644
--- a/src/cpu/amd/pi/00730F01/chip_name.c
+++ b/src/cpu/amd/pi/00730F01/chip_name.c
@@ -3,5 +3,5 @@
#include <device/device.h>
struct chip_operations cpu_amd_pi_00730F01_ops = {
- CHIP_NAME("AMD CPU Family 16h Model 30h-3Fh")
+ .name = "AMD CPU Family 16h Model 30h-3Fh",
};
diff --git a/src/cpu/intel/haswell/acpi.c b/src/cpu/intel/haswell/acpi.c
index 3727d8a..c8f6a07 100644
--- a/src/cpu/intel/haswell/acpi.c
+++ b/src/cpu/intel/haswell/acpi.c
@@ -364,5 +364,5 @@
}
struct chip_operations cpu_intel_haswell_ops = {
- CHIP_NAME("Intel Haswell CPU")
+ .name = "Intel Haswell CPU",
};
diff --git a/src/cpu/intel/model_1067x/model_1067x_init.c b/src/cpu/intel/model_1067x/model_1067x_init.c
index 315e7c3..c2019ab 100644
--- a/src/cpu/intel/model_1067x/model_1067x_init.c
+++ b/src/cpu/intel/model_1067x/model_1067x_init.c
@@ -277,5 +277,5 @@
};
struct chip_operations cpu_intel_model_1067x_ops = {
- CHIP_NAME("Intel Penryn CPU")
+ .name = "Intel Penryn CPU",
};
diff --git a/src/cpu/intel/model_2065x/acpi.c b/src/cpu/intel/model_2065x/acpi.c
index d8fef62..2dceba1 100644
--- a/src/cpu/intel/model_2065x/acpi.c
+++ b/src/cpu/intel/model_2065x/acpi.c
@@ -242,5 +242,5 @@
}
struct chip_operations cpu_intel_model_2065x_ops = {
- CHIP_NAME("Intel Arrandale CPU")
+ .name = "Intel Arrandale CPU",
};
diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c
index f3bd67b..75e6755 100644
--- a/src/cpu/intel/model_206ax/acpi.c
+++ b/src/cpu/intel/model_206ax/acpi.c
@@ -380,5 +380,5 @@
}
struct chip_operations cpu_intel_model_206ax_ops = {
- CHIP_NAME("Intel SandyBridge/IvyBridge CPU")
+ .name = "Intel SandyBridge/IvyBridge CPU",
};
diff --git a/src/cpu/intel/slot_1/slot_1.c b/src/cpu/intel/slot_1/slot_1.c
index 0f5b157..ed8e88c 100644
--- a/src/cpu/intel/slot_1/slot_1.c
+++ b/src/cpu/intel/slot_1/slot_1.c
@@ -3,5 +3,5 @@
#include <device/device.h>
struct chip_operations cpu_intel_slot_1_ops = {
- CHIP_NAME("Slot 1 CPU")
+ .name = "Slot 1 CPU",
};
diff --git a/src/cpu/power9/power9.c b/src/cpu/power9/power9.c
index fd33ff2..4d68a5f 100644
--- a/src/cpu/power9/power9.c
+++ b/src/cpu/power9/power9.c
@@ -16,5 +16,5 @@
};
struct chip_operations cpu_power8_qemu_ops = {
- CHIP_NAME("POWER9 CPU")
+ .name = "POWER9 CPU",
};
diff --git a/src/cpu/qemu-power8/qemu.c b/src/cpu/qemu-power8/qemu.c
index 2da3c9f..8cde9b3 100644
--- a/src/cpu/qemu-power8/qemu.c
+++ b/src/cpu/qemu-power8/qemu.c
@@ -21,5 +21,5 @@
};
struct chip_operations cpu_power8_qemu_ops = {
- CHIP_NAME("QEMU POWER8 CPU")
+ .name = "QEMU POWER8 CPU",
};
diff --git a/src/cpu/qemu-x86/qemu.c b/src/cpu/qemu-x86/qemu.c
index 06696c8..289854a 100644
--- a/src/cpu/qemu-x86/qemu.c
+++ b/src/cpu/qemu-x86/qemu.c
@@ -22,5 +22,5 @@
};
struct chip_operations cpu_qemu_x86_ops = {
- CHIP_NAME("QEMU x86 CPU")
+ .name = "QEMU x86 CPU",
};