mc_tcu3: Switch to hwilib instead of own hwinfo implementation
Use hwilib in vendorcode/siemens/hwilib to get fields from hwinfo
instead of having mainboard specific hwinfo code.
This patch does not change the functional behavior in any way.
Change-Id: Idb226a82a08b1b753f654c5cde106236e72f33c3
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-on: https://review.coreboot.org/14506
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
diff --git a/src/mainboard/siemens/mc_tcu3/lcd_panel.c b/src/mainboard/siemens/mc_tcu3/lcd_panel.c
index 91159f9..214773a 100644
--- a/src/mainboard/siemens/mc_tcu3/lcd_panel.c
+++ b/src/mainboard/siemens/mc_tcu3/lcd_panel.c
@@ -15,11 +15,11 @@
#include <cbfs.h>
#include <console/console.h>
#include <string.h>
-#include "modhwinfo.h"
#include "soc/gpio.h"
#include "lcd_panel.h"
#include "ptn3460.h"
+
/** \brief Reads GPIOs used for LCD panel encoding and returns the 4 bit value
* @param no parameters
* @return LCD panel type encoded in 4 bits
@@ -42,10 +42,8 @@
*/
int setup_lcd_panel(void)
{
- u8 lcd_type;
+ u8 lcd_type;
int status;
- struct edidinfo *eib = NULL;
- struct shortinfo *sib = NULL;
char blockname[33];
lcd_type = get_lcd_panel_type();
@@ -71,20 +69,12 @@
status = 1;
break;
}
-
- /* Now that we have the panel type, get the matching block and setup */
- /* the DP2LVDS converter accordingly */
- eib = get_edidinfo(blockname);
- sib = get_shortinfo(blockname);
-
- if ((!eib) || (!sib)) {
- printk(BIOS_ERR, "LCD: Info block named \"%s\" not found!\n", blockname);
- status = 1;
- } else {
- printk(BIOS_INFO, "LCD: Found SIB at 0x%x, EIB at 0x%x\n",
- (int)sib, (int)eib);
- status = ptn3460_init(lcd_type, eib, sib);
+ /* Now that we have the panel type, setup the DP2LVDS converter */
+ status = ptn3460_init(blockname);
+ if (status)
+ printk(BIOS_ERR, "LCD: Setup PTN with status 0x%x\n", status);
+ else
printk(BIOS_INFO, "LCD: Setup PTN with status 0x%x\n", status);
- }
+
return status;
}