commit be6ad1ace05e5d353f3718dbc0d0235d15df5e4e
author Angel Pons <th3fanbus@gmail.com> Fri Oct 30 13:55:23 2020 +0100
committer Patrick Georgi <pgeorgi@google.com> Mon Feb 01 08:49:50 2021 +0000
tree 6fb347ec5111a820050c2538e094f29337548512
parent 2a358fc52d092cfdfbefba9057d9f25d8feee42c

sb/intel/lynxpoint: Use correct port mask for LPT-LP

Lynxpoint LP only has 4 SATA ports.

Change-Id: I565a0b2d29ac8fff8b5d87e0f1dbb3667f229365
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47035
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/southbridge/intel/lynxpoint/sata.c

diff --git a/src/southbridge/intel/lynxpoint/sata.c b/src/southbridge/intel/lynxpoint/sata.c
index a0a606d..33a048d 100644
--- a/src/southbridge/intel/lynxpoint/sata.c
+++ b/src/southbridge/intel/lynxpoint/sata.c
@@ -11,6 +11,12 @@
 #include "iobp.h"
 #include "pch.h"
 
+#if CONFIG(INTEL_LYNXPOINT_LP)
+#define SATA_PORT_MASK	0x0f
+#else
+#define SATA_PORT_MASK	0x3f
+#endif
+
 typedef struct southbridge_intel_lynxpoint_config config_t;
 
 static inline u32 sir_read(struct device *dev, int idx)
@@ -64,7 +70,7 @@
 	pci_write_config16(dev, IDE_TIM_SEC, IDE_DECODE_ENABLE);
 
 	/* for AHCI, Port Enable is managed in memory mapped space */
-	pci_update_config16(dev, 0x92, ~0x3f, 0x8000 | config->sata_port_map);
+	pci_update_config16(dev, 0x92, ~SATA_PORT_MASK, 0x8000 | config->sata_port_map);
 	udelay(2);
 
 	/* Setup register 98h */
@@ -90,7 +96,7 @@
 
 	/* SATA Initialization register */
 	reg32 = 0x183;
-	reg32 |= (config->sata_port_map ^ 0x3f) << 24;
+	reg32 |= (config->sata_port_map ^ SATA_PORT_MASK) << 24;
 	reg32 |= (config->sata_devslp_mux & 1) << 15;
 	pci_write_config32(dev, 0x94, reg32);
 
@@ -201,7 +207,7 @@
 	 * Set SATA controller mode early so the resource allocator can
 	 * properly assign IO/Memory resources for the controller.
 	 */
-	pci_write_config16(dev, 0x90, 0x0060 | (config->sata_port_map ^ 0x3f) << 8);
+	pci_write_config16(dev, 0x90, 0x0060 | (config->sata_port_map ^ SATA_PORT_MASK) << 8);
 }
 
 static struct device_operations sata_ops = {