tree: Use <stdio.h> for snprintf
<stdio.h> header is used for input/output operations (such as printf,
scanf, fopen, etc.). Although some input/output functions can manipulate
strings, they do not need to directly include <string.h> because they
are declared independently.
Change-Id: Ibe2a4ff6f68843a6d99cfdfe182cf2dd922802aa
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82665
Reviewed-by: Yidi Lin <yidilin@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c
index 9c04e84..4049df0 100644
--- a/src/acpi/acpigen.c
+++ b/src/acpi/acpigen.c
@@ -14,6 +14,7 @@
#include <console/console.h>
#include <device/device.h>
#include <device/soundwire.h>
+#include <stdio.h>
#include <types.h>
static char *gencurrent;
diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c
index aa8de1e..b28dcc6 100644
--- a/src/acpi/acpigen_dptf.c
+++ b/src/acpi/acpigen_dptf.c
@@ -4,6 +4,7 @@
#include <acpi/acpigen_dptf.h>
#include <stdbool.h>
#include <stdint.h>
+#include <stdio.h>
/* Defaults */
#define DEFAULT_RAW_UNIT "ma"
diff --git a/src/acpi/acpigen_usb.c b/src/acpi/acpigen_usb.c
index 221a215..c285360 100644
--- a/src/acpi/acpigen_usb.c
+++ b/src/acpi/acpigen_usb.c
@@ -5,6 +5,7 @@
#include <acpi/acpigen.h>
#include <acpi/acpigen_usb.h>
#include <device/device.h>
+#include <stdio.h>
static const char *power_role_to_str(enum usb_typec_power_role power_role)
{
diff --git a/src/acpi/device.c b/src/acpi/device.c
index 7313639..af3d262 100644
--- a/src/acpi/device.c
+++ b/src/acpi/device.c
@@ -8,6 +8,7 @@
#include <acpi/acpigen_pci.h>
#include <device/device.h>
#include <stdlib.h>
+#include <stdio.h>
#include <types.h>
#include <crc_byte.h>
diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c
index 291659a..8042057 100644
--- a/src/arch/arm64/smbios.c
+++ b/src/arch/arm64/smbios.c
@@ -5,6 +5,7 @@
#include <arch/smc.h>
#include <console/console.h>
#include <smbios.h>
+#include <stdio.h>
#include <string.h>
static void smbios_processor_id(u32 *processor_id)
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 0338b60..f42de71 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -5,6 +5,7 @@
#include <console/console.h>
#include <arch/cpu.h>
#include <cpu/x86/name.h>
+#include <stdio.h>
static int smbios_cpu_vendor(u8 *start)
{
diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c
index 06b9e49..4ffc677 100644
--- a/src/console/vsprintf.c
+++ b/src/console/vsprintf.c
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <console/vtxprintf.h>
+#include <stdio.h>
#include <string.h>
struct vsnprintf_context {
diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c
index 02debfc..646f3bb 100644
--- a/src/cpu/x86/smm/smm_module_loader.c
+++ b/src/cpu/x86/smm/smm_module_loader.c
@@ -11,6 +11,7 @@
#include <device/mmio.h>
#include <rmodule.h>
#include <smmstore.h>
+#include <stdio.h>
#include <string.h>
#include <types.h>
diff --git a/src/device/device_util.c b/src/device/device_util.c
index 5d62020..6a45770 100644
--- a/src/device/device_util.c
+++ b/src/device/device_util.c
@@ -4,6 +4,7 @@
#include <console/console.h>
#include <device/device.h>
#include <device/pci_def.h>
+#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <types.h>
diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index 7679552..d60720e 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -6,6 +6,7 @@
#include <device/pci.h>
#include <device/pci_ids.h>
#include <device/pci_ops.h>
+#include <stdio.h>
#include <string.h>
#include <cbfs.h>
#include <cbmem.h>
diff --git a/src/drivers/acpi/thermal_zone/thermal_zone.c b/src/drivers/acpi/thermal_zone/thermal_zone.c
index ef95bed..b1016cd 100644
--- a/src/drivers/acpi/thermal_zone/thermal_zone.c
+++ b/src/drivers/acpi/thermal_zone/thermal_zone.c
@@ -5,6 +5,7 @@
#include <commonlib/bsd/helpers.h>
#include <console/console.h>
#include <device/device.h>
+#include <stdio.h>
#include <stdlib.h>
#include <string.h>
diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c
index 16ae48d..28377a1 100644
--- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c
+++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c
@@ -3,6 +3,7 @@
#include <acpi/acpi_device.h>
#include <acpi/acpigen.h>
#include <device/device.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
#include <console/console.h>
diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c
index 37b90ca..97a4e05 100644
--- a/src/drivers/generic/gpio_keys/gpio_keys.c
+++ b/src/drivers/generic/gpio_keys/gpio_keys.c
@@ -3,6 +3,7 @@
#include <acpi/acpi_device.h>
#include <acpi/acpigen.h>
#include <device/device.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/cs35l53/cs35l53.c b/src/drivers/i2c/cs35l53/cs35l53.c
index 479ef7f..974a647 100644
--- a/src/drivers/i2c/cs35l53/cs35l53.c
+++ b/src/drivers/i2c/cs35l53/cs35l53.c
@@ -6,6 +6,7 @@
#include <console/console.h>
#include <device/i2c_simple.h>
#include <device/device.h>
+#include <stdio.h>
#include "chip.h"
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c
index a2d510b..a3d8ef2 100644
--- a/src/drivers/i2c/generic/generic.c
+++ b/src/drivers/i2c/generic/generic.c
@@ -7,6 +7,7 @@
#include <device/i2c_simple.h>
#include <device/device.h>
#include <gpio.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c
index 5487f6d..8efcf21 100644
--- a/src/drivers/i2c/gpiomux/bus/bus.c
+++ b/src/drivers/i2c/gpiomux/bus/bus.c
@@ -4,6 +4,7 @@
#include <acpi/acpigen.h>
#include <console/console.h>
#include <device/device.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c
index 91d4ebf..a7dcd64 100644
--- a/src/drivers/i2c/gpiomux/mux/mux.c
+++ b/src/drivers/i2c/gpiomux/mux/mux.c
@@ -4,6 +4,7 @@
#include <acpi/acpigen.h>
#include <console/console.h>
#include <device/device.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c
index fb3a439..06b31d1 100644
--- a/src/drivers/i2c/hid/hid.c
+++ b/src/drivers/i2c/hid/hid.c
@@ -4,6 +4,7 @@
#include <acpi/acpi_device.h>
#include <assert.h>
#include <device/device.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
#include <gpio.h>
diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c
index f4912c1..dced120 100644
--- a/src/drivers/i2c/max98390/max98390.c
+++ b/src/drivers/i2c/max98390/max98390.c
@@ -7,6 +7,7 @@
#include <device/device.h>
#include <identity.h>
#include <stdint.h>
+#include <stdio.h>
#include <vendorcode/google/dsm_calib.h>
#include "chip.h"
diff --git a/src/drivers/i2c/max98396/max98396.c b/src/drivers/i2c/max98396/max98396.c
index ca07dbd..f71873a 100644
--- a/src/drivers/i2c/max98396/max98396.c
+++ b/src/drivers/i2c/max98396/max98396.c
@@ -5,6 +5,7 @@
#include <console/console.h>
#include <device/i2c_simple.h>
#include <device/device.h>
+#include <stdio.h>
#include "chip.h"
diff --git a/src/drivers/i2c/rt1011/rt1011.c b/src/drivers/i2c/rt1011/rt1011.c
index e8ee8df..08a0fac 100644
--- a/src/drivers/i2c/rt1011/rt1011.c
+++ b/src/drivers/i2c/rt1011/rt1011.c
@@ -6,6 +6,7 @@
#include <device/i2c.h>
#include <device/device.h>
#include <stdint.h>
+#include <stdio.h>
#include <vendorcode/google/dsm_calib.h>
#include "chip.h"
diff --git a/src/drivers/i2c/rt5645/rt5645.c b/src/drivers/i2c/rt5645/rt5645.c
index 28434ee..ea3837f 100644
--- a/src/drivers/i2c/rt5645/rt5645.c
+++ b/src/drivers/i2c/rt5645/rt5645.c
@@ -4,6 +4,8 @@
#include <acpi/acpigen.h>
#include <console/console.h>
#include <device/device.h>
+#include <stdio.h>
+
#include "chip.h"
#define RT5645_ACPI_NAME "RT58"
diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c
index e5142bc..a4bdb15 100644
--- a/src/drivers/i2c/sx9310/sx9310.c
+++ b/src/drivers/i2c/sx9310/sx9310.c
@@ -5,6 +5,7 @@
#include <console/console.h>
#include <device/i2c_simple.h>
#include <device/device.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c
index 966726f..041991e 100644
--- a/src/drivers/i2c/sx9324/sx9324.c
+++ b/src/drivers/i2c/sx9324/sx9324.c
@@ -5,6 +5,7 @@
#include <console/console.h>
#include <device/i2c_simple.h>
#include <device/device.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/sx9360/sx9360.c b/src/drivers/i2c/sx9360/sx9360.c
index df154f4..d72f28d 100644
--- a/src/drivers/i2c/sx9360/sx9360.c
+++ b/src/drivers/i2c/sx9360/sx9360.c
@@ -5,6 +5,7 @@
#include <console/console.h>
#include <device/i2c_simple.h>
#include <device/device.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c
index 5bbbc1b..b6f5005 100644
--- a/src/drivers/intel/dptf/dptf.c
+++ b/src/drivers/intel/dptf/dptf.c
@@ -5,6 +5,7 @@
#include <console/console.h>
#include <device/device.h>
#include <intelblocks/pmc_ipc.h>
+#include <stdio.h>
#include <soc/dptf.h>
#include <soc/pci_devs.h>
#include "chip.h"
diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c
index 47dc3e8..d09b39b 100644
--- a/src/drivers/intel/fsp2_0/util.c
+++ b/src/drivers/intel/fsp2_0/util.c
@@ -8,6 +8,7 @@
#include <commonlib/fsp.h>
#include <console/console.h>
#include <fsp/util.h>
+#include <stdio.h>
#include <string.h>
#include <types.h>
#include <assert.h>
diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c
index 2ee1d63..534c0d8 100644
--- a/src/drivers/intel/gma/acpi.c
+++ b/src/drivers/intel/gma/acpi.c
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <acpi/acpigen.h>
+#include <stdio.h>
#include <string.h>
#include "i915.h"
diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c
index 190adc7..63a409a 100644
--- a/src/drivers/intel/mipi_camera/camera.c
+++ b/src/drivers/intel/mipi_camera/camera.c
@@ -9,6 +9,8 @@
#include <device/i2c_simple.h>
#include <device/device.h>
#include <device/pci_def.h>
+#include <stdio.h>
+
#include "chip.h"
#define CSI2_DATA_STREAM_INTERFACE_GUID \
diff --git a/src/drivers/intel/pmc_mux/conn/conn.c b/src/drivers/intel/pmc_mux/conn/conn.c
index 4b1b08c..dda1fe0 100644
--- a/src/drivers/intel/pmc_mux/conn/conn.c
+++ b/src/drivers/intel/pmc_mux/conn/conn.c
@@ -7,6 +7,7 @@
#include <console/console.h>
#include <drivers/usb/acpi/chip.h>
#include <intelblocks/acpi.h>
+#include <stdio.h>
#include "chip.h"
diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c
index 9e627de..3c867d4 100644
--- a/src/drivers/intel/usb4/retimer/retimer.c
+++ b/src/drivers/intel/usb4/retimer/retimer.c
@@ -7,6 +7,7 @@
#include <device/device.h>
#include <drivers/usb/acpi/chip.h>
#include <gpio.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
#include "retimer.h"
diff --git a/src/drivers/nxp/uwb/uwb.c b/src/drivers/nxp/uwb/uwb.c
index 590b3f5..3c4fac1 100644
--- a/src/drivers/nxp/uwb/uwb.c
+++ b/src/drivers/nxp/uwb/uwb.c
@@ -6,6 +6,7 @@
#include <device/device.h>
#include <device/spi.h>
#include <spi-generic.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c
index ead9b4d..0ac3334 100644
--- a/src/drivers/ocp/dmi/smbios.c
+++ b/src/drivers/ocp/dmi/smbios.c
@@ -6,6 +6,7 @@
#include <delay.h>
#include <cpu/x86/mp.h>
#include <timer.h>
+#include <stdio.h>
#include <string.h>
#include <soc/soc_util.h>
#include <soc/util.h>
diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c
index e87946f..75d6dc9 100644
--- a/src/drivers/spi/acpi/acpi.c
+++ b/src/drivers/spi/acpi/acpi.c
@@ -6,6 +6,7 @@
#include <device/device.h>
#include <device/spi.h>
#include <spi-generic.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c
index a245f2c..716d522 100644
--- a/src/drivers/uart/acpi/acpi.c
+++ b/src/drivers/uart/acpi/acpi.c
@@ -3,6 +3,7 @@
#include <acpi/acpi_device.h>
#include <acpi/acpigen.h>
#include <console/console.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/drivers/usb/hub/acpi.c b/src/drivers/usb/hub/acpi.c
index ebbe4b2..15732a8 100644
--- a/src/drivers/usb/hub/acpi.c
+++ b/src/drivers/usb/hub/acpi.c
@@ -2,6 +2,7 @@
#include <acpi/acpigen.h>
#include <acpi/acpi_device.h>
+#include <stdio.h>
#include "chip.h"
diff --git a/src/drivers/usb/pci_xhci/pci_xhci.c b/src/drivers/usb/pci_xhci/pci_xhci.c
index 47f69c0..b898642 100644
--- a/src/drivers/usb/pci_xhci/pci_xhci.c
+++ b/src/drivers/usb/pci_xhci/pci_xhci.c
@@ -7,6 +7,7 @@
#include <device/pci.h>
#include <device/pci_ids.h>
#include <device/xhci.h>
+#include <stdio.h>
#include <stdlib.h>
#define PCI_XHCI_CLASSCODE 0x0c0330 /* USB3.0 xHCI controller */
diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c
index 9e2936d..fd1da06 100644
--- a/src/drivers/wifi/generic/acpi.c
+++ b/src/drivers/wifi/generic/acpi.c
@@ -7,6 +7,7 @@
#include <device/pci_ids.h>
#include <mtcl.h>
#include <sar.h>
+#include <stdio.h>
#include <stdlib.h>
#include <wrdd.h>
diff --git a/src/ec/clevo/it5570e/ssdt.c b/src/ec/clevo/it5570e/ssdt.c
index a0d746a..b5a5774 100644
--- a/src/ec/clevo/it5570e/ssdt.c
+++ b/src/ec/clevo/it5570e/ssdt.c
@@ -4,6 +4,7 @@
#include <console/console.h>
#include <device/device.h>
#include <device/mmio.h>
+#include <stdio.h>
#include "chip.h"
#include "ec.h"
diff --git a/src/ec/google/chromeec/audio_codec/audio_codec.c b/src/ec/google/chromeec/audio_codec/audio_codec.c
index a8def98..fe2a459 100644
--- a/src/ec/google/chromeec/audio_codec/audio_codec.c
+++ b/src/ec/google/chromeec/audio_codec/audio_codec.c
@@ -5,6 +5,8 @@
#include <console/console.h>
#include <device/device.h>
#include <device/path.h>
+#include <stdio.h>
+
#include "chip.h"
#define CROS_EC_AUDIO_CODEC_HID "GOOG0013"
diff --git a/src/ec/google/chromeec/ec_dptf_helpers.c b/src/ec/google/chromeec/ec_dptf_helpers.c
index c44138f..3034010 100644
--- a/src/ec/google/chromeec/ec_dptf_helpers.c
+++ b/src/ec/google/chromeec/ec_dptf_helpers.c
@@ -4,6 +4,7 @@
#include <acpi/acpigen_dptf.h>
#include <ec/google/common/dptf.h>
#include <drivers/intel/dptf/chip.h>
+#include <stdio.h>
#include "chip.h"
/*
diff --git a/src/ec/google/chromeec/ec_smbios.c b/src/ec/google/chromeec/ec_smbios.c
index cd7ac2e..5205ed3 100644
--- a/src/ec/google/chromeec/ec_smbios.c
+++ b/src/ec/google/chromeec/ec_smbios.c
@@ -2,6 +2,7 @@
#include <ec/google/chromeec/ec.h>
#include <console/console.h>
+#include <stdio.h>
#include <string.h>
#include <smbios.h>
diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c
index 64812d4..fc6b759 100644
--- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c
+++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c
@@ -5,6 +5,7 @@
#include <console/console.h>
#include <device/device.h>
#include <device/path.h>
+#include <stdio.h>
#include <string.h>
#include "chip.h"
diff --git a/src/ec/google/chromeec/mux/conn/conn.c b/src/ec/google/chromeec/mux/conn/conn.c
index bb3129b..1200b5c 100644
--- a/src/ec/google/chromeec/mux/conn/conn.c
+++ b/src/ec/google/chromeec/mux/conn/conn.c
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#include <acpi/acpigen.h>
+#include <stdio.h>
#include "chip.h"
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c
index 35ca1d9..155a013 100644
--- a/src/ec/lenovo/h8/h8.c
+++ b/src/ec/lenovo/h8/h8.c
@@ -5,6 +5,7 @@
#include <device/device.h>
#include <device/pnp.h>
#include <ec/acpi/ec.h>
+#include <stdio.h>
#include <string.h>
#include <smbios.h>
#include <option.h>
diff --git a/src/ec/lenovo/h8/ssdt.c b/src/ec/lenovo/h8/ssdt.c
index 5dc334f..7d7bfac 100644
--- a/src/ec/lenovo/h8/ssdt.c
+++ b/src/ec/lenovo/h8/ssdt.c
@@ -2,6 +2,7 @@
#include <console/console.h>
#include <acpi/acpigen.h>
+#include <stdio.h>
#include <string.h>
#include "h8.h"
diff --git a/src/include/stdio.h b/src/include/stdio.h
index d59b941..fe7cb58 100644
--- a/src/include/stdio.h
+++ b/src/include/stdio.h
@@ -1,8 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/**
- * Note: This file is only for POSIX compatibility, and is meant to be
- * chain-included via string.h.
+ * Note: This file is only for POSIX compatibility.
*/
#ifndef STDIO_H
diff --git a/src/include/string.h b/src/include/string.h
index 4a06556..33f0dfe 100644
--- a/src/include/string.h
+++ b/src/include/string.h
@@ -4,7 +4,6 @@
#define STRING_H
#include <stddef.h>
-#include <stdio.h> /* IWYU pragma: export */
void *memcpy(void *dest, const void *src, size_t n);
void *memmove(void *dest, const void *src, size_t n);
diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c
index 2bfd5dd..aff9e15 100644
--- a/src/lib/device_tree.c
+++ b/src/lib/device_tree.c
@@ -8,6 +8,7 @@
#include <endian.h>
#include <stdbool.h>
#include <stdint.h>
+#include <stdio.h>
#include <string.h>
#include <stddef.h>
#include <stdlib.h>
diff --git a/src/lib/fit.c b/src/lib/fit.c
index 46ac972..7f0fe67 100644
--- a/src/lib/fit.c
+++ b/src/lib/fit.c
@@ -12,6 +12,7 @@
#include <memrange.h>
#include <fit.h>
#include <boardid.h>
+#include <stdio.h>
#include <stdlib.h>
#include <types.h>
diff --git a/src/lib/smbios.c b/src/lib/smbios.c
index dcf12bf..ca71e3b 100644
--- a/src/lib/smbios.c
+++ b/src/lib/smbios.c
@@ -16,6 +16,7 @@
#include <device/pci_ids.h>
#include <device/pci.h>
#include <drivers/vpd/vpd.h>
+#include <stdio.h>
#include <stdlib.h>
static u8 smbios_checksum(u8 *p, u32 length)
diff --git a/src/lib/smbios_defaults.c b/src/lib/smbios_defaults.c
index 8b62ebb..56bddab 100644
--- a/src/lib/smbios_defaults.c
+++ b/src/lib/smbios_defaults.c
@@ -3,6 +3,7 @@
#include <memory_info.h>
#include <smbios.h>
#include <stdint.h>
+#include <stdio.h>
#include <string.h>
/* this function will fill the corresponding locator */
diff --git a/src/lib/ux_locales.c b/src/lib/ux_locales.c
index 0a285d9..b389548 100644
--- a/src/lib/ux_locales.c
+++ b/src/lib/ux_locales.c
@@ -4,6 +4,7 @@
#include <console/console.h>
#include <security/vboot/misc.h>
#include <stddef.h>
+#include <stdio.h>
#include <string.h>
#include <ux_locales.h>
#include <vb2_api.h>
diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c
index 0d631cc..257a27f 100644
--- a/src/mainboard/google/fizz/mainboard.c
+++ b/src/mainboard/google/fizz/mainboard.c
@@ -14,6 +14,7 @@
#include <smbios.h>
#include <soc/pci_devs.h>
#include <soc/nhlt.h>
+#include <stdio.h>
#include <string.h>
#include <timer.h>
diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c
index 64f45de..971b671 100644
--- a/src/mainboard/google/gru/sdram_configs.c
+++ b/src/mainboard/google/gru/sdram_configs.c
@@ -5,6 +5,7 @@
#include <console/console.h>
#include <gpio.h>
#include <soc/sdram.h>
+#include <stdio.h>
#include <string.h>
#include <types.h>
diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c
index 427f094..1290b97 100644
--- a/src/mainboard/google/kahlee/mainboard.c
+++ b/src/mainboard/google/kahlee/mainboard.c
@@ -16,6 +16,7 @@
#include <soc/acpi.h>
#include <soc/pci_devs.h>
#include <soc/southbridge.h>
+#include <stdio.h>
#include <amdblocks/acpimmio.h>
#include <variant/ec.h>
#include <variant/thermal.h>
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c
index 69047fa..bc70db5 100644
--- a/src/mainboard/google/kukui/mainboard.c
+++ b/src/mainboard/google/kukui/mainboard.c
@@ -19,6 +19,7 @@
#include <soc/mtcmos.h>
#include <soc/spm.h>
#include <soc/usb.h>
+#include <stdio.h>
#include <string.h>
#include "gpio.h"
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c
index aaa51dd..172581f 100644
--- a/src/mainboard/google/poppy/variants/nami/mainboard.c
+++ b/src/mainboard/google/poppy/variants/nami/mainboard.c
@@ -13,6 +13,7 @@
#include <intelblocks/power_limit.h>
#include <smbios.h>
#include <soc/ramstage.h>
+#include <stdio.h>
#include <string.h>
#include <variant/sku.h>
#include <gpio.h>
diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c
index 7350fb0..d21acd6 100644
--- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c
+++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c
@@ -6,6 +6,7 @@
#include <device/device.h>
#include <device/pci_ops.h>
#include <smbios.h>
+#include <stdio.h>
#include <string.h>
#include <variant/sku.h>
diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c
index 90cf7ce..e8c7e69 100644
--- a/src/mainboard/google/poppy/variants/rammus/mainboard.c
+++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c
@@ -3,6 +3,7 @@
#include <baseboard/variants.h>
#include <ec/google/chromeec/ec.h>
#include <smbios.h>
+#include <stdio.h>
#include <string.h>
#include <sar.h>
diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c
index ff3bb36..4b1b32d 100644
--- a/src/mainboard/google/reef/mainboard.c
+++ b/src/mainboard/google/reef/mainboard.c
@@ -10,6 +10,7 @@
#include <nhlt.h>
#include <smbios.h>
#include <soc/nhlt.h>
+#include <stdio.h>
#include <string.h>
#include <variant/ec.h>
#include <variant/gpio.h>
diff --git a/src/mainboard/google/rex/mainboard.c b/src/mainboard/google/rex/mainboard.c
index bf489ff..9157abb 100644
--- a/src/mainboard/google/rex/mainboard.c
+++ b/src/mainboard/google/rex/mainboard.c
@@ -9,6 +9,7 @@
#include <ec/ec.h>
#include <fw_config.h>
#include <soc/ramstage.h>
+#include <stdio.h>
#include <stdlib.h>
#include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/google/volteer/mainboard.c b/src/mainboard/google/volteer/mainboard.c
index fba9664..ae7519e 100644
--- a/src/mainboard/google/volteer/mainboard.c
+++ b/src/mainboard/google/volteer/mainboard.c
@@ -12,6 +12,7 @@
#include <intelblocks/tcss.h>
#include <soc/pci_devs.h>
#include <soc/ramstage.h>
+#include <stdio.h>
#include <variant/gpio.h>
#include <vb2_api.h>
diff --git a/src/mainboard/ibm/sbp1/ramstage.c b/src/mainboard/ibm/sbp1/ramstage.c
index d748b1b..98aa999 100644
--- a/src/mainboard/ibm/sbp1/ramstage.c
+++ b/src/mainboard/ibm/sbp1/ramstage.c
@@ -2,6 +2,7 @@
#include <cpu/x86/smm.h>
#include <soc/ramstage.h>
#include <soc/smmrelocate.h>
+#include <stdio.h>
#include "include/spr_sbp1_gpio.h"
#include <bootstate.h>
diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c
index 9ac480d..f6321e8 100644
--- a/src/mainboard/intel/adlrvp/mainboard.c
+++ b/src/mainboard/intel/adlrvp/mainboard.c
@@ -11,6 +11,7 @@
#include <smbios.h>
#include <soc/gpio.h>
#include <stdint.h>
+#include <stdio.h>
#include <string.h>
#include "board_id.h"
diff --git a/src/mainboard/intel/mtlrvp/mainboard.c b/src/mainboard/intel/mtlrvp/mainboard.c
index 2e515f7..85c2dd4 100644
--- a/src/mainboard/intel/mtlrvp/mainboard.c
+++ b/src/mainboard/intel/mtlrvp/mainboard.c
@@ -8,6 +8,7 @@
#include <soc/ramstage.h>
#include <smbios.h>
#include <stdint.h>
+#include <stdio.h>
#include <string.h>
const char *smbios_system_sku(void)
diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c
index bbce927..8f38ca2 100644
--- a/src/mainboard/intel/tglrvp/mainboard.c
+++ b/src/mainboard/intel/tglrvp/mainboard.c
@@ -6,6 +6,7 @@
#include <ec/ec.h>
#include <soc/gpio.h>
#include <smbios.h>
+#include <stdio.h>
#include <string.h>
const char *smbios_system_sku(void)
diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c
index dbdd059..01815ed 100644
--- a/src/mainboard/kontron/986lcd-m/mainboard.c
+++ b/src/mainboard/kontron/986lcd-m/mainboard.c
@@ -6,6 +6,7 @@
#include <console/console.h>
#include <drivers/intel/gma/int15.h>
#include <option.h>
+#include <stdio.h>
#include <superio/hwm5_conf.h>
#include <superio/nuvoton/common/hwm.h>
diff --git a/src/mainboard/lenovo/s230u/mainboard.c b/src/mainboard/lenovo/s230u/mainboard.c
index b5e3b87..f51ec67 100644
--- a/src/mainboard/lenovo/s230u/mainboard.c
+++ b/src/mainboard/lenovo/s230u/mainboard.c
@@ -5,6 +5,7 @@
#include <drivers/intel/gma/int15.h>
#include <ec/acpi/ec.h>
#include <southbridge/intel/common/gpio.h>
+#include <stdio.h>
#include <string.h>
#include <smbios.h>
#include "ec.h"
diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c
index 6dd7c10..55a10ad 100644
--- a/src/mainboard/ocp/deltalake/ramstage.c
+++ b/src/mainboard/ocp/deltalake/ramstage.c
@@ -20,6 +20,7 @@
#include <soc/smmrelocate.h>
#include <soc/soc_util.h>
#include <soc/util.h>
+#include <stdio.h>
#include <string.h>
#include <types.h>
diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c
index ac5c928..b21c7ed 100644
--- a/src/mainboard/pcengines/apu2/mainboard.c
+++ b/src/mainboard/pcengines/apu2/mainboard.c
@@ -16,6 +16,7 @@
#include <southbridge/amd/common/amd_pci_util.h>
#include <superio/nuvoton/nct5104d/nct5104d.h>
#include <smbios.h>
+#include <stdio.h>
#include <string.h>
#include <AGESA.h>
#include "gpio_ftns.h"
diff --git a/src/mainboard/prodrive/atlas/mainboard.c b/src/mainboard/prodrive/atlas/mainboard.c
index 0128670..a70bbae 100644
--- a/src/mainboard/prodrive/atlas/mainboard.c
+++ b/src/mainboard/prodrive/atlas/mainboard.c
@@ -5,6 +5,7 @@
#include <device/device.h>
#include <gpio.h>
#include <smbios.h>
+#include <stdio.h>
#include <string.h>
#include <types.h>
diff --git a/src/mainboard/prodrive/atlas/vpd.c b/src/mainboard/prodrive/atlas/vpd.c
index ba249a9..badbc6e 100644
--- a/src/mainboard/prodrive/atlas/vpd.c
+++ b/src/mainboard/prodrive/atlas/vpd.c
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <console/console.h>
+#include <stdio.h>
#include <string.h>
#include <types.h>
diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c
index b0bf0dd..6d0da8d 100644
--- a/src/mainboard/prodrive/hermes/mainboard.c
+++ b/src/mainboard/prodrive/hermes/mainboard.c
@@ -16,6 +16,7 @@
#include <intelblocks/pmclib.h>
#include <smbios.h>
#include <soc/pm.h>
+#include <stdio.h>
#include <string.h>
#include <types.h>
diff --git a/src/mainboard/prodrive/hermes/smbios.c b/src/mainboard/prodrive/hermes/smbios.c
index 923ce81..9671555 100644
--- a/src/mainboard/prodrive/hermes/smbios.c
+++ b/src/mainboard/prodrive/hermes/smbios.c
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <smbios.h>
+#include <stdio.h>
#include <string.h>
#include <types.h>
diff --git a/src/security/tpm/tspi/crtm.c b/src/security/tpm/tspi/crtm.c
index 621d7cd..4e0a9b7 100644
--- a/src/security/tpm/tspi/crtm.c
+++ b/src/security/tpm/tspi/crtm.c
@@ -6,6 +6,7 @@
#include <cbfs.h>
#include <symbols.h>
#include "crtm.h"
+#include <stdio.h>
#include <string.h>
static int tpm_log_initialized;
diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c
index 5e606d3..81c9a64 100644
--- a/src/soc/cavium/cn81xx/soc.c
+++ b/src/soc/cavium/cn81xx/soc.c
@@ -13,6 +13,7 @@
#include <soc/uart.h>
#include <stddef.h>
#include <stdlib.h>
+#include <stdio.h>
#include <string.h>
#include <symbols.h>
#include <libbdk-boot/bdk-boot.h>
diff --git a/src/soc/intel/common/block/acpi/cpu_hybrid.c b/src/soc/intel/common/block/acpi/cpu_hybrid.c
index f52b68f..68abba7 100644
--- a/src/soc/intel/common/block/acpi/cpu_hybrid.c
+++ b/src/soc/intel/common/block/acpi/cpu_hybrid.c
@@ -9,6 +9,7 @@
#include <device/path.h>
#include <intelblocks/acpi.h>
#include <soc/cpu.h>
+#include <stdio.h>
#include <types.h>
#define CPPC_NOM_FREQ_IDX 22
diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c
index 0d66aec..1c493af 100644
--- a/src/soc/intel/xeon_sp/acpi.c
+++ b/src/soc/intel/xeon_sp/acpi.c
@@ -6,6 +6,7 @@
#include <soc/pci_devs.h>
#include <soc/util.h>
#include <stdint.h>
+#include <stdio.h>
#include <stdlib.h>
#include "chip.h"
diff --git a/src/soc/mediatek/common/display.c b/src/soc/mediatek/common/display.c
index 0dea58c..0c23e49 100644
--- a/src/soc/mediatek/common/display.c
+++ b/src/soc/mediatek/common/display.c
@@ -10,6 +10,7 @@
#include <soc/dptx.h>
#include <soc/dsi.h>
#include <soc/mtcmos.h>
+#include <stdio.h>
#include <string.h>
static struct panel_serializable_data *get_mipi_cmd_from_cbfs(struct panel_description *desc)
diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c
index ce44bc4..956fe63 100644
--- a/src/southbridge/intel/common/rcba_pirq.c
+++ b/src/southbridge/intel/common/rcba_pirq.c
@@ -4,6 +4,7 @@
#include <console/console.h>
#include <device/device.h>
#include <device/pci.h>
+#include <stdio.h>
#include <stdlib.h>
#include <southbridge/intel/common/acpi_pirq_gen.h>
#include <southbridge/intel/common/rcba_pirq.h>
diff --git a/src/southbridge/intel/lynxpoint/acpi.c b/src/southbridge/intel/lynxpoint/acpi.c
index aa6e650..c3aee1f 100644
--- a/src/southbridge/intel/lynxpoint/acpi.c
+++ b/src/southbridge/intel/lynxpoint/acpi.c
@@ -3,6 +3,7 @@
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <acpi/acpigen.h>
+#include <stdio.h>
#include <string.h>
#include <version.h>
#include <soc/nvs.h>
diff --git a/src/superio/common/ssdt.c b/src/superio/common/ssdt.c
index 4fd1eed..a63ca9c 100644
--- a/src/superio/common/ssdt.c
+++ b/src/superio/common/ssdt.c
@@ -8,6 +8,7 @@
#include <acpi/acpi.h>
#include <console/console.h>
#include <types.h>
+#include <stdio.h>
#include <string.h>
struct superio_dev {
diff --git a/src/vendorcode/amd/opensil/genoa_poc/ramstage.c b/src/vendorcode/amd/opensil/genoa_poc/ramstage.c
index 758b284..843f073 100644
--- a/src/vendorcode/amd/opensil/genoa_poc/ramstage.c
+++ b/src/vendorcode/amd/opensil/genoa_poc/ramstage.c
@@ -9,6 +9,7 @@
#include <cpu/cpu.h>
#include <device/device.h>
#include <soc/soc_chip.h>
+#include <stdio.h>
#include <xSIM-api.h>
#include "opensil_console.h"
#include "opensil.h"
diff --git a/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-config.c b/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-config.c
index 1cf01a2..a2a0b62 100644
--- a/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-config.c
+++ b/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-config.c
@@ -37,6 +37,7 @@
* ARISING OUT OF USE OR PERFORMANCE OF THE SOFTWARE LIES WITH YOU.
***********************license end**************************************/
#include <bdk.h>
+#include <stdio.h>
#include <string.h>
#include <libbdk-hal/bdk-config.h>
#include <libbdk-hal/bdk-l2c.h>
diff --git a/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c b/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c
index fdca040..0d6bd86 100644
--- a/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c
+++ b/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c
@@ -48,6 +48,7 @@
#include <libbdk-hal/bdk-utils.h>
#include <libbdk-os/bdk-init.h>
#include <libbdk-os/bdk-thread.h>
+#include <stdio.h>
/* This code is an optional part of the BDK. It is only linked in
if BDK_REQUIRE() needs it */
diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c
index eec4443..b057353 100644
--- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c
+++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c
@@ -14,6 +14,7 @@
#include <string.h>
#include <assert.h>
#include <lame_string.h>
+#include <stdio.h>
static struct bdk_devicetree_key_value *config_fdt;
diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c
index 21e43a4..a099345 100644
--- a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c
+++ b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c
@@ -38,6 +38,7 @@
***********************license end**************************************/
#include <bdk.h>
#include <stdlib.h>
+#include <stdio.h>
#include <string.h>
#include "libbdk-arch/bdk-csrs-ap.h"
#include "libbdk-arch/bdk-csrs-pccpf.h"
diff --git a/src/vendorcode/cavium/bdk/libdram/dram-init-ddr3.c b/src/vendorcode/cavium/bdk/libdram/dram-init-ddr3.c
index 12d49d8..ec785dd 100644
--- a/src/vendorcode/cavium/bdk/libdram/dram-init-ddr3.c
+++ b/src/vendorcode/cavium/bdk/libdram/dram-init-ddr3.c
@@ -43,6 +43,7 @@
#include "dram-internal.h"
#include <stdlib.h>
+#include <stdio.h>
#include <string.h>
#include <libbdk-hal/bdk-config.h>
#include <libbdk-hal/bdk-l2c.h>
diff --git a/src/vendorcode/google/smbios.c b/src/vendorcode/google/smbios.c
index 938a8f1..2bcd8db 100644
--- a/src/vendorcode/google/smbios.c
+++ b/src/vendorcode/google/smbios.c
@@ -2,6 +2,7 @@
#include <boardid.h>
#include <smbios.h>
+#include <stdio.h>
#include <string.h>
const char *smbios_mainboard_version(void)
diff --git a/tests/lib/lzma-test.c b/tests/lib/lzma-test.c
index 48d629a..e4bff56 100644
--- a/tests/lib/lzma-test.c
+++ b/tests/lib/lzma-test.c
@@ -4,6 +4,7 @@
#include <helpers/file.h>
#include <lib.h>
#include <lib/lzmadecode.h>
+#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/types.h>
diff --git a/tests/stubs/die.c b/tests/stubs/die.c
index 84bb401..86e5056 100644
--- a/tests/stubs/die.c
+++ b/tests/stubs/die.c
@@ -1,7 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <stdarg.h>
-#include <stdio.h>
#include <tests/test.h>
void die(const char *msg, ...)
diff --git a/util/cbfstool/flashmap/kv_pair.c b/util/cbfstool/flashmap/kv_pair.c
index b711302..5d033b3 100644
--- a/util/cbfstool/flashmap/kv_pair.c
+++ b/util/cbfstool/flashmap/kv_pair.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: BSD-3-Clause or GPL-2.0-only */
-#include <stdio.h>
#include <stdlib.h>
#include <stdarg.h>