inteltool: refine GPIO and PMBASE/TCO printing on Ibex Peak/5 Series
Nicolas Reinecke was noticing that in my Lenovo T410s logs the GPIO*3
settings were missing. This led to some investigation and this patch, thanks!
Change-Id: I7ba28aa00d10f988a7fe81e61d2e216b54a11006
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
Signed-off-by: Stefan Tauner <stefan.tauner@gmx.at>
Reviewed-on: http://review.coreboot.org/7239
Reviewed-by: Nicolas Reinecke <nr@das-labor.org>
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h@gmx.de>
diff --git a/util/inteltool/powermgt.c b/util/inteltool/powermgt.c
index 3bc4efc..8908835 100644
--- a/util/inteltool/powermgt.c
+++ b/util/inteltool/powermgt.c
@@ -656,6 +656,23 @@
printf("\n============= PMBASE ============\n\n");
switch (sb->device_id) {
+ case PCI_DEVICE_ID_INTEL_3400:
+ case PCI_DEVICE_ID_INTEL_3420:
+ case PCI_DEVICE_ID_INTEL_3450:
+ case PCI_DEVICE_ID_INTEL_3400_DESKTOP:
+ case PCI_DEVICE_ID_INTEL_3400_MOBILE:
+ case PCI_DEVICE_ID_INTEL_3400_MOBILE_SFF:
+ case PCI_DEVICE_ID_INTEL_B55_A:
+ case PCI_DEVICE_ID_INTEL_B55_B:
+ case PCI_DEVICE_ID_INTEL_H55:
+ case PCI_DEVICE_ID_INTEL_H57:
+ case PCI_DEVICE_ID_INTEL_HM55:
+ case PCI_DEVICE_ID_INTEL_HM57:
+ case PCI_DEVICE_ID_INTEL_P55:
+ case PCI_DEVICE_ID_INTEL_PM55:
+ case PCI_DEVICE_ID_INTEL_Q57:
+ case PCI_DEVICE_ID_INTEL_QM57:
+ case PCI_DEVICE_ID_INTEL_QS57:
case PCI_DEVICE_ID_INTEL_Z68:
case PCI_DEVICE_ID_INTEL_P67:
case PCI_DEVICE_ID_INTEL_UM67:
@@ -761,28 +778,6 @@
size = ARRAY_SIZE(i63xx_pm_registers);
break;
- case PCI_DEVICE_ID_INTEL_3400_DESKTOP:
- case PCI_DEVICE_ID_INTEL_3400_MOBILE:
- case PCI_DEVICE_ID_INTEL_P55:
- case PCI_DEVICE_ID_INTEL_PM55:
- case PCI_DEVICE_ID_INTEL_H55:
- case PCI_DEVICE_ID_INTEL_QM57:
- case PCI_DEVICE_ID_INTEL_H57:
- case PCI_DEVICE_ID_INTEL_HM55:
- case PCI_DEVICE_ID_INTEL_Q57:
- case PCI_DEVICE_ID_INTEL_HM57:
- case PCI_DEVICE_ID_INTEL_3400_MOBILE_SFF:
- case PCI_DEVICE_ID_INTEL_B55_A:
- case PCI_DEVICE_ID_INTEL_QS57:
- case PCI_DEVICE_ID_INTEL_3400:
- case PCI_DEVICE_ID_INTEL_3420:
- case PCI_DEVICE_ID_INTEL_3450:
- case PCI_DEVICE_ID_INTEL_B55_B:
- pmbase = pci_read_word(sb, 0x40) & 0xfffc;
- pm_registers = i63xx_pm_registers;
- size = ARRAY_SIZE(i63xx_pm_registers);
- break;
-
case 0x1234: // Dummy for non-existent functionality
printf("This southbridge does not have PMBASE.\n");
return 1;