commit b456a96361fd8f170b2c6ff17a8ce23c787e0d7c
author Caveh Jalali <caveh@chromium.org> Wed Nov 02 03:29:32 2022 -0700
committer Martin L Roth <gaumless@gmail.com> Thu Nov 10 15:08:05 2022 +0000
tree 0e38a36f565d21ac2dc5349288f199eddeb20060
parent a3148ca504b8a780cb46c42b2e9f539d3233f555

ec/google/chromeec: Fix keyboard_backlight call

The EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT command does not return data, so
don't specify a result buffer.

BUG=b:258126464
BRANCH=none
TEST=none

Change-Id: I5b9a0d228e187a9337498246a3b9ed8db07b95c7
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69368
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>

src/ec/google/chromeec/ec.c

diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index 1fa5906..b609559 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -77,20 +77,19 @@
 	struct ec_params_pwm_set_keyboard_backlight params = {
 		.percent = percent % 101,
 	};
-	struct ec_response_pwm_get_keyboard_backlight resp = {};
 	struct chromeec_command cmd = {
 		.cmd_code = EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT,
 		.cmd_version = 0,
 		.cmd_data_in = &params,
-		.cmd_data_out = &resp,
+		.cmd_data_out = NULL,
 		.cmd_size_in = sizeof(params),
-		.cmd_size_out = sizeof(resp),
+		.cmd_size_out = 0,
 		.cmd_dev_index = 0,
 	};
 
 	google_chromeec_command(&cmd);
-	printk(BIOS_DEBUG, "Google Chrome set keyboard backlight: %x status (%x)\n",
-	       resp.percent, cmd.cmd_code);
+	printk(BIOS_DEBUG, "Google Chrome set keyboard backlight: status (%x)\n",
+	       cmd.cmd_code);
 	return cmd.cmd_code;
 }