nb/intel/i440bx/debug.c: Refactor newlines and save some printk calls
There are two conditions within the config space dump code, one to
print offset, one at the end to put a newline. Tweak the printk
strings so the first conditioned printk does it all and move the
second printk out of the loop to the very end.
Change-Id: Ie9dc744406ba20412892df96720e88e24c3d52bc
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73887
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/src/northbridge/intel/i440bx/debug.c b/src/northbridge/intel/i440bx/debug.c
index 63b8e8f..ce808cf 100644
--- a/src/northbridge/intel/i440bx/debug.c
+++ b/src/northbridge/intel/i440bx/debug.c
@@ -38,15 +38,13 @@
void dump_pci_device(unsigned int dev)
{
int i;
- printk(BIOS_DEBUG, "PCI: %02x:%02x.%02x\n", (dev >> 20) & 0xff, (dev >> 15) & 0x1f, (dev >> 12) & 7);
+ printk(BIOS_DEBUG, "PCI: %02x:%02x.%02x", (dev >> 20) & 0xff, (dev >> 15) & 0x1f,
+ (dev >> 12) & 7);
for (i = 0; i <= 255; i++) {
- unsigned char val;
- val = pci_read_config8(dev, i);
if ((i & 0x0f) == 0)
- printk(BIOS_DEBUG, "%02x:", i);
- printk(BIOS_DEBUG, " %02x", val);
- if ((i & 0x0f) == 0x0f)
- printk(BIOS_DEBUG, "\n");
+ printk(BIOS_DEBUG, "\n%02x:", i);
+ printk(BIOS_DEBUG, " %02x", pci_read_config8(dev, i));
}
+ printk(BIOS_DEBUG, "\n");
}