commit a8753e9cbbfc38516b68eab14b806c441c6276b9
author Angel Pons <th3fanbus@gmail.com> Sat Apr 17 14:34:37 2021 +0200
committer Angel Pons <th3fanbus@gmail.com> Mon Apr 26 18:39:58 2021 +0000
tree 44b231a2c36e8fc185e9a33b2fe77f45a48e11e7
parent cf730ce481a5d38611de68ef1dfe5fb3d51c275a

haswell/broadwell: Replace remaining MCHBAR accessors

Tested with BUILD_TIMELESS=1, Asrock B85M Pro4 and Purism Librem 13 v1
remain identical.

Change-Id: I74b633fb0b012304b5b4bd943272ed82dcb6f7d5
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52468
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>

src/soc/intel/broadwell/finalize.c

diff --git a/src/soc/intel/broadwell/finalize.c b/src/soc/intel/broadwell/finalize.c
index 3dafc9d..752b8e5 100644
--- a/src/soc/intel/broadwell/finalize.c
+++ b/src/soc/intel/broadwell/finalize.c
@@ -33,20 +33,20 @@
 	pci_or_config32(host_bridge, TSEG,        1 << 0);
 	pci_or_config32(host_bridge, TOLUD,       1 << 0);
 
-	MCHBAR32(0x50fc) |= 0x8f;	/* MC */
-	MCHBAR32(0x5500) |= 1 << 0;	/* PAVP */
-	MCHBAR32(0x5880) |= 1 << 5;	/* DDR PTM */
-	MCHBAR32(0x7000) |= 1 << 31;
-	MCHBAR32(0x77fc) |= 1 << 0;
-	MCHBAR32(0x7ffc) |= 1 << 0;
-	MCHBAR32(0x6800) |= 1 << 31;
-	MCHBAR32(0x6020) |= 1 << 0;	/* UMA GFX */
-	MCHBAR32(0x63fc) |= 1 << 0;	/* VTDTRK */
+	mchbar_setbits32(0x50fc, 0x8f);		/* MC */
+	mchbar_setbits32(0x5500, 1 << 0);	/* PAVP */
+	mchbar_setbits32(0x5880, 1 << 5);	/* DDR PTM */
+	mchbar_setbits32(0x7000, 1 << 31);
+	mchbar_setbits32(0x77fc, 1 << 0);
+	mchbar_setbits32(0x7ffc, 1 << 0);
+	mchbar_setbits32(0x6800, 1 << 31);
+	mchbar_setbits32(0x6020, 1 << 0);		/* UMA GFX */
+	mchbar_setbits32(0x63fc, 1 << 0);		/* VTDTRK */
 
 	/* Read+write the following */
-	MCHBAR32(0x6030) = MCHBAR32(0x6030);
-	MCHBAR32(0x6034) = MCHBAR32(0x6034);
-	MCHBAR32(0x6008) = MCHBAR32(0x6008);
+	mchbar_setbits32(0x6030, 0);
+	mchbar_setbits32(0x6034, 0);
+	mchbar_setbits32(0x6008, 0);
 }
 
 static void broadwell_finalize(void *unused)