commit 993092039be26a4c822a05e345eada72654adf65
author Felix Held <felix-coreboot@felixheld.de> Tue Dec 13 18:36:24 2022 +0100
committer Felix Held <felix-coreboot@felixheld.de> Wed Dec 14 17:57:45 2022 +0000
tree 93c278eb2bb674658d1be1b3c66d62260f856cbf
parent 687ec6bd7203ad3f1fcf3c03c49d8255ac77d16e

soc/amd/*/config: drop invalid comment

Since commit 28e61f16341f ("device: Use __pci_0_00_0_config in
config_of_soc()") config_of_soc() was changed form being an actual
function to a macro for the __pci_0_00_0_config struct pointer generated
by util/sconfig. This change didn't only improve linker optimizations,
but also turned runtime errors into link-time errors, so it's guaranteed
that __pci_0_00_0_config won't be NULL and config_of_soc() won't
"return" NULL.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Id99ceaa9f7a70788da3f3068fb3da92d34fb6361
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70732
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Reviewed-by: Varshit Pandya <pandyavarshit@gmail.com>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>

src/soc/amd/cezanne/config.c

diff --git a/src/soc/amd/cezanne/config.c b/src/soc/amd/cezanne/config.c
index 577f2ae..5db488c 100644
--- a/src/soc/amd/cezanne/config.c
+++ b/src/soc/amd/cezanne/config.c
@@ -6,7 +6,6 @@
 
 const struct soc_amd_common_config *soc_get_common_config(void)
 {
-	/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
 	const struct soc_amd_cezanne_config *cfg = config_of_soc();
 	return &cfg->common_config;
 }

src/soc/amd/glinda/config.c

diff --git a/src/soc/amd/glinda/config.c b/src/soc/amd/glinda/config.c
index f667475..371cfeb 100644
--- a/src/soc/amd/glinda/config.c
+++ b/src/soc/amd/glinda/config.c
@@ -6,7 +6,6 @@
 
 const struct soc_amd_common_config *soc_get_common_config(void)
 {
-	/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
 	const struct soc_amd_glinda_config *cfg = config_of_soc();
 	return &cfg->common_config;
 }

src/soc/amd/mendocino/config.c

diff --git a/src/soc/amd/mendocino/config.c b/src/soc/amd/mendocino/config.c
index 9030ed0..f1d335e 100644
--- a/src/soc/amd/mendocino/config.c
+++ b/src/soc/amd/mendocino/config.c
@@ -8,7 +8,6 @@
 
 const struct soc_amd_common_config *soc_get_common_config(void)
 {
-	/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
 	const struct soc_amd_mendocino_config *cfg = config_of_soc();
 	return &cfg->common_config;
 }

src/soc/amd/morgana/config.c

diff --git a/src/soc/amd/morgana/config.c b/src/soc/amd/morgana/config.c
index 161d86c..0728f15 100644
--- a/src/soc/amd/morgana/config.c
+++ b/src/soc/amd/morgana/config.c
@@ -6,7 +6,6 @@
 
 const struct soc_amd_common_config *soc_get_common_config(void)
 {
-	/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
 	const struct soc_amd_morgana_config *cfg = config_of_soc();
 	return &cfg->common_config;
 }

src/soc/amd/picasso/config.c

diff --git a/src/soc/amd/picasso/config.c b/src/soc/amd/picasso/config.c
index f1384bb..1836825 100644
--- a/src/soc/amd/picasso/config.c
+++ b/src/soc/amd/picasso/config.c
@@ -6,7 +6,6 @@
 
 const struct soc_amd_common_config *soc_get_common_config(void)
 {
-	/* config_of_soc calls die() internally if cfg was NULL, so no need to re-check */
 	const struct soc_amd_picasso_config *cfg = config_of_soc();
 	return &cfg->common_config;
 }